sr-dev December 2024

sr-dev@lists.kamailio.org

17 participants
343 discussions

git:master:f0095466: core: info log when no r-uri or branches found for print_dset()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f0095466c2847c996440c45a8f728adc16f09579 URL: https://github.com/kamailio/kamailio/commit/f0095466c2847c996440c45a8f728ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-19T09:24:41+01:00 core: info log when no r-uri or branches found for print_dset() --- Modified: src/core/dset.c --- Diff: https://github.com/kamailio/kamailio/commit/f0095466c2847c996440c45a8f728ad… Patch: https://github.com/kamailio/kamailio/commit/f0095466c2847c996440c45a8f728ad… --- diff --git a/src/core/dset.c b/src/core/dset.c index 88b477cdff1..e30277eb7ea 100644 --- a/src/core/dset.c +++ b/src/core/dset.c @@ -739,8 +739,8 @@ char *print_dset(struct sip_msg *msg, int *len, int options) } if(cnt == 0) { - LM_WARN("no r-uri or branches\n"); - goto error; + LM_INFO("no new r-uri or branches\n"); + goto notfound; } if(p + CRLF_LEN + 1 > end) { @@ -753,7 +753,7 @@ char *print_dset(struct sip_msg *msg, int *len, int options) memfail: LM_ERR("redirection buffer length exceed\n"); -error: +notfound: *len = 0; set_branch_iterator(crt_branch); return 0;

1 month, 2 weeks

[kamailio/kamailio] pre-commit: cmake-format and cmake-lint hooks [skip ci] (PR #4066)

by Victor Seva

@xkaraman I hope you will agree to add this jobs related to cmake files to keep things tidy. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4066 -- Commit Summary -- * pre-commit: cmake-format and cmake-lint hooks [skip ci] -- File Changes -- M .pre-commit-config.yaml (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4066.patch https://github.com/kamailio/kamailio/pull/4066.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4066 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4066(a)github.com>

1 month, 2 weeks

[kamailio/kamailio] export subscribe operation functions (PR #4071)

by Farzaneh Soltanzadeh

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR adds media forking support to the rtpengine module by exposing three functions: rtpengine_copy_offer_f(): Sends a subscribe request to RTPEngine. rtpengine_copy_answer_f(): Sends a subscribe answer to RTPEngine. rtpengine_copy_delete_f(): Sends an unsubscribe request to RTPEngine. These functions enable interaction with RTPEngine for managing media subscriptions, allowing for scenarios like media duplication or forking. This feature is based on the OpenSIPS RTPEngine module and provides similar functionality for handling media operations. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4071 -- Commit Summary -- * export subscribe operation functions -- File Changes -- M src/modules/rtpengine/api.h (20) M src/modules/rtpengine/rtpengine.c (217) M src/modules/rtpengine/rtpengine.h (17) A src/modules/rtpengine/rtpengine_common.h (28) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4071.patch https://github.com/kamailio/kamailio/pull/4071.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4071 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4071(a)github.com>

1 month, 2 weeks

git:master:7a511fd0: rtpengine: export subscribe operation functions

by Richard Fuchs

Module: kamailio Branch: master Commit: 7a511fd092b124cd5125327a4e44732d5cc1ad8e URL: https://github.com/kamailio/kamailio/commit/7a511fd092b124cd5125327a4e44732… Author: Farzaneh Soltanzadeh <fr.soltanzadeh(a)resaa.net> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2024-12-18T07:37:31-04:00 rtpengine: export subscribe operation functions --- Added: src/modules/rtpengine/rtpengine_common.h Modified: src/modules/rtpengine/api.h Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine.h --- Diff: https://github.com/kamailio/kamailio/commit/7a511fd092b124cd5125327a4e44732… Patch: https://github.com/kamailio/kamailio/commit/7a511fd092b124cd5125327a4e44732…

1 month, 2 weeks

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)

by Xenofon Karamanos

Yes, i tried that everything that is generated from `CMake` to be inside the `CMAKE_BINARY_DIR` aka build folder and it's respective subfolders and not pollute the src tree in any way. Picking that they are the same is actually a good sign, that it produced identical output! But I also believe they shouldn't exist in source tree, for whatever reason. If you want or need them, use them from the build directory. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150488267(a)github.com>

1 month, 2 weeks

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)

by Daniel-Constantin Mierla

Pushed another commit (05bb67d91c8c7ffc0b68513d46e1de5f68124800) to remove these files from glob result over core source folder -- the ones generated by cmake are in bin folder not in src, but I guess they were detected as being the same and thus the warnings. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150487722(a)github.com>

1 month, 2 weeks

git:master:05bb67d9: core/CMakeLists.txt: remove lex.yy.c and cfg.tab.c from glob sources

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 05bb67d91c8c7ffc0b68513d46e1de5f68124800 URL: https://github.com/kamailio/kamailio/commit/05bb67d91c8c7ffc0b68513d46e1de5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-18T11:51:53+01:00 core/CMakeLists.txt: remove lex.yy.c and cfg.tab.c from glob sources - they might be generated by other tools for debugging or, for now, the old makefiles while analysing differences with cmake --- Modified: src/core/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/05bb67d91c8c7ffc0b68513d46e1de5… Patch: https://github.com/kamailio/kamailio/commit/05bb67d91c8c7ffc0b68513d46e1de5… --- diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index cbda772884a..750af9b7b1b 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt @@ -50,6 +50,8 @@ add_custom_target( # ----------------------- file(GLOB_RECURSE kamailio_SRC "*.c") +list(REMOVE_ITEM kamailio_SRC ${CMAKE_CURRENT_SOURCE_DIR}/cfg.tab.c + ${CMAKE_CURRENT_SOURCE_DIR}/lex.yy.c) set(kamailio_SRC_FILES ${kamailio_SRC} PARENT_SCOPE

1 month, 2 weeks

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)

by Xenofon Karamanos

Yeah probably they exist in your source tree under `src/core/` as well by invociking the old Makefiles? So, they are picked up by the `GLOB` as well. These generated files should not be in the source tree but in the build tree instead. Some also argue they shouldn't even be tracked, since they can offer different things with different options and therefore should be generated everytime when options change. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150487124(a)github.com>

1 month, 2 weeks

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)

by Daniel-Constantin Mierla

I reverted the commit since it was reported to break on some OSes. On macos with cmake version 3.29.5 I get this warnings. I have to investigate further, it might be my local dev setup. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150487013(a)github.com>

1 month, 2 weeks

git:master:0694eb74: Revert "src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c"

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0694eb74d91aaf8584f23ee934a36f2dc16a0fdf URL: https://github.com/kamailio/kamailio/commit/0694eb74d91aaf8584f23ee934a36f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-18T11:26:31+01:00 Revert "src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c" This reverts commit da629accb2c2095e3255f4aa3389a0af02272980. --- Modified: src/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/0694eb74d91aaf8584f23ee934a36f2… Patch: https://github.com/kamailio/kamailio/commit/0694eb74d91aaf8584f23ee934a36f2… --- diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index b08d6e3603d..2b02f33098f 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -104,7 +104,8 @@ add_subdirectory(modules) # Module subdiretory does not contribute to the Kamailio executable. target_sources( kamailio - PRIVATE ${kamailio_SRC_FILES} + PRIVATE ${kamailio_SRC_FILES} ${CMAKE_CURRENT_BINARY_DIR}/core/lex.yy.c + ${CMAKE_CURRENT_BINARY_DIR}/core/cfg.tab.c ) target_include_directories(kamailio PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/core)

1 month, 2 weeks

← Newer
1
...
7
8
9
10
11
12
13
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2024