sr-dev December 2024

sr-dev@lists.kamailio.org

17 participants
351 discussions

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)
by Xenofon Karamanos 18 Dec '24

18 Dec '24

Yeah probably they exist in your source tree under `src/core/` as well by invociking the old Makefiles? So, they are picked up by the `GLOB` as well. These generated files should not be in the source tree but in the build tree instead. Some also argue they shouldn't even be tracked, since they can offer different things with different options and therefore should be generated everytime when options change. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150487124(a)github.com>

1 0

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)
by Daniel-Constantin Mierla 18 Dec '24

18 Dec '24

I reverted the commit since it was reported to break on some OSes. On macos with cmake version 3.29.5 I get this warnings. I have to investigate further, it might be my local dev setup. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150487013(a)github.com>

1 0

git:master:0694eb74: Revert "src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c"
by Daniel-Constantin Mierla 18 Dec '24

18 Dec '24

Module: kamailio Branch: master Commit: 0694eb74d91aaf8584f23ee934a36f2dc16a0fdf URL: https://github.com/kamailio/kamailio/commit/0694eb74d91aaf8584f23ee934a36f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-18T11:26:31+01:00 Revert "src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c" This reverts commit da629accb2c2095e3255f4aa3389a0af02272980. --- Modified: src/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/0694eb74d91aaf8584f23ee934a36f2… Patch: https://github.com/kamailio/kamailio/commit/0694eb74d91aaf8584f23ee934a36f2… --- diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index b08d6e3603d..2b02f33098f 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -104,7 +104,8 @@ add_subdirectory(modules) # Module subdiretory does not contribute to the Kamailio executable. target_sources( kamailio - PRIVATE ${kamailio_SRC_FILES} + PRIVATE ${kamailio_SRC_FILES} ${CMAKE_CURRENT_BINARY_DIR}/core/lex.yy.c + ${CMAKE_CURRENT_BINARY_DIR}/core/cfg.tab.c ) target_include_directories(kamailio PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/core)

1 0

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)
by Xenofon Karamanos 18 Dec '24

18 Dec '24

Hey @miconda, These files are generated from other files and do not exist in the source tree, when configuring. They are produced during the build step and therefore I needed to find a way to list them at sources so they don't produce the errors above. If you search `CMakeLists.txt`, you can see the `custom_commands` that generate them and `CMake` knows not to error if not found because they are `OUTPUT` of these commands and instead built them. I haven't seen these warning before. ``` - warnings shown before: Warning: Source file ".../src/core/lex.yy.c" is listed multiple times for target "kamailio". Warning: Source file ".../src/core/cfg.tab.c" is listed multiple times for target "kamailio" ``` Did you make any change before that might included this? There is only one place that list this source files as source and its here ``` target_sources( kamailio PRIVATE ${kamailio_SRC_FILES} ${CMAKE_CURRENT_BINARY_DIR}/core/lex.yy.c ${CMAKE_CURRENT_BINARY_DIR}/core/cfg.tab.c ) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150486656(a)github.com>

1 0

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)
by Daniel-Constantin Mierla 18 Dec '24

18 Dec '24

What is the operating system and the cmake version you have? I tested on macos with cmake version 3.29.5. and on debian 11 (32b) with cmake version 3.18.4. Also, do you have the latest kamailio from git master branch? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150486180(a)github.com>

1 0

Re: [kamailio/kamailio] src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c (da629ac)
by space88man 18 Dec '24

18 Dec '24

This commit seems to have broken the build: I am seeing the same error as CI/CD ``` /usr/bin/ld: CMakeFiles/kamailio.dir/main.c.o: in function `main': /home/centos/src/kamailio-5.8/build/src/main.c:2509: undefined reference to `pp_define_set_type' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/main.c:2510: undefined reference to `pp_define' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/main.c:2516: undefined reference to `pp_define_set' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/main.c:2745: undefined reference to `yyin' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/main.c:2747: undefined reference to `ksr_cfg_print_initial_state' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/main.c:2748: undefined reference to `yyparse' /usr/bin/ld: CMakeFiles/kamailio.dir/core/core_cmd.c.o: in function `core_ppdefines': /home/centos/src/kamailio-5.8/build/src/core/core_cmd.c:1008: undefined reference to `pp_get_define_name' /usr/bin/ld: CMakeFiles/kamailio.dir/core/core_cmd.c.o: in function `core_ppdefines_full': /home/centos/src/kamailio-5.8/build/src/core/core_cmd.c:1033: undefined reference to `pp_get_define' /usr/bin/ld: CMakeFiles/kamailio.dir/core/ppcfg.c.o: in function `pp_substdef_add': /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:171: undefined reference to `pp_define_set_type' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:172: undefined reference to `pp_define' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:199: undefined reference to `pp_define_set' /usr/bin/ld: CMakeFiles/kamailio.dir/core/ppcfg.c.o: in function `pp_define_core': /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:312: undefined reference to `pp_define_set_type' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:313: undefined reference to `pp_define' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:324: undefined reference to `pp_define_set_type' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:325: undefined reference to `pp_define' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:337: undefined reference to `pp_define_set_type' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:338: undefined reference to `pp_define' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:344: undefined reference to `pp_define_set_type' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:345: undefined reference to `pp_define' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:360: undefined reference to `pp_define_set' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:365: undefined reference to `pp_define' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:369: undefined reference to `pp_define_set' /usr/bin/ld: CMakeFiles/kamailio.dir/core/ppcfg.c.o: in function `pp_snexpr_defval': /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:384: undefined reference to `pp_lookup' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:389: undefined reference to `pp_get_define' /usr/bin/ld: CMakeFiles/kamailio.dir/core/ppcfg.c.o: in function `pp_ifexp_eval': /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:434: undefined reference to `pp_ifexp_state' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:442: undefined reference to `pp_ifexp_state' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/ppcfg.c:468: undefined reference to `pp_ifexp_state' /usr/bin/ld: CMakeFiles/kamailio.dir/core/pv_core.c.o: in function `pv_get_def': /home/centos/src/kamailio-5.8/build/src/core/pv_core.c:136: undefined reference to `pp_define_get' /usr/bin/ld: CMakeFiles/kamailio.dir/core/pv_core.c.o: in function `pv_get_defn': /home/centos/src/kamailio-5.8/build/src/core/pv_core.c:160: undefined reference to `pp_define_get' /usr/bin/ld: CMakeFiles/kamailio.dir/core/sr_module.c.o: in function `register_module': /home/centos/src/kamailio-5.8/build/src/core/sr_module.c:332: undefined reference to `pp_define_set_type' /usr/bin/ld: /home/centos/src/kamailio-5.8/build/src/core/sr_module.c:333: undefined reference to `pp_define' ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980/150485816(a)github.com>

1 0

git:master:da629acc: src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c
by Daniel-Constantin Mierla 18 Dec '24

18 Dec '24

Module: kamailio Branch: master Commit: da629accb2c2095e3255f4aa3389a0af02272980 URL: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-18T08:48:02+01:00 src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c - they should be included by the GLOB of source files - warnings shown before: Warning: Source file ".../src/core/lex.yy.c" is listed multiple times for target "kamailio". Warning: Source file ".../src/core/cfg.tab.c" is listed multiple times for target "kamailio" --- Modified: src/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… Patch: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0a… --- diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 2b02f33098f..b08d6e3603d 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -104,8 +104,7 @@ add_subdirectory(modules) # Module subdiretory does not contribute to the Kamailio executable. target_sources( kamailio - PRIVATE ${kamailio_SRC_FILES} ${CMAKE_CURRENT_BINARY_DIR}/core/lex.yy.c - ${CMAKE_CURRENT_BINARY_DIR}/core/cfg.tab.c + PRIVATE ${kamailio_SRC_FILES} ) target_include_directories(kamailio PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/core)

1 0

git:master:96c9317b: pkg/kamailio/deb: version set 6.0.0~pre0
by Victor Seva 17 Dec '24

17 Dec '24

Module: kamailio Branch: master Commit: 96c9317b5f7a52eba94286dbe832d4bb1e4efd48 URL: https://github.com/kamailio/kamailio/commit/96c9317b5f7a52eba94286dbe832d4b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-12-17T20:15:48+01:00 pkg/kamailio/deb: version set 6.0.0~pre0 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/noble/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/96c9317b5f7a52eba94286dbe832d4b… Patch: https://github.com/kamailio/kamailio/commit/96c9317b5f7a52eba94286dbe832d4b…

1 0

git:master:da1c3456: cmake/modules-docs.cmake: added COMMENT to target definitions
by Daniel-Constantin Mierla 17 Dec '24

17 Dec '24

Module: kamailio Branch: master Commit: da1c3456054fbfc3a353b5462fe4e27e852c8e47 URL: https://github.com/kamailio/kamailio/commit/da1c3456054fbfc3a353b5462fe4e27… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-17T19:28:54+01:00 cmake/modules-docs.cmake: added COMMENT to target definitions --- Modified: cmake/modules-docs.cmake --- Diff: https://github.com/kamailio/kamailio/commit/da1c3456054fbfc3a353b5462fe4e27… Patch: https://github.com/kamailio/kamailio/commit/da1c3456054fbfc3a353b5462fe4e27… --- diff --git a/cmake/modules-docs.cmake b/cmake/modules-docs.cmake index 3084632ade8..c33c6ff5363 100644 --- a/cmake/modules-docs.cmake +++ b/cmake/modules-docs.cmake @@ -85,20 +85,25 @@ else() add_custom_target( ${MODULE_NAME}_doc_text DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${MODULE_NAME}/${MODULE_NAME}.txt + COMMENT "Processing target ${MODULE_NAME}_doc_text" ) add_custom_target( ${MODULE_NAME}_readme DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${MODULE_NAME}/README + COMMENT "Processing target ${MODULE_NAME}_readme" ) add_custom_target( - ${MODULE_NAME}_doc_html DEPENDS ${DOCS_OUTPUT_DIR}/${MODULE_NAME}.html + ${MODULE_NAME}_doc_html + DEPENDS ${DOCS_OUTPUT_DIR}/${MODULE_NAME}.html + COMMENT "Processing target ${MODULE_NAME}_doc_html" ) add_custom_target( - ${MODULE_NAME}_doc DEPENDS ${MODULE_NAME}_doc_text - ${MODULE_NAME}_doc_html + ${MODULE_NAME}_doc + DEPENDS ${MODULE_NAME}_doc_text ${MODULE_NAME}_doc_html + COMMENT "Processing target ${MODULE_NAME}_doc" ) # Each version has seperate custon coommands for not recompiling all if 1

1 0

git:master:6f54793e: cmake/modules-docs.cmake: added target to generate readme for modules
by Daniel-Constantin Mierla 17 Dec '24

17 Dec '24

Module: kamailio Branch: master Commit: 6f54793ebbd86f898be749f9e6b00274ccb1f631 URL: https://github.com/kamailio/kamailio/commit/6f54793ebbd86f898be749f9e6b0027… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-17T19:15:34+01:00 cmake/modules-docs.cmake: added target to generate readme for modules - e.g., make acc_readme --- Modified: cmake/modules-docs.cmake --- Diff: https://github.com/kamailio/kamailio/commit/6f54793ebbd86f898be749f9e6b0027… Patch: https://github.com/kamailio/kamailio/commit/6f54793ebbd86f898be749f9e6b0027… --- diff --git a/cmake/modules-docs.cmake b/cmake/modules-docs.cmake index 53beeae6fb9..3084632ade8 100644 --- a/cmake/modules-docs.cmake +++ b/cmake/modules-docs.cmake @@ -87,6 +87,11 @@ else() DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${MODULE_NAME}/${MODULE_NAME}.txt ) + add_custom_target( + ${MODULE_NAME}_readme + DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${MODULE_NAME}/README + ) + add_custom_target( ${MODULE_NAME}_doc_html DEPENDS ${DOCS_OUTPUT_DIR}/${MODULE_NAME}.html ) @@ -117,6 +122,16 @@ else() "Generating text documentation with xsltproc and lynx for ${MODULE_NAME}" ) + add_custom_command( + OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/${MODULE_NAME}/README + COMMAND + ${CMAKE_COMMAND} -E copy + ${CMAKE_CURRENT_BINARY_DIR}/${MODULE_NAME}/${MODULE_NAME}.txt + ${CMAKE_CURRENT_SOURCE_DIR}/${MODULE_NAME}/README + DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${MODULE_NAME}/${MODULE_NAME}.txt + COMMENT "Generating README file for module ${MODULE_NAME}" + ) + add_custom_command( OUTPUT ${DOCS_OUTPUT_DIR}/${MODULE_NAME}.html COMMAND @@ -145,6 +160,5 @@ else() OPTIONAL ) endif() - endfunction() endif()

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
36
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2024