sr-dev May 2025

sr-dev@lists.kamailio.org

15 participants
183 discussions

git:master:46548193: pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 46548193144c0b8ab0bf2e3ecdfd7feb79bc3b2f URL: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T19:16:55+02:00 pua_dialoginfo.c: fix condition for refresh_pubruri_avps_flag --- Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… Patch: https://github.com/kamailio/kamailio/commit/46548193144c0b8ab0bf2e3ecdfd7fe… --- diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c b/src/modules/pua_dialoginfo/pua_dialoginfo.c index 26883cc27ad..09d25a67ea3 100644 --- a/src/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c @@ -381,12 +381,9 @@ static void __dialog_sendpublish( uri = callee_entity_when_publish_disabled; } - if(use_pubruri_avps - && (refresh_pubruri_avps_flag > -1 - || (request - && (request->flags - & (1U << (unsigned int) - refresh_pubruri_avps_flag))))) { + if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1) && (request != NULL) + && (request->flags + & (1U << (unsigned int)refresh_pubruri_avps_flag))) { lock_get(&dlginfo->lock); refresh_pubruri_avps(dlginfo, &uri); } @@ -584,12 +581,9 @@ static void __dialog_sendpublish( } } - if(use_pubruri_avps - && (refresh_pubruri_avps_flag > -1 - || (request - && (request->flags - & (1U << (unsigned int) - refresh_pubruri_avps_flag))))) { + if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1) && (request != NULL) + && (request->flags + & (1U << (unsigned int)refresh_pubruri_avps_flag))) { lock_release(&dlginfo->lock); } }

1 0

git:master:423f46e6: carrierroute: check pointer and length for str value
by Daniel-Constantin Mierla 26 May '25

26 May '25

Module: kamailio Branch: master Commit: 423f46e6a68e241ef03f59f863ecf6dee92c07db URL: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-26T18:58:59+02:00 carrierroute: check pointer and length for str value --- Modified: src/modules/carrierroute/cr_rpc_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… Patch: https://github.com/kamailio/kamailio/commit/423f46e6a68e241ef03f59f863ecf6d… --- diff --git a/src/modules/carrierroute/cr_rpc_helper.c b/src/modules/carrierroute/cr_rpc_helper.c index fa1537151df..5077875bce5 100644 --- a/src/modules/carrierroute/cr_rpc_helper.c +++ b/src/modules/carrierroute/cr_rpc_helper.c @@ -107,7 +107,7 @@ static int update_route_data_recursor( if(rr->host.s) { shm_free(rr->host.s); } - if(opts->new_host.len) { + if(opts->new_host.s && opts->new_host.len) { if((rr->host.s = shm_malloc(opts->new_host.len + 1)) == NULL) { SHM_MEM_ERROR; @@ -132,12 +132,10 @@ static int update_route_data_recursor( FIFO_ERR(E_RESET); return -1; } - if(opts->new_host.len > 0) { + if(opts->new_host.s && opts->new_host.len > 0) { LM_INFO("deactivating host %.*s\n", rr->host.len, rr->host.s); - if(opts->new_host.s - && (strcmp(opts->new_host.s, rr->host.s) - == 0)) { + if(strcmp(opts->new_host.s, rr->host.s) == 0) { LM_ERR("Backup host the same as initial host " "%.*s", rr->host.len, rr->host.s);

1 0

[kamailio/kamailio] failed alpine docker image build (Issue #4241)
by sergey-safarov 24 May '25

24 May '25

sergey-safarov created an issue (kamailio/kamailio#4241) ### Description In the GitHub Actions present Alpine Docker image build error ``` tar (child): kamailio_min-without_os_files.tar.gz: Cannot open: No such file or directory tar (child): Error is not recoverable: exiting now tar: Child returned status 2 tar: Error is not recoverable: exiting now ``` https://github.com/kamailio/kamailio/actions/runs/14722992691/job/413201110… With high probability, this does not work I will work to fix this, but if possible, it will be fine to switch to use `cmake` for Alpine Docker image. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4241 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4241(a)github.com>

2 5

[kamailio/kamailio] memory leak in avp cleanup (Issue #4257)
by sergey-safarov 23 May '25

23 May '25

sergey-safarov created an issue (kamailio/kamailio#4257) ### Description We found a memory leak in the AVP cleanup ### Troubleshooting #### Reproduction To reproduce, you need to start Kaamilio 5.8 branch with the config ``` listen=127.0.0.1:5060 tcp_send_timeout=3 loadmodule "xlog.so" loadmodule "kex.so" loadmodule "pv.so" loadmodule "ctl.so" loadmodule "jsonrpcs.so" loadmodule "tm.so" loadmodule "siptrace.so" modparam("siptrace", "trace_to_database", 0) modparam("siptrace", "trace_on", 1) modparam("siptrace", "trace_mode", 1) modparam("siptrace", "trace_init_mode", 1) loadmodule "permissions.so" modparam("permissions", "address_file", "address.list") modparam("permissions", "peer_tag_avp", "$avp(s:tag)") modparam("permissions", "peer_tag_mode", 0) modparam("permissions", "load_backends", 1) modparam("permissions", "reload_delta", 1) loadmodule "dispatcher.so" modparam("dispatcher", "list_file", "/tmp/dispatcher.list") modparam("dispatcher", "ds_ping_from", "sip:proxy@aggregator.nga911.com") modparam("dispatcher", "ds_ping_interval", 3) modparam("dispatcher", "ds_probing_mode", 1) route{ drop; } event_route[siptrace:msg] { if (allow_address("1", "$siptrace(src_hostip)", "0")) { xerr("SIP message from $siptrace(src_hostip)\n"); } } ``` Also need to create `address.list` with content ``` # address file - records to match with allow_address(...) and variants # * file format details # - comments start with # and go to end of line # - each line corresponds to a record with following attributes: # # (groupid,int) (address,str) (netmask,int,o), (port,int,o) (tag,str,o) # # * description of the tokens used to describe line format # - int: expected integer value # - str: expected string value # - o: optional field 1 127.0.0.0 16 0 tag ``` and `/tmp/dispatcher.list` with content ``` 1 sip:sip.telnyx.com:5060;transport=tcp 8 ``` When kamailio started required to execute a command ``` kamcmd mod.stats core shm| grep avp ``` This will produce output like ``` create_avp(178): 1360 init_avps(92): 16 init_avps(91): 16 ``` Where `create_avp` is constantly increasing -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4257 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4257(a)github.com>

2 1

[kamailio/kamailio] cmake: do not packaged (Issue #4255)
by sergey-safarov 23 May '25

23 May '25

sergey-safarov created an issue (kamailio/kamailio#4255) ### Description I now make testing `cmake` packaging and see this error ``` RPM build errors: Directory not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres File not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres/* ``` ### Troubleshooting #### Reproduction I use this module list for build https://github.com/sergey-safarov/kamailio/blob/master/pkg/kamailio/obs/kam… @xkaraman could you look? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4255 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4255(a)github.com>

2 6

git:master:9a1b9d08: pkg/kamailio: switched RPM packaging to use cmake
by Sergey Safarov 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 9a1b9d08a112745663f37f0dfcbe86a741486da3 URL: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-05-23T18:47:42+03:00 pkg/kamailio: switched RPM packaging to use cmake --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… Patch: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a…

1 0

git:master:57bd37c5: cmake: dbschema Coorect install folder of pi_framework
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 57bd37c54390fdb70520834b0c2eb29fbb79510e URL: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T13:34:50Z cmake: dbschema Coorect install folder of pi_framework --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… Patch: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index dcd7bb0645b..a45e7e85470 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -59,6 +59,8 @@ function(add_db_target db_name xsl_file) set(install_folder "postgres") elseif(db_name STREQUAL "db_text") set(install_folder "dbtext") + elseif(db_name STREQUAL "pi_framework_table" OR db_name STREQUAL "pi_framework_mod") + set(install_folder "xhttp_pi") else() set(install_folder "${db_name}") endif() @@ -101,7 +103,6 @@ function(add_db_target db_name xsl_file) TARGET dbschema_${db_name} POST_BUILD COMMAND ${POSTPROCESS_SCRIPT} 1 1 - # ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} COMMENT "Creating version table for ${db_name}" WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} ) @@ -110,7 +111,6 @@ function(add_db_target db_name xsl_file) TARGET dbschema_${db_name} POST_BUILD COMMAND ${POSTPROCESS_SCRIPT} 2 10 - # ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} COMMENT "Creating version table for ${db_name}" WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} ) @@ -130,7 +130,8 @@ function(add_db_target db_name xsl_file) # message(WARNING "group name is ${group_name}") # Before installing, ensure the target is built `dbschema_${db_name}` # install as previously done in makefile folder. see naming above - # TODO: when tools adopt to new folder structure, remove the install_folder variable + # TODO: when tools adopt to new folder structure, replace the install_folder variable + # with ${db_name_folder} install( DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/

1 0

git:master:c7fcdfdb: cmake: Add some check for finding group name if using non K-variants of group names
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: c7fcdfdb13aeec9aeae726a9cc1ccaeda557e7bb URL: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T11:10:13Z cmake: Add some check for finding group name if using non K-variants of group names --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… Patch: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index a41560f17fc..c629ee49f93 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -764,6 +764,20 @@ function(find_group_name module) "" PARENT_SCOPE ) + # This was need due to the dbschema.cmake + # If one select one of these option as group + # we want the group name to match instead of the actual group it belongs to + if(MODULE_GROUP_NAME STREQUAL "ALL" + OR MODULE_GROUP_NAME STREQUAL "DEFAULT" + OR MODULE_GROUP_NAME STREQUAL "STANDARD" + OR MODULE_GROUP_NAME STREQUAL "COMMON" + ) + set(group_name + "${MODULE_GROUP_NAME}" + PARENT_SCOPE + ) + return() + endif() # message(WARNING "groups to search in" ${MODULE_GROUP_PACKAGE_GROUPS}) # Get all variable names in the current CMake context foreach(group IN LISTS MODULE_GROUP_PACKAGE_GROUPS) @@ -776,6 +790,8 @@ function(find_group_name module) "${group}" PARENT_SCOPE ) + return() endif() endforeach() + message((STATUS "module ${module} not found in any group")) endfunction()

1 0

git:master:0fb18272: cmake: Add missing package KSTANDARD
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 0fb182720428b276793899debb210279a0b5ec97 URL: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T11:10:13Z cmake: Add missing package KSTANDARD - When `ALL_PACKAGED` is used, KSTANDARD should be built as well, but not KMINI which is a subset of it. - Fix RTP_MEDIA group name --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… Patch: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index 90c47413d22..a41560f17fc 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -688,6 +688,7 @@ set(MODULE_GROUP_KRTP_MEDIA_SERVER ${MOD_LIST_RTP_MEDIA_SERVER}) set(STATIC_MODULES "") set(MODULE_GROUP_PACKAGE_GROUPS + KSTANDARD KPCRE KMYSQL KPOSTGRES @@ -748,7 +749,7 @@ set(MODULE_GROUP_PACKAGE_GROUPS KNGHTTP2 KGCRYPT KSECSIPID - KRT_MEDIA_SERVER + KRTP_MEDIA_SERVER ) # Add group names to available group and provide "ALL_PACKAGED" as well

1 0

5.7.7 release, tag and docker build
by Henning Westerholt 23 May '25

23 May '25

Hello, I have noticed that the git tag for release 5.7.7 was missing, I've just set it. The 5.7.7-bullseye docker image is also missing from https://github.com/kamailio/kamailio-docker/pkgs/container/kamailio Not sure if this is done automatically, if not - please can somebody please trigger the workflow to create it? Thank you, Henning

2 3

← Newer
1
2
3
4
5
6
7
8
9
...
19
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2025