kurtyks created an issue (kamailio/kamailio#4316)
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If you submit a feature request (or enhancement) add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
Note that a feature request may be closed automatically after about 2 months
if there is no interest from developers or community users to implement it, being
considered expired. In such case can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the item is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in the proposed feature request.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Expected behavior
#### Actual observed behavior
#### Debugging Data
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
Rn. UAC module allows only global setting of Contact header, while sending REGISTER to UAS. It is done by setting param reg_contact_addr (string).
This is edge case, but sometimes for diffrent itsp’s i need to pass diffrent contact value, while for example one is on public internet, other is behind vpn.
It d be nice just to extend uacreg table + contact_addr, contact_port, contact_user or just by adding contact field with URI to be sent in register.
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a improvement.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
(paste your output here)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4316
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4316(a)github.com>
Module: kamailio
Branch: master
Commit: b83794109113cbbd335625796f55d2b5aaa3968f
URL: https://github.com/kamailio/kamailio/commit/b83794109113cbbd335625796f55d2b…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2025-07-14T13:01:10+02:00
modules: readme files regenerated - dialog ... [skip ci]
---
Modified: src/modules/dialog/README
---
Diff: https://github.com/kamailio/kamailio/commit/b83794109113cbbd335625796f55d2b…
Patch: https://github.com/kamailio/kamailio/commit/b83794109113cbbd335625796f55d2b…
---
diff --git a/src/modules/dialog/README b/src/modules/dialog/README
index be626d40c7c..dab489750b1 100644
--- a/src/modules/dialog/README
+++ b/src/modules/dialog/README
@@ -669,7 +669,7 @@ modparam("dialog", "rr_param", "xyz")
6.4. dlg_flag (integer)
- Note: This flag has beed deprecated and not used anyymore. it is not
+ Note: This flag has beed deprecated and not used anymore. It is not
needed to set this parameter and its corresponding flag for initial
request in case the “dlg_manage()” function is used. In other words,
use “dlg_manage()”.
dilyanpalauzov created an issue (kamailio/kamailio#4321)
With Kamailio 5.8 this worked:
```
FLT_DIALOG=10
modparam("dialog", "dlg_flag", FLT_DIALOG)
```
In version 6.0 it produces an error:
```
0(1) ERROR: <core> [core/modparam.c:187]: set_mod_param_regex(): parameter <dlg_flag> of type <2:int> not found in module <dialog>
0(1) CRITICAL: <core> [core/cfg.y:4049]: yyerror_at(): parse error in config file /conf/kamailio.cfg, line 169, column 34: Can't set module parameter
```
and e60a06469503c566d40437e69cf3374 has removed dialog.dlg_flag option. But https://www.kamailio.org/docs/modules/devel/modules/dialog.html#dialog.p.fl… states for dlg_flag:
> Note: This flag has beed deprecated and not used anymore. It is not needed to set this parameter and its corresponding flag for initial request in case the “dlg_manage()” function is used. In other words, use “dlg_manage()”.
This is not so correct. If it is deprecated, then Kamailio will still work with it. If it is not needed any more to set this parameter, then it means that the parameter can nevertheless be set. But it cannot be set.
* Documentation should state that the parameter is removed, instead of classifying it as deprecated, and there is no need to set it anymore.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4321
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4321(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4322
-- Commit Summary --
* htable: Fix typo
* core: Fix typos
* pv: Fix typo
-- File Changes --
M src/core/parser/parse_fline.c (2)
M src/core/tcp_conn.h (2)
M src/core/timer.h (2)
M src/core/timer_ticks.h (2)
M src/modules/pv/pv.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4322.patchhttps://github.com/kamailio/kamailio/pull/4322.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4322
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4322(a)github.com>
Module: kamailio
Branch: master
Commit: 6b92933080230f9546c9559aba9ecdfad7759a15
URL: https://github.com/kamailio/kamailio/commit/6b92933080230f9546c9559aba9ecdf…
Author: Bastian Triller <bastian.triller(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2025-07-14T12:58:23+02:00
core: Fix typos
---
Modified: src/core/tcp_conn.h
Modified: src/core/timer.h
Modified: src/core/timer_ticks.h
---
Diff: https://github.com/kamailio/kamailio/commit/6b92933080230f9546c9559aba9ecdf…
Patch: https://github.com/kamailio/kamailio/commit/6b92933080230f9546c9559aba9ecdf…
---
diff --git a/src/core/tcp_conn.h b/src/core/tcp_conn.h
index 1fc3c001f15..8b8c71df8ff 100644
--- a/src/core/tcp_conn.h
+++ b/src/core/tcp_conn.h
@@ -40,7 +40,7 @@
#define TCP_CHILD_TIMEOUT \
5 /* after 5 seconds, the child "returns"
- * the connection to the tcp maing process */
+ * the connection to the tcp main process */
#define TCP_MAIN_SELECT_TIMEOUT 5 /* how often "tcp main" checks for timeout*/
#define TCP_CHILD_SELECT_TIMEOUT 2 /* the same as above but for children */
diff --git a/src/core/timer.h b/src/core/timer.h
index b3920163731..73a9d4c48cc 100644
--- a/src/core/timer.h
+++ b/src/core/timer.h
@@ -53,7 +53,7 @@
#ifdef USE_SLOW_TIMER
#include <sys/types.h>
-typedef unsigned int slow_idx_t; /* type fot the slow index */
+typedef unsigned int slow_idx_t; /* type for the slow index */
extern pid_t slow_timer_pid;
#endif
diff --git a/src/core/timer_ticks.h b/src/core/timer_ticks.h
index 292b73e71a9..c5e93aee92e 100644
--- a/src/core/timer_ticks.h
+++ b/src/core/timer_ticks.h
@@ -43,7 +43,7 @@
#define S_TO_TICKS(s) ((s)*TIMER_TICKS_HZ)
-/** @brief how many s pe per t ticks, integer value */
+/** @brief how many seconds per ticks, integer value */
#define TICKS_TO_S(t) ((t) / TIMER_TICKS_HZ)
/** @brief how many ms per t ticks, integer value */