sr-dev

sr-dev@lists.kamailio.org

14 participants
44942 discussions

[kamailio/kamailio] Corrupted output with log-engine json (Issue #4203)
by Matteo 29 Apr '25

29 Apr '25

xadhoom created an issue (kamailio/kamailio#4203)  ### Description Enabled json logging engine, with the following setup: - kam cmd line params: `--log-engine=json:Mp` - prefix: `log_prefix=", \"callid\": \"$ci\",\"srcip\": \"$si\", \"ts\": $TV(Sn), \"method\": \"$rm\", \"mt\": $mt, \"ua\": \"$(ua{s.escape.common})\", \"cseq\": \"$hdr(CSeq)\", \"status\": $rs "` - another prefix (same result): `log_prefix=", \"callid\": \"$ci\", \"ts\": $TV(Sn) "` What I see that certain json lines are truncated, for example - one line is interrupted by another json entry - one line starts "truncated" ### Troubleshooting What I can observe is that seems to happens always with same "kind" of line, usually internal logs, which don't have callid etc. #### Log Messages  The following first 3 lines are ok, then the latest is corrupted: ``` { "time": "2025-04-04T15:51:44.448427533Z", "idx": 193, "pid": 200, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:51:44.448682606Z", "idx": 194, "pid": 201, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448279053Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448505797Z", "idx": 196, "pid": 203, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T15:52:14.448508084Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/parser/msg, "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } ``` or (notice 2nd line or 5th one) ``` { "time": "2025-04-04T16:13:33.789641936Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T16:13:33.789642978Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", ", "line": 265, "function": "ksr_evrt_pre_routing", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "event route core:pre-routing not defined" } line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789646470Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", "line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789648201Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1579, "function": "t_check_msg", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "msg (0x7f{ "time": "2025-04-04T16:13:33.789649346Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/receive.c"8f7a693c50) id=2/228 global id=1/228 T start=0xffffffffffffffff" } , "line": 637, "function": "receive_msg", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "cleaning up" } { "time": "2025-04-04T16:13:33.789652839Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1424, "function": "t_reply_matching", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "t_reply_matching: hash 26404 label 0 branch 0" } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 6.0.1 ``` happens also with 5.8.x * **Operating System**:  ``` Debian noble, docker container ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4203 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4203(a)github.com>

3 8

git:master:2081b3aa: core: utils/tmrec - reworked bymonth matching for negative indexes
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 2081b3aac394223b68b849fbac2a9e5ac4392334 URL: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T11:49:04+02:00 core: utils/tmrec - reworked bymonth matching for negative indexes - GH #4214 --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… Patch: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index d609e136310..eec02d22431 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1104,6 +1104,7 @@ int check_min_unit(tmrec_t *_trp, ac_tm_t *_atp, tr_res_t *_tsw) int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) { int i; + int v; ac_maxval_t *_amp = NULL; if(!_trp || !_atp) return REC_ERR; @@ -1117,10 +1118,12 @@ int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { - if(_atp->t.tm_mon - == ((_trp->bymonth->xxx[i] - 1) * _trp->bymonth->req[i] - + 12) - % 12) + if(_trp->bymonth->req[i] < 0) { + v = 12 - _trp->bymonth->xxx[i]; + } else { + v = _trp->bymonth->xxx[i] - 1; + } + if(_atp->t.tm_mon == v) break; } if(i >= _trp->bymonth->nr)

1 0

[kamailio/kamailio] dispatcher: Check if tm is enabled before probing (PR #4223)
by Xenofon Karamanos 29 Apr '25

29 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4212 #### Description  Probing a host correctly needs the tm module to be loaded. This PR adds a check for when adding a target in dispatcher with probing enabled to verify whether tm is loaded. If it's not, it emmits a warning and disable the probing to the target. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4223 -- Commit Summary -- * dispatcher: Check if tm is enabled before probing -- File Changes -- M src/modules/dispatcher/dispatch.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4223.patch https://github.com/kamailio/kamailio/pull/4223.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4223 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4223(a)github.com>

2 2

git:master:512c5f51: dispatcher: Check if tm is enabled before probing
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 512c5f51bba77529b9cc844a6b4904a1d6275c1e URL: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T09:28:29+02:00 dispatcher: Check if tm is enabled before probing --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… Patch: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index a49e5638cd3..a90daa2abfa 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -745,6 +745,12 @@ ds_dest_t *add_dest2list(int id, str uri, int flags, int priority, str *attrs, ds_dest_t *dp0 = NULL; ds_dest_t *dp1 = NULL; + /* Check if tm binding (by testing tmb.t_gett) is loaded and if not, disable the probing */ + if(tmb.t_gett == NULL && (flags & DS_PROBING_DST)) { + LM_WARN("tm module not loaded, disabling probing\n"); + flags &= ~DS_PROBING_DST; + } + dp = pack_dest(uri, flags, priority, attrs, dload); if(!dp) { goto error;

1 0

[kamailio/kamailio] The <bymonth> logic in tmrec_match() is flawed (Issue #4214)
by intliang 29 Apr '25

29 Apr '25

intliang created an issue (kamailio/kamailio#4214) ### Description The **<bymonth>** comparison logic in **tmrec_match()** fails to properly evaluate equivalence conditions, as shown below: ``` int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) { ... if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { if(_atp->t.tm_mon == (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12) % 12) break; } ... ``` ### Troubleshooting #### Reproduction Rule string: "20250403T100000|PT14H|weekly|20250425T000000|2|-1WE, -2WE|16|||4" Date time: 20250416T190000 Expected output: MATCH Actual output: NOT MATCH  #### Debugging Data  ``` ((lldb) p _trp->bymonth->xxx[0] (int) 4 (lldb) p _trp->bymonth->req[0] (int) 1 (lldb) p _atp->t.tm_mon (int) 3 (lldb) p _trp->bymonth->nr (int) 1 ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions The **tm_mon** field in the tm struct uses a 0-11 range (January=0), while the **<bymonth>** parameter follows a 1-12 convention (January=1) as documented in the tmrec module's README. Therefore, we should first decrement the value of **_trp->bymonth->xxx[i]** by 1 for proper conversion. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.1.0-dev0 (x86_64/Darwin) 9f24f1-dirty flags: , EXTRA_DEBUGUSE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, kqueue. id: 9f24f1 dirty compiled on 11:59:55 Apr 16 2025 with AppleClang 17.0.0.17000013 ``` * **Operating System**: ``` Darwin yintiliangdeMacBook-Pro19.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 18:41:43 PST 2024; root:xnu-11215.61.5~2/RELEASE_X86_64 x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4214 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4214(a)github.com>

2 2

git:master:8f1a8c50: core: utils/tmrec - decrement month for bymonth matching
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 8f1a8c50ff230a1fffdd6b376f172cabe9fe60e3 URL: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T09:23:07+02:00 core: utils/tmrec - decrement month for bymonth matching - struct tm uses 0-11, comparing with 1-12 in the date format - GH #4214 --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… Patch: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index 7cbe6153824..d609e136310 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1118,7 +1118,8 @@ int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { if(_atp->t.tm_mon - == (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12) + == ((_trp->bymonth->xxx[i] - 1) * _trp->bymonth->req[i] + + 12) % 12) break; }

1 0

[kamailio/kamailio] Crash involving rtpengine (Issue #4179)
by Joe Mordica 28 Apr '25

28 Apr '25

jmordica created an issue (kamailio/kamailio#4179) ### Description Kamailio crash involving rtpengine ### Troubleshooting #### Reproduction  #### Debugging Data  ``` GNU gdb (Debian 13.1-3) 13.1 Copyright (C) 2023 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <https://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/sbin/kamailio... Reading symbols from /usr/lib/debug/.build-id/20/dc8be8c0aa02eba62b84db3c283789f068fb79.debug... warning: Can't open file /dev/zero (deleted) during file-backed mapping note processing [New LWP 37] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `kamailio -DD -E -m 8000 -M 512 -f /etc/kamailio/kamailio.cfg -P /var/run/kamail'. Program terminated with signal SIGABRT, Aborted. #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt full #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 tid = <optimized out> ret = 0 pd = <optimized out> old_mask = {__val = {0}} ret = <optimized out> #1 0x00007f0a2dd31f1f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 No locals. #2 0x00007f0a2dce2fb2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 ret = <optimized out> #3 0x00007f0a2dccd472 in __GI_abort () at ./stdlib/abort.c:79 save_stage = 1 act = {__sigaction_handler = {sa_handler = 0x20, sa_sigaction = 0x20}, sa_mask = {__val = {1880844493789993498, 1880844493789993498, 1880844493789993498, 0, 0, 0, 0, 2314885530818453536, 2314885530818453536, 2314885530818453536, 2314885530818453536, 0, 0, 0, 0, 94814674008008}}, sa_flags = 365707264, sa_restorer = 0x563bc3029320 <log_prefix_buf>} #4 0x0000563bc2e27414 in qm_debug_check_frag (qm=qm@entry=0x7f0815cc4000, f=f@entry=0x7f0834533950, file=file@entry=0x7f0a0a93420f "rtpengine: rtpengine_hash.c", line=line@entry=528, eline=eline@entry=546, efile=0x563bc2f6abcc "core/mem/q_malloc.c") at core/mem/q_malloc.c:132 p = <optimized out> __func__ = "qm_debug_check_frag" #5 0x0000563bc2e282b9 in qm_free (qmp=<optimized out>, p=0x7f0834533990, file=0x7f0a0a93420f "rtpengine: rtpengine_hash.c", func=0x7f0a0a935040 <__func__.2> "rtpengine_hash_table_free_entry", line=528, mname=0x7f0a0a92a000 "rtpengine") at core/mem/q_malloc.c:546 qm = <optimized out> f = 0x7f0834533950 size = <optimized out> next = <optimized out> prev = <optimized out> __func__ = "qm_free" #6 0x0000563bc2e2d51f in qm_shm_free (qmp=<optimized out>, p=0x7f0834533990, file=0x7f0a0a93420f "rtpengine: rtpengine_hash.c", func=0x7f0a0a935040 <__func__.2> "rtpengine_hash_table_free_entry", line=528, mname=0x7f0a0a92a000 "rtpengine") at core/mem/q_malloc.c:1532 No locals. #7 0x00007f0a0a922adb in rtpengine_hash_table_free_entry (entry=0x7f08263a3f80) at ./src/modules/rtpengine/rtpengine_hash.c:528 __func__ = "rtpengine_hash_table_free_entry" --Type <RET> for more, q to quit, c to continue without paging--info locals #8 0x00007f0a0a927dd4 in rtpengine_hash_table_lookup (callid=..., viabranch=..., op=op@entry=OP_OFFER) at ./src/modules/rtpengine/rtpengine_hash.c:428 entry = 0x7f08263a3f80 last_entry = 0x7f08174e0450 hash_index = 87 node = <optimized out> __func__ = "rtpengine_hash_table_lookup" #9 0x00007f0a0a90ec2b in select_rtpp_node_old (do_test=1, op=OP_OFFER, viabranch=..., callid=...) at ./src/modules/rtpengine/rtpengine.c:3810 node = 0x0 node = <optimized out> __func__ = "select_rtpp_node_old" __llevel = <optimized out> __kld = <optimized out> __llevel = <optimized out> __kld = <optimized out> #10 select_rtpp_node (callid=..., viabranch=..., queried_nodes_list=0x7f0a0de84430, queried_nodes=queried_nodes@entry=0, op=OP_OFFER, do_test=1) at ./src/modules/rtpengine/rtpengine.c:3864 node = 0x0 __func__ = "select_rtpp_node" #11 0x00007f0a0a91228a in rtpp_function_call (bencbuf=bencbuf@entry=0x7ffeb1d5bea0, msg=msg@entry=0x7f0a0de94350, op=<optimized out>, flags_str=<optimized out>, body_out=body_out@entry=0x7ffeb1d5be80, cl_field=cl_field@entry=0x7ffeb1d5be90) at ./src/modules/rtpengine/rtpengine.c:3178 ng_flags = {via = -1, to = 1, packetize = 0, transport = 256, directional = 0, dict = 0x7f0a0de98b78, flags = 0x7f0a0de98d08, direction = 0x7f0a0de98e68, replace = 0x7f0a0de98ec8, rtcp_mux = 0x7f0a0de98f28, sdes = 0x7f0a0de98f88, t38 = 0x7f0a0de99098, received_from = 0x7f0a0de98e08, codec = 0x7f0a0de990f8, codec_strip = 0x0, codec_offer = 0x0, codec_transcode = 0x0, codec_mask = 0x0, codec_set = 0x0, codec_except = 0x0, codec_accept = 0x0, codec_consume = 0x0, call_id = { s = 0x563bc30e195f <buf+287> "5783b150-6ad4-4e55-9555-decf4048c8fb\r\nCSeq: 23471 INVITE\r\nAllow: OPTIONS, REGISTER, SUBSCRIBE, NOTIFY, PUBLISH, INVITE, ACK, BYE, CANCEL, UPDATE, MESSAGE, INFO, REFER\r\nk: replaces, histinfo\r\nX-UNIQUEI"..., len = 36}, from_tag = { s = 0x563bc30e18fb <buf+187> "47d9d572-1f09-46bf-b966-16988c17cf56\r\nt: <sip:02-5333@10.142.0.56>\r\nm: <sip:vxm@10.52.7.2:5081>\r\ni: 5783b150-6ad4-4e55-9555-decf4048c8fb\r\nCSeq: 23471 INVITE\r\nAllow: OPTIONS, REGISTER, SUBSCRIBE, NOTIF"..., len = 36}, to_tag = {s = 0x0, len = 0}} item = <optimized out> resp = <optimized out> viabranch = {s = 0x7f0a0dd15720 "z9hG4bKPje1c3efee-2490-4035-9e2e-b124ec630b820", len = 46} body = { s = 0x563bc30e1b33 <buf+755> "v=0\r\no=- 1936793669 1936793669 IN IP4 10.52.7.2\r\ns=VXM\r\nc=IN IP4 10.52.7.2\r\nt=0 0\r\nm=audio 18690 RTP/AVP 0 101\r\na=rtpmap:101 telephone-event/8000\r\na=fmtp:101 0-16\r\na=ptime:20\r\na=maxptime:140\r\na=sendre"..., len = 204} --Type <RET> for more, q to quit, c to continue without paging--list error = <optimized out> ret = 1 queried_nodes = 0 cont_type = <optimized out> node = <optimized out> cp = <optimized out> pv_val = {rs = {s = 0x7f083a53d3c0 "p", len = -1025336010}, ri = 47244640256, flags = 1} md5 = "\004\220\361\302;V\000\000\260r\366\302;V", '\000' <repeats 11 times>, "\345\323A\270\253\205\301" branch_buf = "\210\033\016\303;V\000\000\177W\315\302;V\000\000\216\033\016\303;V\000\000\000\345\323A\270\253\205\301\224\033\016\303;V\000\000\000\345\323A\270\253\205\301\220\201\351\r\n\177\000\000\000\345" result = <optimized out> t = <optimized out> branch_idx = <optimized out> __func__ = "rtpp_function_call" select_node = <optimized out> #12 0x00007f0a0a917346 in rtpp_function_call_ok (bencbuf=bencbuf@entry=0x7ffeb1d5bea0, msg=msg@entry=0x7f0a0de94350, op=<optimized out>, flags_str=<optimized out>, body=body@entry=0x7ffeb1d5be80, cl_field=cl_field@entry=0x7ffeb1d5be90) at ./src/modules/rtpengine/rtpengine.c:3371 ret = <optimized out> __func__ = "rtpp_function_call_ok" #13 0x00007f0a0a919708 in rtpengine_offer_answer (msg=0x7f0a0de94350, flags=<optimized out>, op=<optimized out>, more=0) at ./src/modules/rtpengine/rtpengine.c:4495 bencbuf = {pieces = 0x7f0a0de9a270, free_list = 0x0, error = 0} dict = <optimized out> body = {s = 0x7f0a0de94350 "\233@\006", len = 1104405760} newbody = <optimized out> anchor = <optimized out> pv_val = {rs = {s = 0x0, len = 177318755}, ri = 0, flags = 4} cur_body = {s = 0x0, len = 0} cl_field = {s = 0x0, len = 0} cl_repl = {s = 0x0, len = 0} __func__ = "rtpengine_offer_answer" error_free = <optimized out> #14 0x0000563bc2c77195 in sr_kemi_exec_func (ket=ket@entry=0x7f0a0a93d5c8 <sr_kemi_rtpengine_exports+72>, msg=<optimized out>, pno=pno@entry=1, vps=<optimized out>) at core/kemiexec.c:84 ``` #### Log Messages  ``` CRITICAL: {1 23471 INVITE 5783b150-6ad4-4e55-9555-decf4048c8fb} <core> [core/mem/q_malloc.c:148]: qm_debug_check_frag(): BUG: qm: prev. fragm. tail overwritten(c0c00a0d, abcdefed)[0x7f0834533950:0x7f0834533990]! Memory allocator was called from rtpengine: rtpengine_hash.c:528. Fragment marked by rtpengine: ../../core/parser/../ut.h:891. Exec from core/mem/q_malloc.c:546. CRITICAL: {1 23471 INVITE 5783b150-6ad4-4e55-9555-decf4048c8fb} <core> [core/mem/q_malloc.c:156]: qm_debug_check_frag(): BUG: qm: prev. fragm. tail overwritten [0x7f08345335b0:0x7f08345335f0] - fragment marked by core: core/msg_translator.c:2305 ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.5 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**:  ``` Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm Linux gke-us-east1-external-sip-4b67daea-x3rj 5.15.0-1020-gke #25-Ubuntu SMP Thu Oct 27 05:38:18 UTC 2022 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4179 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4179(a)github.com>

4 8

[kamailio/kamailio] Allow single quotes in From name (Issue #3984)
by ThomasSevestre 28 Apr '25

28 Apr '25

### Description `secf_check_sqli_all();` block requests when a single quote is present in From name : ``` From: "O'Reilly" <sip:100@example.net>;tag=abcd ``` Since single quotes are frequent in names. It makes it difficult to use this function. ### Possible Solutions A solution would be to skip single quote check in From name. I'll write the PR if you are OK with this solution -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3984 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3984(a)github.com>

5 10

[kamailio/kamailio] secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all(); (PR #4225)
by Jose Luis Verdeguer 28 Apr '25

28 Apr '25

secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all();   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3984 (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4225 -- Commit Summary -- * secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all(); -- File Changes -- M src/modules/secfilter/secfilter.c (56) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4225.patch https://github.com/kamailio/kamailio/pull/4225.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4225 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4225(a)github.com>

2 2

git:master:2b4e9f8b: secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all();
by Victor Seva 28 Apr '25

28 Apr '25

Module: kamailio Branch: master Commit: 2b4e9f8beeb1643e7a175dea14f9366eac7b11e9 URL: https://github.com/kamailio/kamailio/commit/2b4e9f8beeb1643e7a175dea14f9366… Author: pepelux <pepeluxx(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-28T11:27:23+02:00 secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all(); --- Modified: src/modules/secfilter/secfilter.c --- Diff: https://github.com/kamailio/kamailio/commit/2b4e9f8beeb1643e7a175dea14f9366… Patch: https://github.com/kamailio/kamailio/commit/2b4e9f8beeb1643e7a175dea14f9366…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev