sr-dev

sr-dev@lists.kamailio.org

14 participants
44942 discussions

[kamailio/kamailio] Error when sending NOTIFYs in the presence of disconnected websocket watchers (Issue #4118)
by Flavio Grossi 20 Apr '25

20 Apr '25

### Description if multiple sip websocket clients are subscribed to some UA and one of the watchers suddenly disappears (e.g. the web page is reloaded), then no NOTIFY is ever sent after issuing a `pres_refresh_watchers()`. The following error is logged: ``` WARNING: <core> [core/msg_translator.c:3007]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found ERROR: tm [t_msgbuilder.c:1423]: assemble_via(): via building failed ERROR: tm [t_msgbuilder.c:1614]: build_uac_req(): error while assembling Via ERROR: tm [uac.c:552]: t_uac_prepare(): Error while building message ERROR: presence [notify.c:1734]: send_notify_request(): in function tm t_request_within() ERROR: presence [notify.c:1829]: notify(): sending Notify not successful ERROR: presence [notify.c:1585]: query_db_notify(): Could not send notify for [event]=dialog ERROR: presence [presence.c:739]: pres_refresh_watchers(): sending Notify requests ``` ### Troubleshooting when the client disconnects, the old watcher is not removed from the active_watchers table, instead it coexists with the new one, but the stale connection causes the error above when sending the notify, and then all of the following watchers (even the valid ones) are skipped too. Looking at the logs, the valid watchers are not notified because the while loop [here](https://github.com/kamailio/kamailio/blob/b96bc11a54f11ec688429c057bf… is skipped because of the `goto done` line in case of errors, which happens because it fails to build the via header for the message relevant to the stale websocket connection. By breaking out of the while loop, the remaining subs in the `subs_array` are skipped. #### Reproduction Just subscribe to a sip client using a websocket-based phone, then abruptly disconnect it (e.g. by reloading the web page) and then issue a `pres_refresh_watchers()` to make it generate a notify. #### Debugging Data #### Log Messages #### SIP Traffic ### Possible Solutions I tried to use the "websocket:closed" route to purge stale connections, but to my knowledge there are no APIs to clean invalid watchers. A possible solution could be to automatically remove the watchers on disconnection and maybe skip the invalid ones without exiting from the refresh loop ### Additional Information kamailio 5.8.2 * **Operating System**: Rocky Linux 9 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4118 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4118(a)github.com>

4 5

[kamailio/kamailio] TOPOS removes via header when calling drop in event_route[topos:msg-outgoing] (Issue #4157)
by Brandon Armstead 20 Apr '25

20 Apr '25

CrazyTux created an issue (kamailio/kamailio#4157) ### TOPOS removes via header ``` event_route[topos:msg-outgoing] { # Feature Flag is enabled ** problem occurs here ** if($sht(feature_flags=>kamailio-disable-internal-topos) == "true") { if(ds_is_from_list(KAM_SET_ID, 3, "sip:$sndto(ip):5060")) { drop; } } } ``` ### Troubleshooting - verified via exists in original 200 OK REPLY from Freeswitch - checked wire and verified via header is missing when forwarding 200 OK onward to next kamailio (B) node from Kamailio (A) #### Reproduction Call drop in event route `topos:msg-outgoing` - call flow: Freeswitch -> Kamailio A -> Kamailio B -> UAC - place incoming call into kamailio - put call on hold / reinvite #### Debugging Data ``` Disabling topos entirely via header is correctly sent from A -> B. ``` #### Log Messages (Kamailio B) ``` 2025-02-25T00:19:08.545447+00:00 /usr/sbin/kamailio[3959021]: ERROR: {2 1 INVITE 995df181-4eae-40ae-8225-427ce8252250} <core> [core/receive.c:542]: receive_msg(): no via found in reply 2025-02-25T00:19:09.045917+00:00 /usr/sbin/kamailio[3959037]: ERROR: {2 1 INVITE 995df181-4eae-40ae-8225-427ce8252250} <core> [core/receive.c:542]: receive_msg(): no via found in reply 2025-02-25T00:19:10.046936+00:00 /usr/sbin/kamailio[3958995]: ERROR: {2 1 INVITE 995df181-4eae-40ae-8225-427ce8252250} <core> [core/receive.c:542]: receive_msg(): no via found in reply 2025-02-25T00:19:12.048099+00:00 /usr/sbin/kamailio[3959003]: ERROR: {2 1 INVITE 995df181-4eae-40ae-8225-427ce8252250} <core> [core/receive.c:542]: receive_msg(): no via found in reply ``` #### SIP Traffic `reinvite B -> A:` ``` INVITE sip:mod_sofia@54.245.XX.XX:5060 SIP/2.0 Record-Route: <sip:35.161.XX.XX:5060;r2=on;lr;ftag=9vX27Um099jZS;did=a2b.7e62> Record-Route: <sip:35.161.XX.XX:7443;transport=ws;r2=on;lr;ftag=9vX27Um099jZS;did=a2b.7e62> Via: SIP/2.0/UDP 35.161.XX.XX:5060;branch=z9hG4bK16be.085d2f3d83e8d939f7f1d3fbc4a5ff09.0 Via: SIP/2.0/WSS 74jssm3ooc66.invalid;received=209.160.251.114;branch=z9hG4bK3968143 To: <sip:9496294444@54.245.XX.XX>;tag=9vX27Um099jZS From: <sip:Dff742e5340fDd93847e@9e3f4e45-01cf-1f66-8d70-8d14ec555153>;tag=q1vfbk6o6q CSeq: 1 INVITE Call-ID: 995df181-4eae-40ae-8225-427ce8252250 Max-Forwards: 69 Allow: ACK,BYE,CANCEL,INFO,INVITE,MESSAGE,NOTIFY,OPTIONS,PRACK,REFER,REGISTER,SUBSCRIBE Contact: <sip:tu0r7r7u@74jssm3ooc66.invalid;transport=ws> Supported: outbound User-Agent: WebPhone/3.1740423483.87 Content-Type: application/sdp Content-Length: 1538 Route: <sip:34.213.XX.XX:5060;r2=on;lr;ftag=9vX27Um099jZS;did=a2b.1142>,<sip:34.213.XX.XX;r2=on;lr;ftag=9vX27Um099jZS;did=a2b.1142> P-SR-XUID: atpsh-7cde-67bcbccd-3c68ef-1 v=0 o=- 4757376688759011024 3 IN IP4 127.0.0.1 s=- t=0 0 a=group:BUNDLE 0 a=extmap-allow-mixed a=msid-semantic: WMS 35a33e17-dd80-46fa-afe9-72fdd03d4e41 m=audio 32999 UDP/TLS/RTP/SAVPF 0 102 101 103 63 9 8 13 c=IN IP4 209.160.251.114 a=rtcp:9 IN IP4 0.0.0.0 a=candidate:2845667355 1 udp 2122260223 10.82.226.218 54425 typ host generation 0 network-id 1 network-cost 10 a=candidate:1750280017 1 udp 1686052607 209.160.251.114 32999 typ srflx raddr 10.82.226.218 rport 54425 generation 0 network-id 1 network-cost 10 a=ice-ufrag:Eb9h a=ice-pwd:nQdfpsILiUI+YKSQT3eZy52x a=ice-options:trickle a=fingerprint:sha-256 BA:68:25:D5:66:70:A9:17:38:18:74:0A:B3:C2:3E:F9:3A:A0:7C:5F:18:0F:EB:B7:93:28:86:56:62:23:DF:E5 a=setup:actpass a=mid:0 a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level a=extmap:2 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time a=extmap:3 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01 a=extmap:4 urn:ietf:params:rtp-hdrext:sdes:mid a=sendonly a=msid:35a33e17-dd80-46fa-afe9-72fdd03d4e41 57910219-943b-4687-9511-b9a9d0a1ea6f a=rtcp-mux a=rtcp-rsize a=rtpmap:0 PCMU/8000 a=rtpmap:102 opus/48000/2 a=fmtp:102 minptime=10;useinbandfec=1 a=rtpmap:101 telephone-event/8000 a=rtpmap:103 telephone-event/48000 a=rtpmap:63 red/48000/2 a=fmtp:63 102/102 a=rtpmap:9 G722/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:13 CN/8000 a=ssrc:2604971680 cname:YEcJO5XrSKZor1jY a=ssrc:2604971680 msid:35a33e17-dd80-46fa-afe9-72fdd03d4e41 57910219-943b-4687-9511-b9a9d0a1ea6f ``` `200 OK Freeswitch -> A` ``` SIP/2.0 200 OK v:SIP/2.0/UDP 34.213.XX.XX:5060;branch=z9hG4bK16be.86ee5e1d4190783bd6a79bd21110d190.0 f:<sip:Dff742e5340fDd93847e@9e3f4e45-01cf-1f66-8d70-8d14ec555153>;tag=q1vfbk6o6q t:<sip:9496294444@54.245.XX.XX>;tag=9vX27Um099jZS i:995df181-4eae-40ae-8225-427ce8252250 CSeq:1 INVITE m:<sip:mod_sofia@54.245.XX.XX:5060> Accept:application/sdp Allow:INVITE,ACK,BYE,CANCEL,OPTIONS,MESSAGE,INFO,UPDATE,REGISTER,REFER,NOTIFY,PUBLISH,SUBSCRIBE k:timer,path,replaces x:90;refresher=uas c:application/sdp Content-Disposition:session l:284 v=0 o=FreeSWITCH 1740424963 1740424965 IN IP4 54.245.XX.XX s=FreeSWITCH c=IN IP4 54.245.XX.XX t=0 0 m=audio 17776 RTP/AVP 0 101 a=rtpmap:0 PCMU/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=recvonly a=ptime:20 a=rtcp-mux a=rtcp:17776 IN IP4 54.245.XX.XX ``` `200 OK A -> B` ``` SIP/2.0 200 OK f:<sip:Dff742e5340fDd93847e@9e3f4e45-01cf-1f66-8d70-8d14ec555153>;tag=q1vfbk6o6q t:<sip:9496294444@54.245.XX.XX>;tag=9vX27Um099jZS i:995df181-4eae-40ae-8225-427ce8252250 CSeq:1 INVITE m:<sip:mod_sofia@54.245.XX.XX:5060> Accept:application/sdp Allow:INVITE,ACK,BYE,CANCEL,OPTIONS,MESSAGE,INFO,UPDATE,REGISTER,REFER,NOTIFY,PUBLISH,SUBSCRIBE k:timer,path,replaces x:90;refresher=uas c:application/sdp Content-Disposition:session l:315 v=0 o=FreeSWITCH 1740424963 1740424965 IN IP4 34.211.XX.XX s=FreeSWITCH c=IN IP4 34.211.XX.XX t=0 0 m=audio 20374 RTP/AVP 0 101 a=mid:0 a=rtpmap:0 PCMU/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=recvonly a=rtcp:20374 a=rtcp-mux a=ptime:20 a=ice-options:trickle a=end-of-candidates ``` ### Possible Solutions TBD ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` <img width="629" alt="Image" src="https://github.com/user-attachments/assets/fc46f76e-7a6f-431f-a00e-84fbbece…" /> * **Operating System**: ``` No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye ``` I can provide PCAP as well if required. Let me know if additional information is required. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4157 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4157(a)github.com>

4 8

[kamailio/kamailio] tcp_timer_check_connections() logs on CRITICAL and is not caught by event_route[tcp:timeout] (Issue #3995)
by Fritjof Höst 20 Apr '25

20 Apr '25

### Description Hi! We are in the progress of upgrading from Kamailio 5.5 to 5.8. During our testing we have noticed a new error being reported from Kamailio. We don’t see any other errors following it. ```jsx /usr/sbin/kamailio[201]: CRITICAL: <core> [core/tcp_main.c:5544]: tcp_timer_check_connections(): message processing timeout on connection id: 67896 (state: 3) - closing ``` It does seem to be [new code](https://github.com/kamailio/kamailio/blob/master/src/core/tcp_main.c#… in Kamailio reporting this issue. Given that this is a fairly expected thing, cleaning up a connection which receives no traffic within the given time, is there a need for it to be reported on CRITICAL? I’d also expect it to be caught by ``` event_route[tcp:timeout] { xlog("L_INFO","connection $conid timeouts (unanswered keepalives)"); } ``` given that [the description](https://www.kamailio.org/docs/modules/stable/modules/tcpops.ht… of this one is `Called for connection timeouts (unanswered keepalives).`. ### Troubleshooting We don't have any way to reproduce it, we are still investigating it to figure out the cause. It happens around every 2 hours, so we think there might some some scheduled test or job running in our test system causing this. ### Additional Information * **Kamailio Version** - 5.8.3 * **Operating System**: Debian 12 AMI from the AWS Marketplace. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3995 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3995(a)github.com>

6 9

[kamailio/kamailio] fr_timer documentation mistake (Issue #3939)
by Dmitry Sinina 20 Apr '25

20 Apr '25

Documentation https://www.kamailio.org/docs/modules/devel/modules/tm.html#tm.p.fr_timer says: >Timer which hits if no **final reply** for a request or ACK for a negative INVITE reply arrives (in milliseconds). Looks like it is not correct description - fr_timer value works until 1xx(not **final**) response received and then timer restarted with fr_inv_timer value there: https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_reply.c#L… Looks like old doc from sip router https://sip-router.org/wiki/ref_manual/timers explains it correctly: > fr_timer This timer is used for all SIP requests. It hits if no reply for an INVITE request or other request has been received (F in milliseconds). If a provisional reply is received for an INVITE (any 1xx), then the fr_inv_timer will be used instead. And if no replies (at all) for an INVITE are received before `fr_timer` hits, the transaction is terminated with a 408 in failure route. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3939 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3939(a)github.com>

3 10

[kamailio/kamailio] cfgutils.unlock [apy_kemi.c:278]: sr_apy_kemi_exec_func_ex(): invalid number of parameters - idx: 1 argc: 1 (Issue #4216)
by space88man 19 Apr '25

19 Apr '25

space88man created an issue (kamailio/kamailio#4216) ### Description Use cfgengine python and KSR.cfgutils.unlock ### Troubleshooting #### Reproduction In cfgengine python call ``` KSR.cfgutils.lock("something") # do some work KSR.cfgutils.unlock("something") ``` #### Debugging Data n/a #### Log Messages ```ERROR: app_python3 [apy_kemi.c:278]: sr_apy_kemi_exec_func_ex(): invalid number of parameters - idx: 1 argc: 1 ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 17:27:30 Mar 29 2025 with gcc 8.5.0 ``` * **Operating System**: ``` AlmaLinux 9.5 x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4216 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4216(a)github.com>

2 2

git:master:204839ec: cfgutils: kemi export try/un/lock_key2() functions
by Daniel-Constantin Mierla 19 Apr '25

19 Apr '25

Module: kamailio Branch: master Commit: 204839ec9aeb0f31425732dd0a2e8e256481dae5 URL: https://github.com/kamailio/kamailio/commit/204839ec9aeb0f31425732dd0a2e8e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-19T09:25:19+02:00 cfgutils: kemi export try/un/lock_key2() functions - different kemi functions cannot be exported with same name, even if they have different number of parameters - GH #4216 --- Modified: src/modules/cfgutils/cfgutils.c --- Diff: https://github.com/kamailio/kamailio/commit/204839ec9aeb0f31425732dd0a2e8e2… Patch: https://github.com/kamailio/kamailio/commit/204839ec9aeb0f31425732dd0a2e8e2… --- diff --git a/src/modules/cfgutils/cfgutils.c b/src/modules/cfgutils/cfgutils.c index fd0a5e5b2b3..2d3809e670c 100644 --- a/src/modules/cfgutils/cfgutils.c +++ b/src/modules/cfgutils/cfgutils.c @@ -1050,7 +1050,7 @@ static sr_kemi_t sr_kemi_cfgutils_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, - { str_init("cfgutils"), str_init("lock"), + { str_init("cfgutils"), str_init("lock_key2"), SR_KEMIP_INT, cfg_lock_key2, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } @@ -1060,7 +1060,7 @@ static sr_kemi_t sr_kemi_cfgutils_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, - { str_init("cfgutils"), str_init("unlock"), + { str_init("cfgutils"), str_init("unlock_key2"), SR_KEMIP_INT, cfg_unlock_key2, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } @@ -1070,7 +1070,7 @@ static sr_kemi_t sr_kemi_cfgutils_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, - { str_init("cfgutils"), str_init("trylock"), + { str_init("cfgutils"), str_init("trylock_key2"), SR_KEMIP_INT, cfg_trylock_key2, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }

1 0

git:master:cb915a51: core: use ULL constant to induce value size
by Daniel-Constantin Mierla 19 Apr '25

19 Apr '25

Module: kamailio Branch: master Commit: cb915a518106c49c2d71308396feee9ba5149e39 URL: https://github.com/kamailio/kamailio/commit/cb915a518106c49c2d71308396feee9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-19T09:21:19+02:00 core: use ULL constant to induce value size --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/cb915a518106c49c2d71308396feee9… Patch: https://github.com/kamailio/kamailio/commit/cb915a518106c49c2d71308396feee9… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index 09749bcee11..7cbe6153824 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1030,7 +1030,7 @@ int check_freq_interval(tmrec_t *_trp, ac_tm_t *_atp) ? REC_MATCH : REC_NOMATCH; case FREQ_MONTHLY: - _t0 = (_atp->t.tm_year - _trp->ts.tm_year) * 12 + _atp->t.tm_mon + _t0 = 12ULL * (_atp->t.tm_year - _trp->ts.tm_year) + _atp->t.tm_mon - _trp->ts.tm_mon; return (_t0 % _trp->interval == 0) ? REC_MATCH : REC_NOMATCH; case FREQ_YEARLY:

1 0

[kamailio/kamailio] path: add_path_received() appends transport=ws instead of transport=wss (Issue #4168)
by Christian Berger 19 Apr '25

19 Apr '25

ChristianBergerSipgate created an issue (kamailio/kamailio#4168) We think we have found a potential bug in the path module. When we call `add_path_received()` we get the following for WSS connections: `Path: <sip:217.10.77.242;lr;received=sip:217.10.69.93:42612%3Btransport%3Dws>` We think there should be a `transport%3Dwss` appended instead of ws. We have looked a bit into the code and think that this is caused by the following definition: ``` in modules/path/path.c const static char *proto_strings[] = { [PROTO_TCP] = "%3Btransport%3Dtcp", [PROTO_TLS] = "%3Btransport%3Dtls", [PROTO_SCTP] = "%3Btransport%3Dsctp", [PROTO_WS] = "%3Btransport%3Dws", [PROTO_WSS] = "%3Btransport%3Dws", }; ``` We think that on the last line, it should read ` [PROTO_WSS] = "%3Btransport%3Dwss",` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4168 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4168(a)github.com>

5 5

git:master:e9c519ad: textops: simplify return code when removing via param
by Daniel-Constantin Mierla 18 Apr '25

18 Apr '25

Module: kamailio Branch: master Commit: e9c519ad4d49b8c74069577edb84ce02a5e63ee0 URL: https://github.com/kamailio/kamailio/commit/e9c519ad4d49b8c74069577edb84ce0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-18T10:21:00+02:00 textops: simplify return code when removing via param --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/e9c519ad4d49b8c74069577edb84ce0… Patch: https://github.com/kamailio/kamailio/commit/e9c519ad4d49b8c74069577edb84ce0… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index db1929e0127..aee46a301a6 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -5037,7 +5037,7 @@ static int ki_via_param_rm(sip_msg_t *msg, str *name, int idx) } } } - return (ret == 0) ? -1 : ret; + return -1; } /**

1 0

git:master:2b331d95: microhttpd: warning on failing to add content-type
by Daniel-Constantin Mierla 18 Apr '25

18 Apr '25

Module: kamailio Branch: master Commit: 2b331d95ae62eb0000a289e1bdb668ee7bc572cb URL: https://github.com/kamailio/kamailio/commit/2b331d95ae62eb0000a289e1bdb668e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-18T10:21:00+02:00 microhttpd: warning on failing to add content-type --- Modified: src/modules/microhttpd/microhttpd_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2b331d95ae62eb0000a289e1bdb668e… Patch: https://github.com/kamailio/kamailio/commit/2b331d95ae62eb0000a289e1bdb668e… --- diff --git a/src/modules/microhttpd/microhttpd_mod.c b/src/modules/microhttpd/microhttpd_mod.c index 7bd8d304644..ff486ac7dd6 100644 --- a/src/modules/microhttpd/microhttpd_mod.c +++ b/src/modules/microhttpd/microhttpd_mod.c @@ -373,7 +373,10 @@ static int ksr_mhttpd_send_reply( return -1; } if(sctype->len > 0) { - MHD_add_response_header(response, "Content-Type", sctype->s); + if(MHD_add_response_header(response, "Content-Type", sctype->s) + == MHD_NO) { + LM_WARN("failed to add Content-Type header\n"); + } } ret = MHD_queue_response( _ksr_mhttpd_ctx.connection, (unsigned int)rcode, response);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev