sr-dev

sr-dev@lists.kamailio.org

16 participants
45378 discussions

git:6.0:830a9f34: lrkproxy: improve randomness of cookie by using PNRG and random sequence numbers
by Xenofon Karamanos 26 Jun '25

26 Jun '25

Module: kamailio Branch: 6.0 Commit: 830a9f349f0356bc695b8744b4c96218e690d9e8 URL: https://github.com/kamailio/kamailio/commit/830a9f349f0356bc695b8744b4c9621… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-26T10:53:14Z lrkproxy: improve randomness of cookie by using PNRG and random sequence numbers (cherry picked from commit 4935196ee8ce1d99e77c614aaa0131a1972580ed) --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/830a9f349f0356bc695b8744b4c9621… Patch: https://github.com/kamailio/kamailio/commit/830a9f349f0356bc695b8744b4c9621… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index bc0a83f4e23..ef6a347105b 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -77,6 +77,7 @@ #include "../../core/dset.h" #include "../../core/route.h" #include "../../core/kemi.h" +#include "../../core/rand/fastrand.h" #include "../../modules/tm/tm_load.h" #include "lrkproxy.h" #include "lrkproxy_hash.h" @@ -158,7 +159,6 @@ static void mod_destroy(void); static int lrkproxy_disable_tout = 60; static int lrkproxy_retr = 5; static int lrkproxy_tout = 1; -static pid_t mypid; static unsigned int myseqn = 0; //static str nolrkproxy_str = str_init("a=nolrkproxy:yes"); //static str extra_id_pv_param = {NULL, 0}; @@ -668,9 +668,10 @@ static int child_init(int rank) return 0; } - /* Iterate known LRK proxies - create sockets */ - mypid = getpid(); + /* random start value for for cookie sequence number */ + myseqn = fastrand(); + /* Iterate known RTP proxies - create sockets */ lrkp_socks = (int *)pkg_malloc(sizeof(int) * lrkp_no); if(lrkp_socks == NULL) { LM_ERR("no more pkg memory\n"); @@ -791,7 +792,7 @@ static char *gencookie(void) { static char cook[34]; - sprintf(cook, "%d_%u ", (int)mypid, myseqn); + sprintf(cook, "%d_%u ", fastrand(), myseqn); myseqn++; return cook; }

1 0

git:6.0:898bfc89: rtpproxy: improve randomness of cookie by using PNRG and random sequence numbers
by Xenofon Karamanos 26 Jun '25

26 Jun '25

Module: kamailio Branch: 6.0 Commit: 898bfc89fde04bb5f3d0fda059c58b0c9378d15a URL: https://github.com/kamailio/kamailio/commit/898bfc89fde04bb5f3d0fda059c58b0… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-26T10:53:09Z rtpproxy: improve randomness of cookie by using PNRG and random sequence numbers (cherry picked from commit 04686c40d380e16e55c359cbc6bfc28f644a4c0b) --- Modified: src/modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/898bfc89fde04bb5f3d0fda059c58b0… Patch: https://github.com/kamailio/kamailio/commit/898bfc89fde04bb5f3d0fda059c58b0… --- diff --git a/src/modules/rtpproxy/rtpproxy.c b/src/modules/rtpproxy/rtpproxy.c index 2057cdfba5d..02641ce2ce3 100644 --- a/src/modules/rtpproxy/rtpproxy.c +++ b/src/modules/rtpproxy/rtpproxy.c @@ -76,6 +76,7 @@ #include "../../core/dset.h" #include "../../core/route.h" #include "../../core/kemi.h" +#include "../../core/rand/fastrand.h" #include "../../modules/tm/tm_load.h" #include "rtpproxy.h" #include "rtpproxy_funcs.h" @@ -153,7 +154,6 @@ static int pv_get_rtppstat_f(struct sip_msg *, pv_param_t *, pv_value_t *); static int rtpproxy_disable_tout = 60; static int rtpproxy_retr = 5; static int rtpproxy_tout = 1; -static pid_t mypid; static unsigned int myseqn = 0; static str nortpproxy_str = str_init("a=nortpproxy:yes"); static str extra_id_pv_param = {NULL, 0}; @@ -788,9 +788,10 @@ static int child_init(int rank) return 0; } - /* Iterate known RTP proxies - create sockets */ - mypid = getpid(); + /* random start value for for cookie sequence number */ + myseqn = fastrand(); + /* Iterate known RTP proxies - create sockets */ rtpp_socks = (int *)pkg_malloc(sizeof(int) * rtpp_no); if(rtpp_socks == NULL) { LM_ERR("no more pkg memory\n"); @@ -1206,7 +1207,7 @@ static char *gencookie(void) { static char cook[34]; - sprintf(cook, "%d_%u ", (int)mypid, myseqn); + sprintf(cook, "%u_%u ", fastrand(), myseqn); myseqn++; return cook; }

1 0

git:6.0:46702d80: rtpengine: improve randomness of cookie by using PNRG and random sequence numbers
by Xenofon Karamanos 26 Jun '25

26 Jun '25

Module: kamailio Branch: 6.0 Commit: 46702d80d76f6b70b63d2fca4e884def18b20385 URL: https://github.com/kamailio/kamailio/commit/46702d80d76f6b70b63d2fca4e884de… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-26T10:53:00Z rtpengine: improve randomness of cookie by using PNRG and random sequence numbers (cherry picked from commit 33b80fcc4d84f955b29bd65bccee9ef2a62e7000) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/46702d80d76f6b70b63d2fca4e884de… Patch: https://github.com/kamailio/kamailio/commit/46702d80d76f6b70b63d2fca4e884de… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 36f93dd35aa..7b66161c834 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -83,6 +83,7 @@ #include "../../core/char_msg_val.h" #include "../../core/utils/srjson.h" #include "../../core/cfg/cfg_struct.h" +#include "../../core/rand/fastrand.h" #include "../../modules/tm/tm_load.h" #include "../../modules/crypto/api.h" #include "../../modules/lwsc/api.h" @@ -307,7 +308,7 @@ static void parse_call_stats(bencode_item_t *, struct sip_msg *); static int control_cmd_tos = -1; static int rtpengine_allow_op = 0; static struct rtpp_node **queried_nodes_ptr = NULL; -static pid_t mypid; + static unsigned int myseqn = 0; static str extra_id_pv_param = {NULL, 0}; static char *setid_avp_param = NULL; @@ -2701,6 +2702,8 @@ static int mos_label_stats_parse(struct minmax_mos_label_stats *mmls) static int child_init(int rank) { + pid_t mypid = 0; + if(!rtpp_set_list) return 0; @@ -2711,7 +2714,7 @@ static int child_init(int rank) if(rank == PROC_MAIN) { if(rtpengine_dtmf_event_sock.len > 0) { - LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid); + LM_DBG("Register RTPENGINE DTMF WORKER %d\n", getpid()); /* fork worker process */ mypid = fork_process(PROC_RPC, "RTPENGINE DTMF WORKER", 1); if(mypid < 0) { @@ -2733,7 +2736,9 @@ static int child_init(int rank) return 0; } - mypid = getpid(); + /* random start value for for cookie sequence number */ + myseqn = fastrand(); + LM_ERR("myseqn %u\n", myseqn); // vector of pointers to queried nodes queried_nodes_ptr = (struct rtpp_node **)pkg_malloc( @@ -2844,7 +2849,7 @@ static char *gencookie(void) { static char cook[34]; - snprintf(cook, 34, "%d_%d_%u ", server_id, (int)mypid, myseqn); + snprintf(cook, 34, "%d_%u_%u ", server_id, fastrand(), myseqn); myseqn++; return cook; }

1 0

git:master:bd8f7b4e: rtpengine: Remove unnessecary log
by Xenofon Karamanos 26 Jun '25

26 Jun '25

Module: kamailio Branch: master Commit: bd8f7b4e749f2b4d5525d5864c36252823926351 URL: https://github.com/kamailio/kamailio/commit/bd8f7b4e749f2b4d5525d5864c36252… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-06-26T10:46:44Z rtpengine: Remove unnessecary log --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/bd8f7b4e749f2b4d5525d5864c36252… Patch: https://github.com/kamailio/kamailio/commit/bd8f7b4e749f2b4d5525d5864c36252… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index e7d6cf9d5b9..59ab17e6062 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3065,7 +3065,6 @@ static int child_init(int rank) /* random start value for for cookie sequence number */ myseqn = fastrand(); - LM_ERR("myseqn %u\n", myseqn); // vector of pointers to queried nodes queried_nodes_ptr = (struct rtpp_node **)pkg_malloc(

1 0

[kamailio/kamailio] Invalid $nghttp2(...) (Issue #4299)
by QWERTY 26 Jun '25

26 Jun '25

2954456878 created an issue (kamailio/kamailio#4299) version: kamailio 6.0.1 (x86_64/linux) loadmodule "nghttp2.so" modparam("nghttp2", "listen_addr", "0.0.0.0") modparam("nghttp2", "listen_port", "8363") event_route[nghttp2:request] { xinfo("request: $nghttp2(method) - url: $nghttp2(url) - data: [$nghttp2(data)]\n"); nghttp2_reply("200", "<html><body>OK</body></html>"); } Startup error： Jun 25 10:42:50 debiancrs /usr/local/kamailio6-devel/sbin/kamailio[41907]: ERROR: nghttp2 [nghttp2_mod.c:246]: pv_parse_nghttp2_name(): invalid variable name [url] Jun 25 10:42:50 debiancrs /usr/local/kamailio6-devel/sbin/kamailio[41907]: ERROR: <core> [core/pvapi.c:954]: pv_parse_spec2(): pvar "nghttp2" has an invalid name param [url] Jun 25 10:42:50 debiancrs /usr/local/kamailio6-devel/sbin/kamailio[41907]: ERROR: <core> [core/pvapi.c:1092]: pv_parse_spec2(): wrong char [)/41] in [$nghttp2(url)] at [12 (5)] Jun 25 10:42:50 debiancrs /usr/local/kamailio6-devel/sbin/kamailio[41907]: ERROR: xlog [xlog.c:550]: xdbg_fixup_helper(): wrong format[request: $nghttp2(method) - url: $nghttp2(url) - data: [$nghttp2(data)]#012] -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4299 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4299(a)github.com>

2 2

git:master:64bc28f1: modules: readme files regenerated - nghttp2 ... [skip ci]
by Kamailio Dev 26 Jun '25

26 Jun '25

Module: kamailio Branch: master Commit: 64bc28f1279809829b714d23314b3e62030a8ccb URL: https://github.com/kamailio/kamailio/commit/64bc28f1279809829b714d23314b3e6… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-26T09:31:10+02:00 modules: readme files regenerated - nghttp2 ... [skip ci] --- Modified: src/modules/nghttp2/README --- Diff: https://github.com/kamailio/kamailio/commit/64bc28f1279809829b714d23314b3e6… Patch: https://github.com/kamailio/kamailio/commit/64bc28f1279809829b714d23314b3e6… --- diff --git a/src/modules/nghttp2/README b/src/modules/nghttp2/README index f880b2e5a13..fc79a0fbae3 100644 --- a/src/modules/nghttp2/README +++ b/src/modules/nghttp2/README @@ -184,15 +184,15 @@ event_route[nghttp2:request] { The event route is executed when a new HTTP request is received. Inside it, the $nghttp2(...) group of variables is available, giving - access to several attributes of the HTTP request, such as method, URL, - data (body) or headers. + access to several attributes of the HTTP request, such as method, URL + path, data (body) or headers. ... ... loadmodule "nghttp2.so ... event_route[nghttp2:request] { - xinfo("request: $nghttp2(method) - url: $nghttp2(url) - data: [$nghttp2(data -)]\n"); + xinfo("request: $nghttp2(method) - url: $nghttp2(path) - data: [$nghttp2(dat +a)]\n"); nghttp2_reply("200", "OK", "text/html", "<html><body>OK</body></html>"); }

1 0

git:master:b513666f: nghttp2: docs updated to use the proper $nghttp2(path) variable
by Daniel-Constantin Mierla 26 Jun '25

26 Jun '25

Module: kamailio Branch: master Commit: b513666f76d2220d8914fadcc4968845efbf170f URL: https://github.com/kamailio/kamailio/commit/b513666f76d2220d8914fadcc496884… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-26T09:05:10+02:00 nghttp2: docs updated to use the proper $nghttp2(path) variable --- Modified: src/modules/nghttp2/doc/nghttp2_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b513666f76d2220d8914fadcc496884… Patch: https://github.com/kamailio/kamailio/commit/b513666f76d2220d8914fadcc496884… --- diff --git a/src/modules/nghttp2/doc/nghttp2_admin.xml b/src/modules/nghttp2/doc/nghttp2_admin.xml index 54cde446de6..a09bb5d0b33 100644 --- a/src/modules/nghttp2/doc/nghttp2_admin.xml +++ b/src/modules/nghttp2/doc/nghttp2_admin.xml @@ -182,7 +182,7 @@ event_route[nghttp2:request] { <para> Inside it, the $nghttp2(...) group of variables is available, giving access to several attributes of the HTTP request, such as method, - URL, data (body) or headers. + URL path, data (body) or headers. </para> <programlisting format="linespecific"> ... @@ -190,7 +190,7 @@ event_route[nghttp2:request] { loadmodule "nghttp2.so ... event_route[nghttp2:request] { - xinfo("request: $nghttp2(method) - url: $nghttp2(url) - data: [$nghttp2(data)]\n"); + xinfo("request: $nghttp2(method) - url: $nghttp2(path) - data: [$nghttp2(data)]\n"); nghttp2_reply("200", "OK", "text/html", "<html><body>OK</body></html>"); }

1 0

git:master:092ad634: core: print ip and port in log message
by Daniel-Constantin Mierla 25 Jun '25

25 Jun '25

Module: kamailio Branch: master Commit: 092ad634a2741ad21fd29586a30bd2bcb9ac653b URL: https://github.com/kamailio/kamailio/commit/092ad634a2741ad21fd29586a30bd2b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-25T20:34:23+02:00 core: print ip and port in log message --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/092ad634a2741ad21fd29586a30bd2b… Patch: https://github.com/kamailio/kamailio/commit/092ad634a2741ad21fd29586a30bd2b… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index 3a46f7106f5..e27b70deec1 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -2918,7 +2918,7 @@ char *via_builder(unsigned int *len, sip_msg_t *msg, #endif /* USE_COMP */ int port; int proto; - struct ip_addr ip; + struct ip_addr ip = {0}; union sockaddr_union *from = NULL; union sockaddr_union local_addr; struct tcp_connection *con = NULL; @@ -3064,8 +3064,8 @@ char *via_builder(unsigned int *len, sip_msg_t *msg, if(con == NULL) { LM_WARN("TCP/TLS connection (id: %d) for WebSocket could not be " - "found\n", - send_info->id); + "found - likely it is gone (dst: [%s]:%d)\n", + send_info->id, (port) ? ip_addr2a(&ip) : "", port); pkg_free(line_buf); return 0; }

1 0

[kamailio/kamailio] Release 6.0.2 - 6.0.2
by github-actions[bot] 25 Jun '25

25 Jun '25

-- View it on GitHub: https://github.com/kamailio/kamailio/releases/tag/6.0.2 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/releases/227792045(a)github.com>

1 0

git:master:3e3cfc6b: github: alpine docker image, removed cleanup
by Sergey Safarov 25 Jun '25

25 Jun '25

Module: kamailio Branch: master Commit: 3e3cfc6b113b3e9a7f1a3ac91897687fbb71f29a URL: https://github.com/kamailio/kamailio/commit/3e3cfc6b113b3e9a7f1a3ac91897687… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-25T18:46:07+03:00 github: alpine docker image, removed cleanup --- Modified: .github/workflows/alpine.yml --- Diff: https://github.com/kamailio/kamailio/commit/3e3cfc6b113b3e9a7f1a3ac91897687… Patch: https://github.com/kamailio/kamailio/commit/3e3cfc6b113b3e9a7f1a3ac91897687… --- diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index e5f7885e898..82fc4082199 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -426,18 +426,3 @@ jobs: context: "context" build-args: | IMAGE=${{ needs.check.outputs.alpine_tag }} - - cleanup: - name: Cleanup untaged images - runs-on: ubuntu-latest - continue-on-error: true - permissions: - packages: write - needs: - - images - steps: - - name: Cleanup untaged - uses: dataaxiom/ghcr-cleanup-action@v1 - with: - owner: ${{ github.repository_owner }} - package: ${{ env.IMAGE_NAME }}

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev