sr-dev

sr-dev@lists.kamailio.org

15 participants
44254 discussions

git:sr_3.0: domain: Do not report errors when domain cannot be extracted from URI.

by Jan Janak

Module: sip-router Branch: sr_3.0 Commit: 6186194a7e6153871d9da019e64916f6f73ec922 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6186194… Author: Jan Janak <jan(a)ryngle.com> Committer: Jan Janak <jan(a)ryngle.com> Date: Mon Oct 26 14:37:22 2009 +0100 domain: Do not report errors when domain cannot be extracted from URI. We should not report an error to syslog when lookup_domain fails to parse the URI it was given as argument. That URI usually comes from SIP messages we received from another implementation and we cannot guarantee that they will always be well-formed. Generating an error each time we receive a malformed SIP message can easily result in denial of service. --- modules_s/domain/domain_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_s/domain/domain_mod.c b/modules_s/domain/domain_mod.c index e5d5cb0..b175ff8 100644 --- a/modules_s/domain/domain_mod.c +++ b/modules_s/domain/domain_mod.c @@ -440,7 +440,7 @@ static int lookup_domain(struct sip_msg* msg, char* flags, char* fp) track = 0; if (get_str_fparam(&domain, msg, (fparam_t*)fp) != 0) { - ERR("Cannot get domain name to lookup\n"); + DBG("lookup_domain: Cannot get the domain name to lookup\n"); return -1; }

15 years, 2 months

git:master: domain: Do not report errors when domain cannot be extracted from URI.

by Jan Janak

Module: sip-router Branch: master Commit: 6907fb8dc86953dfae0e2924a2c5a24feff3ecad URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6907fb8… Author: Jan Janak <jan(a)ryngle.com> Committer: Jan Janak <jan(a)ryngle.com> Date: Mon Oct 26 14:37:22 2009 +0100 domain: Do not report errors when domain cannot be extracted from URI. We should not report an error to syslog when lookup_domain fails to parse the URI it was given as argument. That URI usually comes from SIP messages we received from another implementation and we cannot guarantee that they will always be well-formed. Generating an error each time we receive a malformed SIP message can easily result in denial of service. --- modules_s/domain/domain_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_s/domain/domain_mod.c b/modules_s/domain/domain_mod.c index e5d5cb0..b175ff8 100644 --- a/modules_s/domain/domain_mod.c +++ b/modules_s/domain/domain_mod.c @@ -440,7 +440,7 @@ static int lookup_domain(struct sip_msg* msg, char* flags, char* fp) track = 0; if (get_str_fparam(&domain, msg, (fparam_t*)fp) != 0) { - ERR("Cannot get domain name to lookup\n"); + DBG("lookup_domain: Cannot get the domain name to lookup\n"); return -1; }

15 years, 2 months

git:master: parse_sip_msg_uri: Log broken URIs only when debugging is enabled.

by Jan Janak

Module: sip-router Branch: master Commit: 47e9d6d83617e79c774c8815ec88610dc24e3dc4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=47e9d6d… Author: Jan Janak <jan(a)ryngle.com> Committer: Jan Janak <jan(a)ryngle.com> Date: Mon Oct 26 14:15:53 2009 +0100 parse_sip_msg_uri: Log broken URIs only when debugging is enabled. Logging broken Request-URIs with LOG(L_ERR) generates too much traffic in syslog by default. Broken Request-URIs are beyond our control and we should not generate an error message each time we receive and parse one. We log them only when debugging is enabled. --- parser/parse_uri.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/parser/parse_uri.c b/parser/parse_uri.c index 60f28c5..b9d487e 100644 --- a/parser/parse_uri.c +++ b/parser/parse_uri.c @@ -1403,8 +1403,8 @@ int parse_sip_msg_uri(struct sip_msg* msg) tmp_len=msg->first_line.u.request.uri.len; } if (parse_uri(tmp, tmp_len, &msg->parsed_uri)<0){ - LOG(L_ERR, "ERROR: parse_sip_msg_uri: bad uri <%.*s>\n", - tmp_len, tmp); + DBG("ERROR: parse_sip_msg_uri: bad uri <%.*s>\n", + tmp_len, tmp); msg->parsed_uri_ok=0; return -1; }

15 years, 2 months

git:master: Fixed 42.sh

by Marius Zbihlei

Module: sip-router Branch: master Commit: 8817fb1cf468b0490565c32b2dfa5230546a933f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8817fb1… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Oct 26 15:07:30 2009 +0200 Fixed 42.sh --- test/unit/42.sh | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/unit/42.sh b/test/unit/42.sh index e1561da..8a30d2f 100755 --- a/test/unit/42.sh +++ b/test/unit/42.sh @@ -82,28 +82,28 @@ ret=$? sleep 1 if [ "$ret" -eq 0 ] ; then - sipp -sn uas -bg -i localhost -m 12 -p 7000 &> /dev/null - sipp -sn uas -bg -i localhost -m 12 -p 8000 &> /dev/null + sipp -sn uas -bg -i 127.0.0.1 -m 12 -p 7000 &> /dev/null + sipp -sn uas -bg -i 127.0.0.1 -m 12 -p 8000 &> /dev/null sipp -sn uac -s ab4-123456787 127.0.0.1:5060 -i 127.0.0.1 -m 20 -p 5061 &> /dev/null ret=$? killall sipp &> /dev/null fi; if [ "$ret" -eq 0 ] ; then - sipp -sn uas -bg -i localhost -m 10 -p 9000 &> /dev/null + sipp -sn uas -bg -i 127.0.0.1 -m 10 -p 9000 &> /dev/null sipp -sn uac -s ab4-123456786 127.0.0.1:5060 -i 127.0.0.1 -m 10 -p 5061 &> /dev/null ret=$? fi; if [ "$ret" -eq 0 ] ; then - sipp -sn uas -bg -i localhost -m 10 -p 10000 &> /dev/null + sipp -sn uas -bg -i 127.0.0.1 -m 10 -p 10000 &> /dev/null sipp -sn uac -s ab4-123456785 127.0.0.1:5060 -i 127.0.0.1 -m 10 -p 5061 &> /dev/null ret=$? fi; if [ "$ret" -eq 0 ] ; then killall sipp &> /dev/null - sipp -sf failure_route.xml -bg -i localhost -m 10 -p 10000 &> /dev/null + sipp -sf failure_route.xml -bg -i 127.0.0.1 -m 10 -p 10000 &> /dev/null sipp -sn uac -s ab4-123456785 127.0.0.1:5060 -i 127.0.0.1 -m 10 -p 5061 &> /dev/null ret=$? fi; @@ -116,7 +116,7 @@ flags, mask, next_domain) values ('5', '3', '1', 'ab4-', '127.0.0.1:10000', '486 if [ ! "$ret" -eq 0 ] ; then $CTL fifo cr_reload_routes killall sipp &> /dev/null - sipp -sf failure_route.xml -bg -i localhost -m 10 -p 10000 &> /dev/null + sipp -sf failure_route.xml -bg -i 127.0.0.1 -m 10 -p 10000 &> /dev/null sipp -sn uac -s ab4-123456785 127.0.0.1:5060 -i 127.0.0.1 -m 10 -p 5061 &> /dev/null ret=$? fi;

15 years, 2 months

git:master: Fixed 41.sh test

by Marius Zbihlei

Module: sip-router Branch: master Commit: f9dbcbba75e742d9fafa1b10b477144c4aefd731 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f9dbcbb… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Oct 26 14:25:29 2009 +0200 Fixed 41.sh test --- test/unit/41.cfg | 10 +++++----- test/unit/41.sh | 14 ++++++++------ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/test/unit/41.cfg b/test/unit/41.cfg index 335b670..0ca4422 100644 --- a/test/unit/41.cfg +++ b/test/unit/41.cfg @@ -1,15 +1,15 @@ -memlog=1 +#memlog=1 debug=1 children=1 -mpath="../modules" +mpath="../../modules_k" +loadmodule "../../modules/tm/tm.so" loadmodule "sl/sl.so" -loadmodule "tm/tm.so" -loadmodule "db_mysql/db_mysql.so" +loadmodule "../../modules/db_mysql/db_mysql.so" loadmodule "usrloc/usrloc.so" loadmodule "registrar/registrar.so" loadmodule "pv/pv.so" -loadmodule "avpops/avpops.so" +loadmodule "../../modules/avpops/avpops.so" loadmodule "mi_fifo/mi_fifo.so" loadmodule "xlog/xlog.so" diff --git a/test/unit/41.sh b/test/unit/41.sh index 87cffb7..7e2be14 100755 --- a/test/unit/41.sh +++ b/test/unit/41.sh @@ -38,17 +38,18 @@ if ! (check_sipp && check_kamailio && check_module "db_mysql" && check_mysql); t fi ; # add an registrar entry to the db; -$MYSQL "INSERT INTO location (username,contact,socket,user_agent,cseq,q) VALUES (\"foo\",\"sip:foo@localhost:$UAS\",\"udp:127.0.0.1:$UAS\",\"ser_test\",1,-1);" +$MYSQL "INSERT INTO location (username,contact,socket,user_agent,cseq,q) VALUES (\"foo\",\"sip:foo@127.0.0.1:$UAS\",\"udp:127.0.0.1:$UAS\",\"ser_test\",1,-1);" $MYSQL "INSERT INTO usr_preferences (uuid, attribute, type, value) VALUES (\"foobar\", \"679\", 0, \"foobar!!!!!\");" # start -../$BIN -w . -f $CFG &> /dev/null + +$BIN -w . -f $CFG &> /dev/null ret=$? if [ "$ret" -eq 0 ]; then - sipp -sn uas -bg -i localhost -m $NR -r $RT -p $UAS &> /dev/null - sipp -sn uac -s foo 127.0.0.1:$SRV -r $RT -i localhost -m $NR -p $UAC &> /dev/null + sipp -sn uas -bg -i 127.0.0.1 -m $NR -r $RT -p $UAS &> /dev/null + sipp -sn uac -s foo 127.0.0.1:$SRV -r $RT -i 127.0.0.1 -m $NR -p $UAC &> /dev/null ret=$? fi; @@ -56,6 +57,7 @@ sleep 1 $KILL killall -9 sipp > /dev/null 2>&1 -$MYSQL "DELETE FROM location WHERE ((contact = \"sip:foo@localhost:$UAS\") and (user_agent = \"ser_test\"));" +$MYSQL "DELETE FROM location WHERE ((contact = \"sip:foo@127.0.0.1:$UAS\") and (user_agent = \"ser_test\"));" $MYSQL "DELETE FROM usr_preferences;" -exit $ret \ No newline at end of file +exit $ret +

15 years, 2 months

git:master: Removed unused var (added last commit)

by Marius Zbihlei

Module: sip-router Branch: master Commit: 60548b6b3475d82e5d4d8c9a4be53c8dfb32df5e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=60548b6… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Oct 26 14:23:25 2009 +0200 Removed unused var (added last commit) --- modules/avpops/avpops_impl.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/modules/avpops/avpops_impl.c b/modules/avpops/avpops_impl.c index ab0ec91..3817cd8 100644 --- a/modules/avpops/avpops_impl.c +++ b/modules/avpops/avpops_impl.c @@ -660,7 +660,6 @@ int ops_dbstore_avps (struct sip_msg* msg, struct fis_param *sp, n =0 ; memset(&st, 0, sizeof(struct search_state)); - int counter = 1; if ((dbp->a.opd&AVPOPS_VAL_NONE)==0) { /* avp name is known ->set it and its type */

15 years, 2 months

git:master: Fixed avpops avp_db_store as before no state was used and it caused to loop endessly .

by Marius Zbihlei

Module: sip-router Branch: master Commit: ffca34a67b64079cf66a0d4c0cd5419fff3f2255 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ffca34a… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Oct 26 13:37:43 2009 +0200 Fixed avpops avp_db_store as before no state was used and it caused to loop endessly. --- modules/avpops/avpops_impl.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/avpops/avpops_impl.c b/modules/avpops/avpops_impl.c index c6fa543..ab0ec91 100644 --- a/modules/avpops/avpops_impl.c +++ b/modules/avpops/avpops_impl.c @@ -659,13 +659,14 @@ int ops_dbstore_avps (struct sip_msg* msg, struct fis_param *sp, /* set uuid/(username and domain) fields */ n =0 ; - + memset(&st, 0, sizeof(struct search_state)); + int counter = 1; if ((dbp->a.opd&AVPOPS_VAL_NONE)==0) { /* avp name is known ->set it and its type */ store_vals[1].val.str_val = dbp->sa; /*attr name*/ - avp = search_first_avp( name_type, avp_name, &i_s, 0); - for( ; avp; avp=search_first_avp( name_type, avp_name, &i_s, &st)) + avp = search_first_avp( name_type, avp_name, &i_s, &st); + for( ; avp; avp=search_next_avp( &st, &i_s)) { /* don't insert avps which were loaded */ if (avp->flags&AVP_IS_IN_DB)

15 years, 2 months

git:master: Last doxygen updates of today.

by Olle E. Johansson

Module: sip-router Branch: master Commit: 084221763b27e7fab9fa2b860651972a97056467 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0842217… Author: oej <oej(a)edvina.net> Committer: oej <oej(a)edvina.net> Date: Sun Oct 25 21:30:00 2009 +0100 Last doxygen updates of today. --- modules_k/presence/bind_presence.c | 5 ++++- modules_k/presence/bind_presence.h | 6 +++--- modules_k/presence/doc/presence_admin.xml | 24 ++++++++++++------------ 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/modules_k/presence/bind_presence.c b/modules_k/presence/bind_presence.c index c2093cb..154c220 100644 --- a/modules_k/presence/bind_presence.c +++ b/modules_k/presence/bind_presence.c @@ -27,7 +27,10 @@ */ /*! \file - * \brief Kamailio presence module + * \brief SIP-Router Presence :: Kamailio generic presence module + * + * This is the core presence module, used in combination with other modules. + * * \ingroup presence */ diff --git a/modules_k/presence/bind_presence.h b/modules_k/presence/bind_presence.h index 44858e2..5800315 100644 --- a/modules_k/presence/bind_presence.h +++ b/modules_k/presence/bind_presence.h @@ -25,10 +25,10 @@ * -------- * 2007-04-17 initial version (anca) */ - /*! \file - * \brief Kamailio presence module - * \ingroup presence + * \brief SIP-Router Presence :: Kamailio generic presence module + * + * \ingroup presence */ diff --git a/modules_k/presence/doc/presence_admin.xml b/modules_k/presence/doc/presence_admin.xml index 4273d7d..2dd8ec6 100644 --- a/modules_k/presence/doc/presence_admin.xml +++ b/modules_k/presence/doc/presence_admin.xml @@ -27,8 +27,8 @@ is periodically updated in the database, while for PUBLISH only the presence or absence of stored info for a certain resource is maintained in memory to avoid unnecessary, costly database operations. - It is possible to disable in-memory caching by configurng a fallback to database mode - (by setting module parameter "fallback2db"). In this mode, in case a searched record is not + It is possible to disable in-memory caching by configuring a fallback to database mode + (by setting the module parameter "fallback2db"). In this mode, in case a searched record is not found in cache, the search is continued in database. This is useful for an architecture in which processing and memory load might be divided on several &kamailio; instances, maybe on different servers using the same database. @@ -102,7 +102,7 @@ <programlisting format="linespecific"> ... modparam("presence", "db_url", - "mysql://openser:openserrw@192.168.2.132/openser") + "&defaultdb;") ... </programlisting> </example> @@ -225,7 +225,7 @@ modparam("presence", "to_tag_pref", 'pres') <para> The value in seconds that should be subtracted from the expires value when sending a 200OK for a publish. It is used for forcing the client - cu send an update before the old publish expires. + to send an update before the old publish expires. </para> <para> <emphasis>Default value is <quote>0</quote>. @@ -265,7 +265,7 @@ modparam("presence", "max_expires", 3600) <title><varname>server_address</varname> (str)</title> <para> The presence server address which will become the value of Contact header filed - for 200OK replies to Subscribe and Publish and in Notify messages. + for 200 OK replies to SUBSCRIBE and PUBLISH and in NOTIFY messages. </para> <example> <title>Set <varname>server_address</varname> parameter</title> @@ -299,8 +299,8 @@ modparam("presence", "fallback2db", 1) <title><varname>subs_htable_size</varname> (int)</title> <para> The size of the in-memory hash table to store subscription dialogs. - This parameter will be used as the power of 2 when computing table size. - </para> + This parameter will be used as the power of 2 when computing table size. + </para> <para> <emphasis>Default value is <quote>9 (512)</quote>. </emphasis> @@ -318,8 +318,8 @@ modparam("presence", "subs_htable_size", 11) <section> <title><varname>pres_htable_size</varname> (int)</title> <para> - The size of the in-memory hash table to store publish records. - This parameter will be used as the power of 2 when computing table size. + The size of the in-memory hash table to store publish records. + This parameter will be used as the power of 2 when computing table size. </para> <para> <emphasis>Default value is <quote>9 (512)</quote>. @@ -368,10 +368,10 @@ modparam("presence", "enable_sphere_check", 1) </title> <para> Handles PUBLISH requests by storing and updating - published information in memory cach and database, then calls functions to send + published information in memory cache and database, then calls functions to send NOTIFY messages when changes in the published information occur. It takes one argument -> sender_uri. The parameter was added - for enabling BLA implementation. If present, Notification of + for enabling BLA implementation. If present, notification of a change in published state is not sent to the respective uri even though a subscription exists. It should be taken from the Sender header. It was left at the @@ -425,7 +425,7 @@ modparam("presence", "enable_sphere_check", 1) </title> <para> The function which handles SUBSCRIBE requests. It stores or - updates information in memory and database and calls functions to send Notify + updates information in memory and database and calls functions to send NOTIFY messages when a SUBSCRIBE which initiate a dialog is received </para> <para>

15 years, 2 months

git:master: Documentation and doxygen updates

by Olle E. Johansson

Module: sip-router Branch: master Commit: 1ff47a5c6c47b403c7a7b186254fc9168c2267ab URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1ff47a5… Author: oej <oej(a)edvina.net> Committer: oej <oej(a)edvina.net> Date: Sun Oct 25 20:49:25 2009 +0100 Documentation and doxygen updates --- dns_wrappers.h | 7 + dprint.h | 28 ++-- dset.h | 44 +++--- dst_blacklist.h | 62 +++++---- endianness.h | 20 ++-- error.h | 5 - fix_lumps.h | 10 +- modules_k/pua/README | 296 ++++++++++++++++++++++----------------- modules_k/pua/doc/pua_admin.xml | 37 +++--- modules_k/pua/doc/pua_devel.xml | 4 +- 10 files changed, 280 insertions(+), 233 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=1ff…

15 years, 2 months

git:master: Updates (doxygen documentation) to message waiting indication module

by Olle E. Johansson

Module: sip-router Branch: master Commit: 3f9a5599b58ae23aaea5fc160a65b157566d3721 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3f9a559… Author: oej <oej(a)edvina.net> Committer: oej <oej(a)edvina.net> Date: Sun Oct 25 21:03:57 2009 +0100 Updates (doxygen documentation) to message waiting indication module --- modules_k/presence_mwi/README | 70 ++++++++++++--------- modules_k/presence_mwi/add_events.c | 14 +++- modules_k/presence_mwi/add_events.h | 8 +++ modules_k/presence_mwi/doc/presence_mwi_admin.xml | 6 +- modules_k/presence_mwi/presence_mwi.c | 8 +++ modules_k/presence_mwi/presence_mwi.h | 8 +++ 6 files changed, 79 insertions(+), 35 deletions(-) diff --git a/modules_k/presence_mwi/README b/modules_k/presence_mwi/README index ea03c92..44557ff 100644 --- a/modules_k/presence_mwi/README +++ b/modules_k/presence_mwi/README @@ -12,60 +12,72 @@ Juha Heinanen Copyright � 2007 Juha Heinanen Revision History - Revision $Revision: 1 $ $Date: 2007-04-30 14:05:57 +0200 (Mon, - 30 Jan 2007) $ - __________________________________________________________ + Revision $Revision: 1 $ $Date: 2007-04-30 14:05:57 +0200 (Mon, 30 Jan + 2007) $ + __________________________________________________________________ Table of Contents 1. Admin Guide - 1.1. Overview - 1.2. Dependencies + 1. Overview + 2. Dependencies - 1.2.1. Kamailio Modules - 1.2.2. External Libraries or Applications + 2.1. Kamailio Modules + 2.2. External Libraries or Applications - 1.3. Exported Parameters - 1.4. Exported Functions + 3. Exported Parameters + 4. Exported Functions Chapter 1. Admin Guide -1.1. Overview + Table of Contents + + 1. Overview + 2. Dependencies + + 2.1. Kamailio Modules + 2.2. External Libraries or Applications - The module does specific handling for notify-subscribe - message-summary (message waiting indication) events as - specified in RFC 3842. It is used with the general event - handling module, presence. It constructs and adds - message-summary event to it. + 3. Exported Parameters + 4. Exported Functions - The module does not currently implement any authorization - rules. It assumes that publish requests are only issued by a - voicemail application and subscribe requests only by the owner - of voicemail box. Authorization can thus be easily done by - Kamailio configuration file before calling handle_publish() and - handle_subscribe() functions. +1. Overview + + The module does specific handling for notify-subscribe message-summary + (message waiting indication) events as specified in RFC 3842. It is + used with the general event handling module, presence. It constructs + and adds message-summary event to it. + + The module does not currently implement any authorization rules. It + assumes that publish requests are only issued by a voicemail + application and subscribe requests only by the owner of voicemail box. + Authorization can thus be easily done by Kamailio configuration file + before calling handle_publish() and handle_subscribe() functions. The module implements a simple check of content type - application/simple-message-summary: Content must start with - Messages-Waiting status line followed by zero or more lines - that consist of tabs and printable ASCII characters. + "application/simple-message-summary:" Content must start with + "Messages-Waiting" status line followed by zero or more lines that + consist of tabs and printable ASCII characters. + +2. Dependencies -1.2. Dependencies + 2.1. Kamailio Modules + 2.2. External Libraries or Applications -1.2.1. Kamailio Modules +2.1. Kamailio Modules The following modules must be loaded before this module: * presence. -1.2.2. External Libraries or Applications +2.2. External Libraries or Applications None. -1.3. Exported Parameters +3. Exported Parameters None. -1.4. Exported Functions +4. Exported Functions None to be used in configuration file. diff --git a/modules_k/presence_mwi/add_events.c b/modules_k/presence_mwi/add_events.c index 2fcee56..fb0b44a 100644 --- a/modules_k/presence_mwi/add_events.c +++ b/modules_k/presence_mwi/add_events.c @@ -24,6 +24,14 @@ * 2007-05-1 initial version (jih) */ +/*! + * \file + * \brief SIP-router Presence :: Message-waiting indication support + * \ingroup presence + * Module: \ref presence + */ + + #include <stdio.h> #include <stdlib.h> #include <string.h> @@ -31,14 +39,14 @@ #include "../presence/event_list.h" #include "presence_mwi.h" -/* utility function that skips spaces and tabs */ +/*! \brief utility function that skips spaces and tabs */ inline char *eat_sp_tab(char *at, char *over) { while((at < over) && ((*at == ' ') || (*at == '\t'))) at++; return at; } -/* utility function that skips printable ascii chars */ +/*! \brief utility function that skips printable ascii chars */ inline char *eat_printable(char *at, char *over) { while ((at < over) && ((*at == '\t') || ((*at >= 32) && (*at <= 126)))) @@ -46,7 +54,7 @@ inline char *eat_printable(char *at, char *over) return at; } -/* +/*! \brief * event specific publish handling - check if body format is ok */ int mwi_publ_handl(struct sip_msg* msg) diff --git a/modules_k/presence_mwi/add_events.h b/modules_k/presence_mwi/add_events.h index b44fa17..e63b425 100644 --- a/modules_k/presence_mwi/add_events.h +++ b/modules_k/presence_mwi/add_events.h @@ -24,6 +24,14 @@ * 2007-05-1 initial version (jih) */ +/*! + * \file + * \brief SIP-router Presence :: Message Waiting indication + * \ingroup presence + * Module: \ref presence + */ + + #ifndef _MWI_ADD_EV_H_ #define _MWI_ADD_EV_H_ diff --git a/modules_k/presence_mwi/doc/presence_mwi_admin.xml b/modules_k/presence_mwi/doc/presence_mwi_admin.xml index c99d95f..acd66a5 100644 --- a/modules_k/presence_mwi/doc/presence_mwi_admin.xml +++ b/modules_k/presence_mwi/doc/presence_mwi_admin.xml @@ -28,15 +28,15 @@ The module does not currently implement any authorization rules. It assumes that publish requests are only issued by a voicemail application and subscribe requests only by - the owner of voicemail box. Authorization can thus + the owner of voicemail box. Authorization can thus be easily done by &kamailio; configuration file before calling handle_publish() and handle_subscribe() functions. </para> <para> The module implements a simple check of content type - application/simple-message-summary: Content must start - with Messages-Waiting status line followed by zero or + <quote>application/simple-message-summary:</quote> Content must start + with <quote>Messages-Waiting</quote> status line followed by zero or more lines that consist of tabs and printable ASCII characters. </para> diff --git a/modules_k/presence_mwi/presence_mwi.c b/modules_k/presence_mwi/presence_mwi.c index ea4ad2b..fc03c7f 100644 --- a/modules_k/presence_mwi/presence_mwi.c +++ b/modules_k/presence_mwi/presence_mwi.c @@ -24,6 +24,14 @@ * 2007-05-1 initial version (jih) */ +/*! + * \file + * \brief SIP-router Presence :: Message waiting indication + * \ingroup presence + * Module: \ref presence + */ + + #include <stdio.h> #include <stdlib.h> #include <string.h> diff --git a/modules_k/presence_mwi/presence_mwi.h b/modules_k/presence_mwi/presence_mwi.h index 9d7a664..f77ab8b 100644 --- a/modules_k/presence_mwi/presence_mwi.h +++ b/modules_k/presence_mwi/presence_mwi.h @@ -24,6 +24,14 @@ * 2007-05-1 initial version (jih) */ +/*! + * \file + * \brief SIP-router Presence :: Message waiting indication + * \ingroup presence + * Module: \ref presence + */ + + #ifndef _PRES_MWI_H_ #define _PRES_MWI_H_

15 years, 2 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev