sr-dev

sr-dev@lists.kamailio.org

7 participants
45206 discussions

git:andrei/cancel_reason: tm: Reason header generation for local CANCELs
by Andrei Pelinescu-Onciul 02 Mar '10

02 Mar '10

Module: sip-router Branch: andrei/cancel_reason Commit: 70d5b1b4c1bf4deb1dfed13679e9a76f15e9b923 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=70d5b1b… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Mon Mar 1 18:40:19 2010 +0100 tm: Reason header generation for local CANCELs When cancel-ing branches due to final reply, 2xx or 6xx, add a Reason header (according to RFC3326). E.g.: Reason: SIP;cause=200 Internal implementation notes: the branch_bm_t/cancel_bitmap parameter of many of the reply and cancel functions was replaced with a bigger structure that contains all the information associated with the cancel: the cancel branch bitmap, the reason and reason text (optional) or the received cancel message (if any). Note that the current commit does not implement copying Reason headers from a received CANCEL, it deals only with CANCEL generated locally because of a final reply, 2xx or 6xx. --- modules/tm/t_cancel.c | 47 +++++++++++-------- modules/tm/t_cancel.h | 7 ++- modules/tm/t_fwd.c | 3 +- modules/tm/t_msgbuilder.c | 113 ++++++++++++++++++++++++++++++++++++++++---- modules/tm/t_msgbuilder.h | 6 ++- modules/tm/t_reply.c | 78 +++++++++++++++++-------------- modules/tm/t_reply.h | 37 ++++++++++++++- modules/tm/timer.c | 8 ++-- 8 files changed, 221 insertions(+), 78 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=70d…

2 1

[ openser-Patches-2826542 ] Add id parameter to pua_mi's send_publish
by SourceForge.net 02 Mar '10

02 Mar '10

Patches item #2826542, was opened at 2009-07-24 14:27 Message generated for change (Comment added) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2826542&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Add id parameter to pua_mi's send_publish Initial Comment: When using presence with dialog-info, one needs to be able to specify an id, otherwise presentity from different calls for the same presentity-uri will overwrite each other. This patch makes it possible to specify an 'id' in the MI interface for send_publish. Unfortunately it breaks backward compatibility but it's the only way to use dialog-info with MI without having to manually store a the state of the ETag in the proxy. ---------------------------------------------------------------------- >Comment By: Alex Hermann (axlh) Date: 2010-03-02 11:05 Message: I don't think changing the API in a stable release is appropriate. So, no, I didn't commit it to 1.5. It might apply to git master too, but I haven't had time to use/evaluate SR yet and I don't feel comfortable with committing without testing. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-01 20:02 Message: Just saw this one again. Alex, did you commit it? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2826542&group_…

1 0

[ openser-Patches-2961414 ] fix for crash when Content-length too big - ID: 281827
by SourceForge.net 02 Mar '10

02 Mar '10

Patches item #2961414, was opened at 2010-03-01 19:20 Message generated for change (Comment added) made by marcushunger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: fix for crash when Content-length too big - ID: 281827 Initial Comment: are there any valid use cases for a content-length being bigger than the rest of of the packet? i have not tested the issue with kamailio 3.0. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-02 10:51 Message: i retried this with vanilla-kamailio 1.5.4 downloaded from kamailio.org and it crashs. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 20:11 Message: so there's already a fix? i tried this on 1.5.4, and it crashed. maybe i made a mistake merging it to my branch. i am going to check this tomorrow. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-01 19:51 Message: This should not happen, as both pairs (msg_buf,msg_len) and (body,body_len) are set internally. The issue with the nathelper was because the len was taken from content-lenght header, which can be wrong. The discussion ended in whether to auto-correct the content-lenght value or return 400 bad message. In 1.5 the fix to avoid crash was to return error to script, 400 can be sent by using sanity module. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 19:22 Message: sorry, i was not logged in while posting. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_…

1 0

[ openser-Patches-2961414 ] fix for crash when Content-length too big - ID: 281827
by SourceForge.net 01 Mar '10

01 Mar '10

Patches item #2961414, was opened at 2010-03-01 19:20 Message generated for change (Comment added) made by marcushunger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: fix for crash when Content-length too big - ID: 281827 Initial Comment: are there any valid use cases for a content-length being bigger than the rest of of the packet? i have not tested the issue with kamailio 3.0. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 20:11 Message: so there's already a fix? i tried this on 1.5.4, and it crashed. maybe i made a mistake merging it to my branch. i am going to check this tomorrow. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-01 19:51 Message: This should not happen, as both pairs (msg_buf,msg_len) and (body,body_len) are set internally. The issue with the nathelper was because the len was taken from content-lenght header, which can be wrong. The discussion ended in whether to auto-correct the content-lenght value or return 400 bad message. In 1.5 the fix to avoid crash was to return error to script, 400 can be sent by using sanity module. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 19:22 Message: sorry, i was not logged in while posting. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_…

1 0

[ openser-Patches-2826542 ] Add id parameter to pua_mi's send_publish
by SourceForge.net 01 Mar '10

01 Mar '10

Patches item #2826542, was opened at 2009-07-24 15:27 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2826542&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Add id parameter to pua_mi's send_publish Initial Comment: When using presence with dialog-info, one needs to be able to specify an id, otherwise presentity from different calls for the same presentity-uri will overwrite each other. This patch makes it possible to specify an 'id' in the MI interface for send_publish. Unfortunately it breaks backward compatibility but it's the only way to use dialog-info with MI without having to manually store a the state of the ETag in the proxy. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-01 21:02 Message: Just saw this one again. Alex, did you commit it? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2826542&group_…

1 0

xmlrpc
by Jason Penton 01 Mar '10

01 Mar '10

Hi All, I have taken the ideas from sip-router/ser/kamailio-3.0.0 regarding the XMLRPC management interface. I have used the ideas and incorporated them into kamailio 1.5 and I was wondering how useful this would be giving back to the community? If there is interest, what is the preferred way to distribute (there are a few minor changes to the core - msg_translator and receive)? I suppose a diff against the 1.5 svn would be the best? The advantages over the existing XMLRPC interface: 1. multiple processes to serve xmlrpc requests. Effectively, we use the tcp receive threads to process the xmlrpc calls. 2. no dependence on the Abyss server (this is a big plus for me) therefore, better performance and smaller footprint. ps. my motivation for this is that I had noticed performance issues and memory leaks in the existing mi_xmlrpc module in Kamailio. Cheers Jason

2 2

[ openser-Patches-2961414 ] fix for crash when Content-length too big - ID: 281827
by SourceForge.net 01 Mar '10

01 Mar '10

Patches item #2961414, was opened at 2010-03-01 20:20 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: fix for crash when Content-length too big - ID: 281827 Initial Comment: are there any valid use cases for a content-length being bigger than the rest of of the packet? i have not tested the issue with kamailio 3.0. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-01 20:51 Message: This should not happen, as both pairs (msg_buf,msg_len) and (body,body_len) are set internally. The issue with the nathelper was because the len was taken from content-lenght header, which can be wrong. The discussion ended in whether to auto-correct the content-lenght value or return 400 bad message. In 1.5 the fix to avoid crash was to return error to script, 400 can be sent by using sanity module. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 20:22 Message: sorry, i was not logged in while posting. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_…

1 0

[ openser-Patches-2961414 ] fix for crash when Content-length too big - ID: 281827
by SourceForge.net 01 Mar '10

01 Mar '10

1 0

[ openser-Patches-2961414 ] fix for crash when Content-length too big - ID: 281827
by SourceForge.net 01 Mar '10

01 Mar '10

Patches item #2961414, was opened at 2010-03-01 18:20 Message generated for change (Tracker Item Submitted) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: fix for crash when Content-length too big - ID: 281827 Initial Comment: are there any valid use cases for a content-length being bigger than the rest of of the packet? i have not tested the issue with kamailio 3.0. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_…

1 0

[ openser-Bugs-2818273 ] crash when Content-length too big
by SourceForge.net 01 Mar '10

01 Mar '10

Bugs item #2818273, was opened at 2009-07-08 01:28 Message generated for change (Comment added) made by marcushunger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2818273&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: crash when Content-length too big Initial Comment: Recently we encountered some crashes of kamailio 1.5.0 caused by messages with too big value of Content-length (more than 30000). When the parser in nathelper.c looks for old and new port it sometimes finds occurences after the real end of the message. Then the sanity check in del_lump() in data_lump.c finds that either offset or offset+len is greater than msg->len and calls abort(). ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 14:51 Message: It seems that the ERROR is not really a problem, and the crash happened on 1.5.3. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 12:45 Message: I am afraid, this issue is not yet fixed. The latest release version (1.5.4-notls (i386/linux)) still produces: Mar 1 11:53:12 test02 /usr/sbin/kamailio[5173]: ERROR:core:anchor_lump: offset exceeds message size (1799 > 1783)... Mar 1 11:53:12 test02 /usr/sbin/kamailio[5173]: ERROR:nathelper:force_rtp_proxy: anchor_lump failed This is reproducible. I even experienced a crash: Feb 26 14:58:44 test02 /usr/sbin/kamailio[21020]: CRITICAL:core:del_lump: offset exceeds message size (1186 > 1132) aborting... To trigger this, one needs to send an invite with a content-length bigger than the actual content through force_rtp_proxy. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-10-05 08:54 Message: This should be fixed in 1.5.2 and latest svn, have you tried the latest 1.5 svn branch? ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-08 17:17 Message: 'kamailio -V' says 'kamailio 1.5.0-notls (x86_64/linux)' ---------------------------------------------------------------------- Comment By: Klaus Darilion (klaus_darilion) Date: 2009-07-08 10:38 Message: Which excat version are you using? There were some bugfixes recently. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2818273&group_…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev