sr-dev February 2011

sr-dev@lists.kamailio.org

22 participants
125 discussions

git:3.1: acc: take SIP method from CSeq header
by Daniel-Constantin Mierla 08 Feb '11

08 Feb '11

Module: sip-router Branch: 3.1 Commit: 31b9e07399fc19c7c297a46e6411859348ad0c3e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=31b9e07… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jan 29 20:47:18 2011 +0100 acc: take SIP method from CSeq header - safe usage of acc_*_request() for requests & replies (cherry picked from commit 7866c516bd3bf5c6befc8d978d02bf34ab338e3a) --- modules_k/acc/acc.c | 4 ++-- modules_k/acc/acc_mod.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules_k/acc/acc.c b/modules_k/acc/acc.c index 271bdb3..189152b 100644 --- a/modules_k/acc/acc.c +++ b/modules_k/acc/acc.c @@ -125,8 +125,8 @@ int core2strar(struct sip_msg *req, str *c_vals, int *i_vals, char *t_vals) struct hdr_field *from; struct hdr_field *to; - /* method */ - c_vals[0] = req->first_line.u.request.method; + /* method : request/reply - cseq parsed in acc_preparse_req() */ + c_vals[0] = get_cseq(req)->method; t_vals[0] = TYPE_STR; /* from/to URI and TAG */ diff --git a/modules_k/acc/acc_mod.c b/modules_k/acc/acc_mod.c index 5ded9a4..ee9336e 100644 --- a/modules_k/acc/acc_mod.c +++ b/modules_k/acc/acc_mod.c @@ -191,21 +191,21 @@ static int free_acc_fixup(void** param, int param_no); static cmd_export_t cmds[] = { {"acc_log_request", (cmd_function)w_acc_log_request, 1, acc_fixup, free_acc_fixup, - REQUEST_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + ANY_ROUTE}, #ifdef SQL_ACC {"acc_db_request", (cmd_function)w_acc_db_request, 2, acc_fixup, free_acc_fixup, - REQUEST_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + ANY_ROUTE}, #endif #ifdef RAD_ACC {"acc_rad_request", (cmd_function)w_acc_rad_request, 1, acc_fixup, free_acc_fixup, - REQUEST_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + ANY_ROUTE}, #endif #ifdef DIAM_ACC {"acc_diam_request",(cmd_function)w_acc_diam_request,1, acc_fixup, free_acc_fixup, - REQUEST_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + ANY_ROUTE}, #endif {"bind_acc", (cmd_function)bind_acc, 0, 0, 0}, {0, 0, 0, 0, 0, 0}

1 0

git:3.1: core: check for empty port values
by Daniel-Constantin Mierla 08 Feb '11

08 Feb '11

Module: sip-router Branch: 3.1 Commit: 68a3740e3f9fcabd944d295f2e6e03cda172e5e9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=68a3740… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jan 29 03:11:46 2011 +0100 core: check for empty port values - if setport has empty string parameter skip adding ':' (cherry picked from commit d260b2cba84e1699fe9b2c0860de91e018e03bca) --- action.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/action.c b/action.c index 67c6026..e72dd46 100644 --- a/action.c +++ b/action.c @@ -990,8 +990,10 @@ int do_action(struct run_act_ctx* h, struct action* a, struct sip_msg* msg) tmp=0; else if (a->type==SET_PORT_T) { tmp=a->val[0].u.string; - if (tmp) len = strlen(tmp); - else len = 0; + if (tmp) { + len = strlen(tmp); + if(len==0) tmp = 0; + } else len = 0; } else { tmp=uri.port.s; len = uri.port.len;

1 0

git:3.1: topoh: add angle brackets around contact uri
by Daniel-Constantin Mierla 08 Feb '11

08 Feb '11

Module: sip-router Branch: 3.1 Commit: 5fbb96cc6e0bfc8135b8385dcd337e8bb0e60c0a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5fbb96c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Feb 4 19:27:10 2011 +0100 topoh: add angle brackets around contact uri - if there are no angle brackets around initial contact uri, add for encoded uri to keep URI parameters properly (cherry picked from commit 66f80a68a48835b1634da04ead4deadeb89ce7f7) --- modules/topoh/th_msg.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/modules/topoh/th_msg.c b/modules/topoh/th_msg.c index a721141..df29ea1 100644 --- a/modules/topoh/th_msg.c +++ b/modules/topoh/th_msg.c @@ -247,6 +247,7 @@ int th_mask_contact(sip_msg_t *msg) struct lump* l; str out; str in; + char *p; contact_t *c; if(msg->contact==NULL) @@ -270,6 +271,24 @@ int th_mask_contact(sip_msg_t *msg) LM_ERR("cannot encode contact uri\n"); return -1; } + if(*(in.s-1)!='<') + { + /* add < > around contact uri if not there */ + p = (char*)pkg_malloc(out.len+3); + if(p==NULL) + { + LM_ERR("failed to get more pkg\n"); + pkg_free(out.s); + return -1; + } + *p = '<'; + strncpy(p+1, out.s, out.len); + p[out.len+1] = '>'; + p[out.len+2] = '\0'; + pkg_free(out.s); + out.s = p; + out.len += 2; + } l=del_lump(msg, in.s-msg->buf, in.len, 0); if (l==0)

1 0

git:master: htable: fixes to mod param names in docs
by Elena-Ramona Modroiu 08 Feb '11

08 Feb '11

Module: sip-router Branch: master Commit: 279d82c50b42a42fa5205d8296bdebcc2e5ac184 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=279d82c… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Committer: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Tue Feb 8 12:35:48 2011 +0100 htable: fixes to mod param names in docs --- modules_k/htable/README | 20 ++++++++++---------- modules_k/htable/doc/htable.xml | 2 +- modules_k/htable/doc/htable_admin.xml | 12 ++++++------ 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/modules_k/htable/README b/modules_k/htable/README index cd43570..7cd7da8 100644 --- a/modules_k/htable/README +++ b/modules_k/htable/README @@ -60,10 +60,10 @@ Elena-Ramona Modroiu 1.2. Dictionary attack limitation 1.3. Set hash_size parameter 1.4. Set db_url parameter - 1.5. Set key_name parameter - 1.6. Set key_name parameter - 1.7. Set value_type parameter - 1.8. Set key_value parameter + 1.5. Set key_name_column parameter + 1.6. Set key_type_column parameter + 1.7. Set value_type_column parameter + 1.8. Set key_value_column parameter 1.9. Set array_size_suffix parameter 1.10. Set fetch_rows parameter 1.11. Set timer_interval parameter @@ -295,7 +295,7 @@ modparam("htable", "db_url", "mysql://openser:openserrw@localhost/openser") Default value is 'key_name'. - Example 1.5. Set key_name parameter + Example 1.5. Set key_name_column parameter ... modparam("htable", "key_name_column", "kname") ... @@ -306,7 +306,7 @@ modparam("htable", "key_name_column", "kname") Default value is 'key_type'. - Example 1.6. Set key_name parameter + Example 1.6. Set key_type_column parameter ... modparam("htable", "key_type_column", "ktype") ... @@ -317,9 +317,9 @@ modparam("htable", "key_type_column", "ktype") Default value is 'value_type'. - Example 1.7. Set value_type parameter + Example 1.7. Set value_type_column parameter ... -modparam("htable", "value_type", "vtype") +modparam("htable", "value_type_column", "vtype") ... 3.6. key_value_column (str) @@ -328,9 +328,9 @@ modparam("htable", "value_type", "vtype") Default value is 'key_value'. - Example 1.8. Set key_value parameter + Example 1.8. Set key_value_column parameter ... -modparam("htable", "key_value", "kvalue") +modparam("htable", "key_value_column", "kvalue") ... 3.7. array_size_suffix (str) diff --git a/modules_k/htable/doc/htable.xml b/modules_k/htable/doc/htable.xml index f4d31b2..8081252 100644 --- a/modules_k/htable/doc/htable.xml +++ b/modules_k/htable/doc/htable.xml @@ -31,7 +31,7 @@ </editor> </authorgroup> <copyright> - <year>2008</year> + <year>2008-2011</year> <holder>http://www.asipto.com</holder> </copyright> </bookinfo> diff --git a/modules_k/htable/doc/htable_admin.xml b/modules_k/htable/doc/htable_admin.xml index 85c9871..56e921b 100644 --- a/modules_k/htable/doc/htable_admin.xml +++ b/modules_k/htable/doc/htable_admin.xml @@ -308,7 +308,7 @@ modparam("htable", "db_url", "mysql://openser:openserrw@localhost/openser") </emphasis> </para> <example> - <title>Set <varname>key_name</varname> parameter</title> + <title>Set <varname>key_name_column</varname> parameter</title> <programlisting format="linespecific"> ... modparam("htable", "key_name_column", "kname") @@ -327,7 +327,7 @@ modparam("htable", "key_name_column", "kname") </emphasis> </para> <example> - <title>Set <varname>key_name</varname> parameter</title> + <title>Set <varname>key_type_column</varname> parameter</title> <programlisting format="linespecific"> ... modparam("htable", "key_type_column", "ktype") @@ -346,10 +346,10 @@ modparam("htable", "key_type_column", "ktype") </emphasis> </para> <example> - <title>Set <varname>value_type</varname> parameter</title> + <title>Set <varname>value_type_column</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("htable", "value_type", "vtype") +modparam("htable", "value_type_column", "vtype") ... </programlisting> </example> @@ -365,10 +365,10 @@ modparam("htable", "value_type", "vtype") </emphasis> </para> <example> - <title>Set <varname>key_value</varname> parameter</title> + <title>Set <varname>key_value_column</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("htable", "key_value", "kvalue") +modparam("htable", "key_value_column", "kvalue") ... </programlisting> </example>

1 0

git:master: htable: option to save content of htable to db at shutdown
by Elena-Ramona Modroiu 08 Feb '11

08 Feb '11

Module: sip-router Branch: master Commit: ebf12d93251124d619e6d12093181eab5bab5818 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ebf12d9… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Committer: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Tue Feb 8 12:18:10 2011 +0100 htable: option to save content of htable to db at shutdown - new 'dbmode' attribute for hash table definition - if dbmode=1, the content fo hash table will be saved back to databse table when the sip server is stopped - default value is 0 - no sync back to database table - example: modparam("htable", "htable", "a=>size=8;dbtable=htable;dbmode=1;") --- modules_k/htable/ht_api.c | 36 ++++++++++++++- modules_k/htable/ht_api.h | 4 +- modules_k/htable/ht_db.c | 107 +++++++++++++++++++++++++++++++++++++++++++++ modules_k/htable/ht_db.h | 2 + modules_k/htable/htable.c | 12 +++++ 5 files changed, 158 insertions(+), 3 deletions(-) diff --git a/modules_k/htable/ht_api.c b/modules_k/htable/ht_api.c index 5951167..fe9a66e 100644 --- a/modules_k/htable/ht_api.c +++ b/modules_k/htable/ht_api.c @@ -117,7 +117,7 @@ ht_t* ht_get_table(str *name) return NULL; } -int ht_pkg_init(str *name, int autoexp, str *dbtable, int size) +int ht_pkg_init(str *name, int autoexp, str *dbtable, int size, int dbmode) { unsigned int htid; ht_t *ht; @@ -155,6 +155,7 @@ int ht_pkg_init(str *name, int autoexp, str *dbtable, int size) ht->name = *name; if(dbtable!=NULL && dbtable->len>0) ht->dbtable = *dbtable; + ht->dbmode = dbmode; ht->next = _ht_pkg_root; _ht_pkg_root = ht; @@ -516,6 +517,7 @@ int ht_table_spec(char *spec) unsigned int autoexpire = 0; unsigned int size = 4; int type = 0; + unsigned int dbmode = 0; str in; str tok; char *p; @@ -570,6 +572,8 @@ next_token: type = 2; else if(tok.len==4 && strncmp(tok.s, "size", 4)==0) type = 3; + else if(tok.len==6 && strncmp(tok.s, "dbmode", 6)==0) + type = 4; else goto error; if(*p!='=') @@ -613,6 +617,12 @@ next_token: LM_DBG("htable [%.*s] - size [%u]\n", name.len, name.s, size); break; + case 4: + if(str2int(&tok, &dbmode)!=0) + goto error; + LM_DBG("htable [%.*s] - dbmode [%u]\n", name.len, name.s, + dbmode); + break; } while(p<in.s+in.len && (*p==';' || *p==' ' || *p=='\t' || *p=='\n' || *p=='\r')) @@ -620,7 +630,7 @@ next_token: if(p<in.s+in.len) goto next_token; - return ht_pkg_init(&name, autoexpire, &dbtable, size); + return ht_pkg_init(&name, autoexpire, &dbtable, size, dbmode); error: LM_ERR("invalid htable parameter [%.*s] at [%d]\n", in.len, in.s, @@ -648,6 +658,28 @@ int ht_db_load_tables(void) return 0; } +int ht_db_sync_tables(void) +{ + ht_t *ht; + + ht = _ht_root; + while(ht) + { + if(ht->dbtable.len>0 && ht->dbmode!=0) + { + LM_DBG("sync db table [%.*s] from ht [%.*s]\n", + ht->dbtable.len, ht->dbtable.s, + ht->name.len, ht->name.s); + ht_db_delete_records(&ht->dbtable); + if(ht_db_save_table(ht, &ht->dbtable)!=0) + LM_ERR("failed sync'ing hash table [%.*s] to db\n", + ht->name.len, ht->name.s); + } + ht = ht->next; + } + return 0; +} + int ht_has_autoexpire(void) { ht_t *ht; diff --git a/modules_k/htable/ht_api.h b/modules_k/htable/ht_api.h index 99ff84a..71c8e21 100644 --- a/modules_k/htable/ht_api.h +++ b/modules_k/htable/ht_api.h @@ -54,6 +54,7 @@ typedef struct _ht unsigned int htid; unsigned int htexpire; str dbtable; + int dbmode; unsigned int htsize; ht_entry_t *entries; struct _ht *next; @@ -65,7 +66,7 @@ typedef struct _ht_pv { pv_elem_t *pve; } ht_pv_t, *ht_pv_p; -int ht_pkg_init(str *name, int autoexp, str *dbtable, int size); +int ht_pkg_init(str *name, int autoexp, str *dbtable, int size, int dbmode); int ht_shm_init(void); int ht_destroy(void); int ht_set_cell(ht_t *ht, str *name, int type, int_str *val, int mode); @@ -79,6 +80,7 @@ int ht_cell_free(ht_cell_t *cell); int ht_table_spec(char *spec); ht_t* ht_get_table(str *name); int ht_db_load_tables(void); +int ht_db_sync_tables(void); int ht_has_autoexpire(void); void ht_timer(unsigned int ticks, void *param); diff --git a/modules_k/htable/ht_db.c b/modules_k/htable/ht_db.c index 0f88500..7addf81 100644 --- a/modules_k/htable/ht_db.c +++ b/modules_k/htable/ht_db.c @@ -43,6 +43,9 @@ str ht_db_vtype_column = str_init("value_type"); str ht_db_value_column = str_init("key_value"); int ht_fetch_rows = 100; +/** + * init module parameters + */ int ht_db_init_params(void) { if(ht_db_url.s==0) @@ -62,6 +65,9 @@ int ht_db_init_params(void) return 0; } +/** + * initialize database connection + */ int ht_db_init_con(void) { /* binding to DB module */ @@ -79,6 +85,10 @@ int ht_db_init_con(void) } return 0; } + +/** + * open database connection + */ int ht_db_open_con(void) { /* open a connection with the database */ @@ -93,6 +103,9 @@ int ht_db_open_con(void) return 0; } +/** + * close database connection + */ int ht_db_close_con(void) { if (ht_db_con!=NULL && ht_dbf.close!=NULL) @@ -104,6 +117,9 @@ int ht_db_close_con(void) #define HT_NAME_BUF_SIZE 256 static char ht_name_buf[HT_NAME_BUF_SIZE]; +/** + * load content of a db table in hash table + */ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) { db_key_t db_cols[4] = {&ht_db_name_column, &ht_db_ktype_column, @@ -290,3 +306,94 @@ error: } +/** + * save hash table content back to database + */ +int ht_db_save_table(ht_t *ht, str *dbtable) +{ + db_key_t db_cols[4] = {&ht_db_name_column, &ht_db_ktype_column, + &ht_db_vtype_column, &ht_db_value_column}; + db_val_t db_vals[4]; + ht_cell_t *it; + str tmp; + int i; + + if(ht_db_con==NULL) + { + LM_ERR("no db connection\n"); + return -1; + } + + if (ht_dbf.use_table(ht_db_con, dbtable) < 0) + { + LM_ERR("failed to use_table\n"); + return -1; + } + + LM_DBG("save the content of hash table [%.*s] to database in [%.*s]\n", + ht->name.len, ht->name.s, dbtable->len, dbtable->s); + + for(i=0; i<ht->htsize; i++) + { + lock_get(&ht->entries[i].lock); + it = ht->entries[i].first; + while(it) + { + db_vals[0].type = DB1_STR; + db_vals[0].nul = 0; + db_vals[0].val.str_val.s = it->name.s; + db_vals[0].val.str_val.len = it->name.len; + + db_vals[1].type = DB1_INT; + db_vals[1].nul = 0; + db_vals[1].val.int_val = 0; + + db_vals[2].type = DB1_INT; + db_vals[2].nul = 0; + db_vals[2].val.int_val = 0; + + db_vals[3].type = DB1_STR; + db_vals[3].nul = 0; + if(it->flags&AVP_VAL_STR) { + db_vals[3].val.str_val.s = it->value.s.s; + db_vals[3].val.str_val.len = it->value.s.len; + } else { + tmp.s = sint2str((long)it->value.n, &tmp.len); + db_vals[3].val.str_val.s = tmp.s; + db_vals[3].val.str_val.len = tmp.len; + } + if(ht_dbf.insert(ht_db_con, db_cols, db_vals, 4) < 0) + { + LM_ERR("failed to store key [%.*s] in table [%.*s]\n", + it->name.len, it->name.s, + dbtable->len, dbtable->s); + } + it = it->next; + } + } + return 0; +} + + +/** + * delete databse table + */ +int ht_db_delete_records(str *dbtable) +{ + if(ht_db_con==NULL) + { + LM_ERR("no db connection\n"); + return -1; + } + + if (ht_dbf.use_table(ht_db_con, dbtable) < 0) + { + LM_ERR("failed to use_table\n"); + return -1; + } + + if(ht_dbf.delete(ht_db_con, NULL, NULL, NULL, 0) < 0) + LM_ERR("failed to detele db records in [%.*s]\n", + dbtable->len, dbtable->s); + return 0; +} diff --git a/modules_k/htable/ht_db.h b/modules_k/htable/ht_db.h index 14802bd..1edb345 100644 --- a/modules_k/htable/ht_db.h +++ b/modules_k/htable/ht_db.h @@ -38,5 +38,7 @@ int ht_db_init_con(void); int ht_db_open_con(void); int ht_db_close_con(void); int ht_db_load_table(ht_t *ht, str *dbtable, int mode); +int ht_db_save_table(ht_t *ht, str *dbtable); +int ht_db_delete_records(str *dbtable); #endif diff --git a/modules_k/htable/htable.c b/modules_k/htable/htable.c index ac01e32..f7af1d9 100644 --- a/modules_k/htable/htable.c +++ b/modules_k/htable/htable.c @@ -212,6 +212,18 @@ static int child_init(int rank) */ static void destroy(void) { + /* sync back to db */ + if(ht_db_url.len>0) + { + if(ht_db_init_con()==0) + { + if(ht_db_open_con()==0) + { + ht_db_sync_tables(); + ht_db_close_con(); + } + } + } ht_destroy(); }

1 0

git:master: htable: added 'dbmode' attribute to module documentation
by Elena-Ramona Modroiu 08 Feb '11

08 Feb '11

Module: sip-router Branch: master Commit: 15c87249242b602f268ea7e86713d1cbcc0c34dd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=15c8724… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Committer: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Tue Feb 8 12:22:13 2011 +0100 htable: added 'dbmode' attribute to module documentation --- modules_k/htable/README | 4 ++++ modules_k/htable/doc/htable_admin.xml | 8 ++++++++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/modules_k/htable/README b/modules_k/htable/README index facb147..cd43570 100644 --- a/modules_k/htable/README +++ b/modules_k/htable/README @@ -264,6 +264,10 @@ if(is_present_hf("Authorization")) expire. * dbtable - name of database to be loaded at startup in hash table. If empty or missing, no data will be loaded. + * dbmode - if set to 1, the content of hash table is written to + database table when the SIP server is stopped (i.e., ensure + persistency over restarts). Default value is 0 (no write back to db + table). Default value is NULL. diff --git a/modules_k/htable/doc/htable_admin.xml b/modules_k/htable/doc/htable_admin.xml index e2c2be6..85c9871 100644 --- a/modules_k/htable/doc/htable_admin.xml +++ b/modules_k/htable/doc/htable_admin.xml @@ -253,6 +253,14 @@ if(is_present_hf("Authorization")) startup in hash table. If empty or missing, no data will be loaded. </para> </listitem> + <listitem> + <para> + <emphasis>dbmode</emphasis> - if set to 1, the content of hash + table is written to database table when the SIP server is stopped + (i.e., ensure persistency over restarts). Default value is 0 (no + write back to db table). + </para> + </listitem> </itemizedlist> <para> <emphasis>

1 0

planning release of v3.1.2
by Daniel-Constantin Mierla 08 Feb '11

08 Feb '11

Hello, I think it is time to release v3.1.2, first date that comes in my mind is next Thursday if everyone feels it is enough time to take care of backporting any fix he/she did and it is not yet there. That will provide us a fresh release for the FOSDEM event. If not, then maybe the other week, Tuesday, so the participants at the Kamailio Devel training in Barcelona can practice on it. Soon after we should plan also a release for previous stable, branch 3.0. Anyone having other options? Thanks, Daniel -- Daniel-Constantin Mierla http://www.asipto.com

1 1

topoh, angle brackets and Contact URI params interpretation
by Andrew Pogrebennyk 07 Feb '11

07 Feb '11

I'm having an issue with topoh module in Kamailio 3.1.0. When Contact header is formed like this: Contact: 0991 <sip:192.168.0.107;line=sr-N6IAzBysz.tyz.D4M.VLOBMfOBFuWxvfMxV4> The other party responds properly. But when there is no angle brackets in Contact: Contact: sip:192.168.0.107;line=sr-N6IAzB3AWxyfz.stM.quOBFZMJZfWxj7W.y-MljAWBy* Really, many parsers implement "prefer shift to reduce" principle, which means if something can be interpreted in more enclosed expression, it will be interpreted this way and no as part of less enclosed expression so ;line is interpreted as header parameter but not URI parameter. RFC 3261 section 20 suggests that any URI parameters be contained within angle brackets: === The Contact, From, and To header fields contain a URI. If the URI contains a comma, question mark or semicolon, the URI MUST be enclosed in angle brackets (< and >). Any URI parameters are contained within these brackets. If the URI is not enclosed in angle brackets, any semicolon-delimited parameters are header-parameters, not URI parameters. === I think the topoh module should force the angle brackets. BTW it seems that parameter needs to be urlencoded, see rule 'other-param' in RFC 3261 section 25.1: other-param = pname [ "=" pvalue ] pname = 1*paramchar pvalue = 1*paramchar paramchar = param-unreserved / unreserved / escaped param-unreserved = "[" / "]" / "/" / ":" / "&" / "+" / "$" No .-* characters are allowed in the paramchar. But at least that's not causing me any problems. -- Sincerely, Andrew Pogrebennyk

3 6

Testing of sctp in Kamailio
by Asif Iqbal syed 07 Feb '11

07 Feb '11

Hello, To Dear Klaus, Thanks for your response. it works now. Is there any way I can test sctp in Kamailio. In addition, Is it possible to test sctp using sipp. Thanks. Asif

1 0

Compiling kamailio with sctp support enabled
by Asif Iqbal syed 07 Feb '11

07 Feb '11

Hi, I have been trying to compile kamailio with sctp support enabled by following the installation instruction from http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-3.1.x-from-git. Still no success. Here is what I am doing. 1. git clone --depth 1 git://git.sip-router.org/sip-router kamailio 2. cd kamailio 3. git checkout -b 3.1 origin/3.1 4. make FLAVOUR=kamailio cfg 5. nano -w modules.lst 6. make FLAVOUR=kamailio include_modules="db_mysql dialplan" cfg 7. make PREFIX="/usr/local/kamailio-3.1" FLAVOUR=kamailio include_modules="db_mysql dialplan" cfg 8. SCTP=1 make all 9. SCTP=1 make install Then run kamailio and execute sercmd. Do core.sctp_info. It shows error 500: sctp support not compiled. I would appreciate if someone help me what I am missing. Thanking you. Asif

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2011