sr-dev February 2011

sr-dev@lists.kamailio.org

22 participants
124 discussions

Implementation question / usrloc / registrar

by Carsten Bock

Hi everyone, just a short request for comments: Similar to the dialog-variables, which i implemented in my IMS branch recently, i need something similar for usrloc. Basically, i need to store additional data to a registration; which i can access after "lookup()" or upon a "is_registered()" call. Basically: $reg_var(test) = "some value"; save(); - - - lookup(); xlog("reg_var(test) is $reg_var(test)\n"); Now there are different approaches: 1) implement this funtionality in usrloc/registrar directly (similar to my dialog-pvar-implementation). The performance when doing this impact should be minor if not used, since simply an empty pointer would be carried along every registration. This would be the cleanest way to do this; but however since many people are using usrloc i have a little respect doing changes on such core-module. Maybe it could be implemented as a change in usrloc and a dedicated module just for getting and setting the values. 2) another way would be to implement this in a dedicated module. This would mean, that i would not touch usrloc module and it would of course have no impact on "regular" usrloc usage at all if not used. I would have to add a second list of in-memory values, which would have to be synched with db, a second timer to do so. The list would be dependent on the usrloc callbacks. There is always the danger data-inconsistency. 3) is there any way, to do this with some event-routes, shared-variables or something similar? Any thoughts? Comments very welcome! Kind regards, Carsten P.S.: If i do not receive any comments, i would implement the first approach (directly in usrloc/registrar) in my IMS-branch for later merging into master.

13 years, 9 months

git:master: modules/lcr: gateways of an LCR instance are not anymore required

by Juha Heinanen

Module: sip-router Branch: master Commit: 6cdf90764965f0d52bd7c34d5f2605d0cfa30a17 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6cdf907… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Feb 9 06:20:00 2011 +0200 modules/lcr: gateways of an LCR instance are not anymore required to be "unique" --- modules/lcr/lcr_mod.c | 28 +++------------------------- 1 files changed, 3 insertions(+), 25 deletions(-) diff --git a/modules/lcr/lcr_mod.c b/modules/lcr/lcr_mod.c index d64647a..790c1e8 100644 --- a/modules/lcr/lcr_mod.c +++ b/modules/lcr/lcr_mod.c @@ -793,26 +793,9 @@ static int comp_gws(const void *_g1, const void *_g2) } -/* - * Check if ip_addr/grp_id of gateway is unique. +/* + * Insert gw info into index i or gws table */ -static int gw_unique(const struct gw_info *gws, const unsigned int count, - const unsigned int ip_addr, const unsigned int port, - char *hostname, unsigned int hostname_len) -{ - unsigned int i; - - for (i = 1; i <= count; i++) { - if ((gws[i].ip_addr == ip_addr) && - (gws[i].port == port) && - (gws[i].hostname_len == hostname_len) && - (strncasecmp(gws[i].hostname, hostname, hostname_len) == 0)) { - return 0; - } - } - return 1; -} - static int insert_gw(struct gw_info *gws, unsigned int i, unsigned int gw_id, char *gw_name, unsigned int gw_name_len, unsigned int scheme, unsigned int ip_addr, @@ -823,11 +806,6 @@ static int insert_gw(struct gw_info *gws, unsigned int i, unsigned int gw_id, unsigned int prefix_len, char *tag, unsigned int tag_len, unsigned int flags, unsigned int defunct_until) { - if (gw_unique(gws, i - 1, ip_addr, port, hostname, hostname_len) == 0) { - LM_ERR("gw <%s, %u, %.*s> is not unique\n", ip_string, port, - hostname_len, hostname); - return 0; - } gws[i].gw_id = gw_id; if (gw_name_len) memcpy(&(gws[i].gw_name[0]), gw_name, gw_name_len); gws[i].gw_name_len = gw_name_len; @@ -962,7 +940,7 @@ int reload_tables() for (lcr_id = 1; lcr_id <= lcr_count_param; lcr_id++) { - /* reload rules */ + /* Reload rules */ rules = rule_pt[0]; rule_hash_table_contents_free(rules);

13 years, 9 months

Kamailio v3.1.2 Released

by Daniel-Constantin Mierla

Hello, Kamailio SIP Server v3.1.2 stable release is out. This is a maintenance release of latest stable branch, 3.1, that includes fixes since release of v3.1.1. There is no change to database or configuration file required to upgrade to 3.1.2 from 3.1.0 or 3.1.1 versions, therefore it is strongly recommended to upgrade to v3.1.2. For more details about version 3.1.2, visit: http://www.kamailio.org/w/2011/02/kamailio-v3-1-2-released/ Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com

13 years, 9 months

git:3.1: ChangeLog: fixed release data for 3.1.2

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: 4d9f9026766cc1802f61f29f0f47f745c3112888 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4d9f902… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Feb 8 19:44:57 2011 +0100 ChangeLog: fixed release data for 3.1.2 --- ChangeLog | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index bbad95e..44d0434 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,4 @@ -===================== 2010-02-08 Version 3.1.2 Released ===================== +===================== 2011-02-08 Version 3.1.2 Released ===================== ===================== Changes Since Version 3.1.1 ===========================

13 years, 9 months

git:3.1: ChangeLog: updated for version 3.1.2

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: d217b0438985bc31afe8674bc3080c7b44640f9f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d217b04… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Feb 8 18:38:06 2011 +0100 ChangeLog: updated for version 3.1.2 --- ChangeLog | 641 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 640 insertions(+), 1 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=d21…

13 years, 9 months

git:3.1: Makefile: version set to 3.1.2

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: 7dd78e9455394f7279ce9f598b062febb1765a4f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7dd78e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Feb 8 18:34:31 2011 +0100 Makefile: version set to 3.1.2 --- Makefile.defs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index 1ceb63b..83e2c2d 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -159,7 +159,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) #version number VERSION = 3 PATCHLEVEL = 1 -SUBLEVEL = 1 +SUBLEVEL = 2 EXTRAVERSION = # memory debugger switcher

13 years, 9 months

SF.net SVN: openser:[6053] branches/1.5/modules/dialog/doc/dialog_admin.xml

by Timo Reimann

Revision: 6053 http://openser.svn.sourceforge.net/openser/?rev=6053&view=rev Author: timoreimann Date: 2011-02-08 16:03:20 +0000 (Tue, 08 Feb 2011) Log Message: ----------- dialog: added missing parameter in example Backport from git commit 1705424e70650ae0d173227221b04d1160c3e2c4. Modified Paths: -------------- branches/1.5/modules/dialog/doc/dialog_admin.xml This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

13 years, 9 months

SF.net SVN: openser:[6052] branches/1.5/modules/dialog/dialog.c

by Timo Reimann

Revision: 6052 http://openser.svn.sourceforge.net/openser/?rev=6052&view=rev Author: timoreimann Date: 2011-02-08 13:24:35 +0000 (Tue, 08 Feb 2011) Log Message: ----------- modules/dialog: set null value parameter for get_dlg_profile() with 2 params - because of using same internal function for cfg get_dlg_profile(...), when only 2 params were provided, the third was unpredicted and not null most probably, potentially resulting in a crash - reported by Eugene Oden Backport from git commit 028e3cc1a34f1e682d604a7c0e3fb1a7da03a211. Modified Paths: -------------- branches/1.5/modules/dialog/dialog.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

13 years, 9 months

git:3.1: acc: fixed typo in example

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: ce67a1bad7ca3e7964fba33eb6537e2e4ff3666a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ce67a1b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jan 29 20:51:07 2011 +0100 acc: fixed typo in example - updated the route types where acc_*_request() can be used --- modules_k/acc/README | 8 ++++---- modules_k/acc/doc/acc_admin.xml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/modules_k/acc/README b/modules_k/acc/README index 3e38cdc..1075a7c 100644 --- a/modules_k/acc/README +++ b/modules_k/acc/README @@ -859,7 +859,7 @@ modparam("acc", "diameter_extra", "7846=$hdr(Content-type);7847=$avp(s:email)") Meaning of the parameters is as follows: * comment - Comment to be appended. - This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + This function can be used from ANY_ROUTE. Example 1.35. acc_log_request usage ... @@ -876,7 +876,7 @@ acc_log_request("Some comment"); * comment - Comment to be appended. * table - Database table to be used. - This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + This function can be used from ANY_ROUTE. Example 1.36. acc_db_request usage ... @@ -891,7 +891,7 @@ acc_log_request("Some comment", "Some table"); Meaning of the parameters is as follows: * comment - Comment to be appended. - This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + This function can be used from ANY_ROUTE. Example 1.37. acc_rad_request usage ... @@ -906,7 +906,7 @@ acc_rad_request("Some comment"); Meaning of the parameters is as follows: * comment - Comment to be appended. - This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + This function can be used from ANY_ROUTE. Example 1.38. acc_diam_request usage ... diff --git a/modules_k/acc/doc/acc_admin.xml b/modules_k/acc/doc/acc_admin.xml index 82184fa..fadf022 100644 --- a/modules_k/acc/doc/acc_admin.xml +++ b/modules_k/acc/doc/acc_admin.xml @@ -968,7 +968,7 @@ modparam("acc", "diameter_extra", "7846=$hdr(Content-type);7847=$avp(s:email)") </listitem> </itemizedlist> <para> - This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + This function can be used from ANY_ROUTE. </para> <example> <title>acc_log_request usage</title> @@ -1001,7 +1001,7 @@ acc_log_request("Some comment"); </listitem> </itemizedlist> <para> - This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + This function can be used from ANY_ROUTE. </para> <example> <title>acc_db_request usage</title> @@ -1031,7 +1031,7 @@ acc_log_request("Some comment", "Some table"); </listitem> </itemizedlist> <para> - This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + This function can be used from ANY_ROUTE. </para> <example> <title>acc_rad_request usage</title> @@ -1060,7 +1060,7 @@ acc_rad_request("Some comment"); </listitem> </itemizedlist> <para> - This function can be used from REQUEST_ROUTE, FAILURE_ROUTE. + This function can be used from ANY_ROUTE. </para> <example> <title>acc_diam_request usage</title>

13 years, 9 months

git:3.1: acc: take SIP method from CSeq header

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: 31b9e07399fc19c7c297a46e6411859348ad0c3e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=31b9e07… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jan 29 20:47:18 2011 +0100 acc: take SIP method from CSeq header - safe usage of acc_*_request() for requests & replies (cherry picked from commit 7866c516bd3bf5c6befc8d978d02bf34ab338e3a) --- modules_k/acc/acc.c | 4 ++-- modules_k/acc/acc_mod.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules_k/acc/acc.c b/modules_k/acc/acc.c index 271bdb3..189152b 100644 --- a/modules_k/acc/acc.c +++ b/modules_k/acc/acc.c @@ -125,8 +125,8 @@ int core2strar(struct sip_msg *req, str *c_vals, int *i_vals, char *t_vals) struct hdr_field *from; struct hdr_field *to; - /* method */ - c_vals[0] = req->first_line.u.request.method; + /* method : request/reply - cseq parsed in acc_preparse_req() */ + c_vals[0] = get_cseq(req)->method; t_vals[0] = TYPE_STR; /* from/to URI and TAG */ diff --git a/modules_k/acc/acc_mod.c b/modules_k/acc/acc_mod.c index 5ded9a4..ee9336e 100644 --- a/modules_k/acc/acc_mod.c +++ b/modules_k/acc/acc_mod.c @@ -191,21 +191,21 @@ static int free_acc_fixup(void** param, int param_no); static cmd_export_t cmds[] = { {"acc_log_request", (cmd_function)w_acc_log_request, 1, acc_fixup, free_acc_fixup, - REQUEST_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + ANY_ROUTE}, #ifdef SQL_ACC {"acc_db_request", (cmd_function)w_acc_db_request, 2, acc_fixup, free_acc_fixup, - REQUEST_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + ANY_ROUTE}, #endif #ifdef RAD_ACC {"acc_rad_request", (cmd_function)w_acc_rad_request, 1, acc_fixup, free_acc_fixup, - REQUEST_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + ANY_ROUTE}, #endif #ifdef DIAM_ACC {"acc_diam_request",(cmd_function)w_acc_diam_request,1, acc_fixup, free_acc_fixup, - REQUEST_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + ANY_ROUTE}, #endif {"bind_acc", (cmd_function)bind_acc, 0, 0, 0}, {0, 0, 0, 0, 0, 0}

13 years, 9 months

← Newer
1
...
7
8
9
10
11
12
13
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2011