sr-dev February 2011

sr-dev@lists.kamailio.org

22 participants
125 discussions

[tracker] Comment added: Kamailio init script reports falsely "Kamailio already running"
by sip-router 15 Feb '11

15 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#113 - Kamailio init script reports falsely "Kamailio already running" User who did this - Iñaki Baz Castillo (ibc) ---------- Sometime ago I submitted a patch (Marius did it in fact) which iomproved the daemonize of Kamailio, so the parent process comunicates with the main process (daemonized process) via a PIPE and just returns 0 (OK) in case the main process writes "ok" in the PIPE. This just worked. However I saw some changes about such mechanism in more recent commits. I've haven't tested it yet. Which Kamailio version are you running? On the other hand, your patch for the init script is just a workaround (don't take me wrong). The daemon itself is responsible of returning a real status code instead of always returning 0 (ok). ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=113#comment158 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:3.1: module/pdb: Cleared event for poll() that was left uncleared
by Marius Zbihlei 15 Feb '11

15 Feb '11

Module: sip-router Branch: 3.1 Commit: e914f97b4729bfe15215ba4a2ac53640644343c2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e914f97… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Tue Feb 15 18:44:56 2011 +0200 module/pdb: Cleared event for poll() that was left uncleared --- modules/pdb/pdb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/pdb/pdb.c b/modules/pdb/pdb.c index b5ceb65..8ad6f90 100644 --- a/modules/pdb/pdb.c +++ b/modules/pdb/pdb.c @@ -273,6 +273,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct buf[NETBUFSIZE] = '\0'; if (strncmp(buf, number.s, number.len) == 0) { carrierid=ntohs(*((short int *)&(buf[reqlen]))); /* convert to host byte order */ + server_list->fds[i].revents = 0; /* clear event for respoding server */ goto found; } }

1 0

git:3.1: core:forward.c Fixed small error caused by unlikely usage.
by Marius Zbihlei 14 Feb '11

14 Feb '11

Module: sip-router Branch: 3.1 Commit: 9ef0a1e347abd31b352d3cb85326605fd72e6789 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9ef0a1e… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Thu Nov 4 17:14:56 2010 +0200 core:forward.c Fixed small error caused by unlikely usage. (cherry picked from commit 6cfee82666b78400d5ff15c49aac1441cfbbaaf6) --- forward.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/forward.c b/forward.c index 3d7aed1..175f54b 100644 --- a/forward.c +++ b/forward.c @@ -175,7 +175,7 @@ retry: if( !mhomed_sock_cache_disabled ){ /* some Linux kernel versions (all?) along with other UNIXes don't re-bound the sock if already bound */ /* to un-bound a socket set sin_family to AF_UNSPEC and zero out the rest*/ - if (unlikely(connect(*temp_sock, &uncon.s, sockaddru_len(uncon))) < 0) + if (unlikely(connect(*temp_sock, &uncon.s, sockaddru_len(uncon)) < 0)) mhomed_sock_cache_disabled = 1; }

1 0

git:3.1: core/forward.c Fixed mhomed behavior.
by Marius Zbihlei 14 Feb '11

14 Feb '11

Module: sip-router Branch: 3.1 Commit: 3ec1e92fcb3ce8c673e6762c0a35a9bc8ade3a22 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3ec1e92… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Thu Nov 4 16:11:41 2010 +0200 core/forward.c Fixed mhomed behavior. As connect() dones't re-bound a UDP sock if the socket is already bound to an interface, first unbind the socket by connecting to AF_UNSPEC (cherry picked from commit ef0dd4e3f0837753ac18d58606078d8595f24dc6) --- forward.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/forward.c b/forward.c index 25bc11d..3d7aed1 100644 --- a/forward.c +++ b/forward.c @@ -131,6 +131,10 @@ struct socket_info* get_out_socket(union sockaddr_union* to, int proto) union sockaddr_union from; struct socket_info* si; struct ip_addr ip; + union sockaddr_union uncon; + + memset(&uncon, 0, sizeof(union sockaddr_union)); + uncon.sin.sin_family = AF_UNSPEC; if (unlikely(proto!=PROTO_UDP)) { LOG(L_CRIT, "BUG: get_out_socket can only be called for UDP\n"); @@ -167,6 +171,14 @@ retry: return 0; } } + + if( !mhomed_sock_cache_disabled ){ + /* some Linux kernel versions (all?) along with other UNIXes don't re-bound the sock if already bound */ + /* to un-bound a socket set sin_family to AF_UNSPEC and zero out the rest*/ + if (unlikely(connect(*temp_sock, &uncon.s, sockaddru_len(uncon))) < 0) + mhomed_sock_cache_disabled = 1; + } + if (unlikely(connect(*temp_sock, &to->s, sockaddru_len(*to))==-1)) { if (unlikely(errno==EISCONN && !mhomed_sock_cache_disabled)){ /* no multiple connects support on the same socket */

1 0

sctp info parameter value zeo
by Asif Iqbal syed 13 Feb '11

13 Feb '11

Hi, My sctp info value shows all zero. Is there any explanation?Is my setup correct? $sercmd core.sctp_info { opened_connections: 0 tracked_connections: 0 total_connections: 0 } Thanking you. Asif On Mon, Feb 7, 2011 at 3:14 PM, Klaus Darilion <klaus.mailinglists(a)pernau.at > wrote: > Make sure you have the sctp libraries installed. > > regards > klaus > > Am 06.02.2011 06:21, schrieb Asif Iqbal syed: > > Hi, > > > > I have been trying to compile kamailio with sctp support enabled by > > following the installation instruction from > > > http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-3.1.x-from-git. > > Still no success. Here is what I am doing. > > > > 1. git clone --depth 1 git://git.sip-router.org/sip-router kamailio > > 2. cd kamailio > > 3. git checkout -b 3.1 origin/3.1 > > 4. make FLAVOUR=kamailio cfg > > 5. nano -w modules.lst > > 6. make FLAVOUR=kamailio include_modules="db_mysql dialplan" cfg > > 7. make PREFIX="/usr/local/kamailio-3.1" FLAVOUR=kamailio > > include_modules="db_mysql dialplan" cfg > > 8. SCTP=1 make all > > 9. SCTP=1 make install > > > > Then run kamailio and execute sercmd. Do core.sctp_info. It shows error > 500: > > sctp support not compiled. > > > > I would appreciate if someone help me what I am missing. > > > > Thanking you. > > > > Asif > > > > > > > > > > _______________________________________________ > > sr-dev mailing list > > sr-dev(a)lists.sip-router.org > > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev >

2 1

[tracker] Comment added: Kamailio init script reports falsely "Kamailio already running" (Attachment added)
by sip-router 11 Feb '11

11 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#113 - Kamailio init script reports falsely "Kamailio already running" User who did this - Klaus Darilion (klaus3000) ---------- patched the patch :-) ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=113#comment157 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task changed: Kamailio init script reports falsely "Kamailio already running"
by sip-router 11 Feb '11

11 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#113 - Kamailio init script reports falsely "Kamailio already running" User who did this: Klaus Darilion (klaus3000) Task details edited: ------- Hi! The init script for Debian always reports "Kamailio already running" if Kamailio does not start although the config is correct (e.g. can not bind to socket). IMO we could improve it a bit by checking if Kamailio is really running (at least check for PID file and process). Attached is a patch which solves this, feel free to make it nicer. ------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=113 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio init script reports falsely "Kamailio already running" (Attachment added)
by sip-router 11 Feb '11

11 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#113 - Kamailio init script reports falsely "Kamailio already running" User who did this - Klaus Darilion (klaus3000) ---------- uploaded patch as file (whitespaces) ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=113#comment156 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: Kamailio init script reports falsely "Kamailio already running"
by sip-router 11 Feb '11

11 Feb '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Klaus Darilion (klaus3000) Attached to Project - sip-router Summary - Kamailio init script reports falsely "Kamailio already running" Task Type - Bug Report Category - tools/scripts Status - New Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hi! The init script for Debian always reports "Kamailio already running" if Kamailio does not start although the config is correct (e.g. can not bind to socket). IMO we could improve it a bit by checking if Kamailio is really running (at least check for PID file and process). This is a patch which solves this, feel free to make it nicer. --- kamailio.orig 2011-02-11 18:55:28.000000000 +0100 +++ kamailio 2011-02-11 19:20:43.000000000 +0100 @@ -124,8 +124,16 @@ echo -n "Starting $DESC: $NAME" start-stop-daemon --start --quiet --pidfile $PIDFILE \ - --exec $DAEMON -- $OPTIONS || echo -n " already running" - echo "." + --exec $DAEMON -- $OPTIONS || if [ ! -r "$PIDFILE" ]; then + echo " error, failed to start." + exit 3 + elif read pid < "$PIDFILE" && ps -p "$pid" > /dev/null 2>&1; then + echo -n " already running" + echo "." + else + echo " error, failed to start ($PIDFILE exists)." + exit 1 + fi ;; stop) echo -n "Stopping $DESC: $NAME" More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=113 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Crash bug if Via header removed + changes applied
by Alex Balashov 10 Feb '11

10 Feb '11

Don't ask me why anyone would want to do this, but, for simple stateful relay scenario: UAC --> Kamailio --> UAS This: remove_hf("Via"); msg_apply_changes(); will crash Kamailio: Feb 10 18:54:22 diminuendo-1 /usr/local/sbin/kamailio[30982]: ERROR: tm [t_lookup.c:540]: ERROR: t_lookup_request: no via Feb 10 18:54:22 diminuendo-1 /usr/local/sbin/kamailio[30981]: ALERT: <core> [main.c:741]: child process 30982 exited by a signal 11 -- Alex Balashov - Principal Evariste Systems LLC 260 Peachtree Street NW Suite 2200 Atlanta, GA 30303 Tel: +1-678-954-0670 Fax: +1-404-961-1892 Web: http://www.evaristesys.com/

1 0

← Newer
1
...
5
6
7
8
9
10
11
12
13
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2011