sr-dev October 2016

sr-dev@lists.kamailio.org

28 participants
235 discussions

git:4.4:0cd00fc0: modules/tmx: fix mi command t_uac_cancel
by Federico Cabiddu 19 Oct '16

19 Oct '16

Module: kamailio Branch: 4.4 Commit: 0cd00fc0c84b1d3d80fff9ae809835057bbe6a4e URL: https://github.com/kamailio/kamailio/commit/0cd00fc0c84b1d3d80fff9ae8098350… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2016-10-19T12:00:36+02:00 modules/tmx: fix mi command t_uac_cancel (cherry picked from commit 81be737f29cbb9e4fd67a09cf2207150b2649e91) --- Modified: modules/tmx/t_mi.c --- Diff: https://github.com/kamailio/kamailio/commit/0cd00fc0c84b1d3d80fff9ae8098350… Patch: https://github.com/kamailio/kamailio/commit/0cd00fc0c84b1d3d80fff9ae8098350… --- diff --git a/modules/tmx/t_mi.c b/modules/tmx/t_mi.c index 485b160..beab1c5 100644 --- a/modules/tmx/t_mi.c +++ b/modules/tmx/t_mi.c @@ -641,6 +641,7 @@ struct mi_root* mi_tm_cancel(struct mi_root* cmd_tree, void* param) init_cancel_info(&cancel_data); cancel_data.cancel_bitmap = ~0; /*all branches*/ + _tmx_tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); _tmx_tmb.cancel_uacs(trans, &cancel_data, 0); _tmx_tmb.unref_cell(trans);

1 0

git:master:8a001514: Merge pull request #825 from kamailio/t_uac_cancel-fix
by GitHub 19 Oct '16

19 Oct '16

Module: kamailio Branch: master Commit: 8a0015140dabaa7de4ad47744903cb722dba674a URL: https://github.com/kamailio/kamailio/commit/8a0015140dabaa7de4ad47744903cb7… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2016-10-19T11:59:44+02:00 Merge pull request #825 from kamailio/t_uac_cancel-fix modules/tmx: fix mi command t_uac_cancel --- Modified: modules/tmx/t_mi.c --- Diff: https://github.com/kamailio/kamailio/commit/8a0015140dabaa7de4ad47744903cb7… Patch: https://github.com/kamailio/kamailio/commit/8a0015140dabaa7de4ad47744903cb7… --- diff --git a/modules/tmx/t_mi.c b/modules/tmx/t_mi.c index c3b14fb..d6ada3e 100644 --- a/modules/tmx/t_mi.c +++ b/modules/tmx/t_mi.c @@ -641,6 +641,7 @@ struct mi_root* mi_tm_cancel(struct mi_root* cmd_tree, void* param) init_cancel_info(&cancel_data); cancel_data.cancel_bitmap = ~0; /*all branches*/ + _tmx_tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); _tmx_tmb.cancel_uacs(trans, &cancel_data, 0); _tmx_tmb.unref_cell(trans);

1 0

git:master:81be737f: modules/tmx: fix mi command t_uac_cancel
by Federico Cabiddu 19 Oct '16

19 Oct '16

Module: kamailio Branch: master Commit: 81be737f29cbb9e4fd67a09cf2207150b2649e91 URL: https://github.com/kamailio/kamailio/commit/81be737f29cbb9e4fd67a09cf220715… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2016-10-19T11:32:25+02:00 modules/tmx: fix mi command t_uac_cancel --- Modified: modules/tmx/t_mi.c --- Diff: https://github.com/kamailio/kamailio/commit/81be737f29cbb9e4fd67a09cf220715… Patch: https://github.com/kamailio/kamailio/commit/81be737f29cbb9e4fd67a09cf220715… --- diff --git a/modules/tmx/t_mi.c b/modules/tmx/t_mi.c index c3b14fb..d6ada3e 100644 --- a/modules/tmx/t_mi.c +++ b/modules/tmx/t_mi.c @@ -641,6 +641,7 @@ struct mi_root* mi_tm_cancel(struct mi_root* cmd_tree, void* param) init_cancel_info(&cancel_data); cancel_data.cancel_bitmap = ~0; /*all branches*/ + _tmx_tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); _tmx_tmb.cancel_uacs(trans, &cancel_data, 0); _tmx_tmb.unref_cell(trans);

1 0

[kamailio/kamailio] modules/tmx: fix mi command t_uac_cancel (#825)
by Federico Cabiddu 19 Oct '16

19 Oct '16

fix for mi command t_uac_cancel: without calling prepare_to_cancel, the following call to cancel_uacs gives this error: BUG: tm [t_cancel.c:327]: cancel_branch(): tm: cancel_branch: local_cancel buffer=(nil) != BUSY_BUFFER (trying to continue) and it does not cancel the transaction. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/825 -- Commit Summary -- * modules/tmx: fix mi command t_uac_cancel -- File Changes -- M modules/tmx/t_mi.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/825.patch https://github.com/kamailio/kamailio/pull/825.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/825

2 2

Re: [sr-dev] [kamailio/kamailio] db_unixodbc: do not consider SQL_NO_DATA return code as an error (feb195b)
by Daniel-Constantin Mierla 19 Oct '16

19 Oct '16

@korayvt - it would be better and easier to review if you make a pull request with the updates you think they must be done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/feb195b2d9c801bc3591b1e95de6b70…

1 0

git:4.4:df4bba3f: tmx: fix condition for private copy of the message
by Federico Cabiddu 19 Oct '16

19 Oct '16

Module: kamailio Branch: 4.4 Commit: df4bba3f82b97fb9dc1b86b681060b8250a9be20 URL: https://github.com/kamailio/kamailio/commit/df4bba3f82b97fb9dc1b86b681060b8… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2016-10-19T11:41:46+02:00 tmx: fix condition for private copy of the message (cherry picked from commit 6913d30ccf2ea5a818180053453ace4b482b8d30) --- Modified: modules/tmx/t_var.c --- Diff: https://github.com/kamailio/kamailio/commit/df4bba3f82b97fb9dc1b86b681060b8… Patch: https://github.com/kamailio/kamailio/commit/df4bba3f82b97fb9dc1b86b681060b8…

1 0

Re: [sr-dev] [kamailio/kamailio] db_unixodbc: do not consider SQL_NO_DATA return code as an error (feb195b)
by korayvt 19 Oct '16

19 Oct '16

I think this modification should be applied to other SQLExecDirect function calls. For example line 147. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/feb195b2d9c801bc3591b1e95de6b70…

1 0

git:master:dc96dfde: mohqueue: fix pointer for RTP statistics error
by Robert Boisvert 18 Oct '16

18 Oct '16

Module: kamailio Branch: master Commit: dc96dfdee3c6a8e56ed9e5929e444bf8ee2f5cdd URL: https://github.com/kamailio/kamailio/commit/dc96dfdee3c6a8e56ed9e5929e444bf… Author: Robert Boisvert <rdbprog(a)gmail.com> Committer: Robert Boisvert <rdbprog(a)gmail.com> Date: 2016-10-18T18:00:42-04:00 mohqueue: fix pointer for RTP statistics error --- Modified: modules/mohqueue/mohq.c --- Diff: https://github.com/kamailio/kamailio/commit/dc96dfdee3c6a8e56ed9e5929e444bf… Patch: https://github.com/kamailio/kamailio/commit/dc96dfdee3c6a8e56ed9e5929e444bf… --- diff --git a/modules/mohqueue/mohq.c b/modules/mohqueue/mohq.c index 17b2f2b..a6ae5cf 100644 --- a/modules/mohqueue/mohq.c +++ b/modules/mohqueue/mohq.c @@ -449,7 +449,7 @@ if(rtplen != prtpstat->len) LM_ERR ("Unable to find RTPSTAT pv!\n"); goto initerr; } -prtp_pv = pv_cache_get (&prtpstat[0]); +prtp_pv = pv_cache_get (prtpstat); if(!prtp_pv) { LM_ERR ("Unable to find pv spec for RTPSTAT!\n");

1 0

git:master:56bc84cb: modules/ims_usrloc_scscf: modify sql creation script to extend some fields
by Richard Good 18 Oct '16

18 Oct '16

Module: kamailio Branch: master Commit: 56bc84cb700bb90cfd0916839f81dcef064c16eb URL: https://github.com/kamailio/kamailio/commit/56bc84cb700bb90cfd0916839f81dce… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: 2016-10-18T09:55:47+02:00 modules/ims_usrloc_scscf: modify sql creation script to extend some fields watcher_uri, watcher_contact, presentity_uri extended from varchar(50) to varchar(100) as these can exceed 50 --- Modified: utils/kamctl/mysql/ims_usrloc_scscf-create.sql --- Diff: https://github.com/kamailio/kamailio/commit/56bc84cb700bb90cfd0916839f81dce… Patch: https://github.com/kamailio/kamailio/commit/56bc84cb700bb90cfd0916839f81dce… --- diff --git a/utils/kamctl/mysql/ims_usrloc_scscf-create.sql b/utils/kamctl/mysql/ims_usrloc_scscf-create.sql index 51cd30b..ae7bd93 100644 --- a/utils/kamctl/mysql/ims_usrloc_scscf-create.sql +++ b/utils/kamctl/mysql/ims_usrloc_scscf-create.sql @@ -39,9 +39,9 @@ CREATE TABLE `impu_contact` ( INSERT INTO version (table_name, table_version) values ('subscriber','6'); CREATE TABLE `subscriber` ( `id` int(11) NOT NULL AUTO_INCREMENT, - `watcher_uri` varchar(50) NOT NULL, - `watcher_contact` varchar(50) NOT NULL, - `presentity_uri` varchar(50) NOT NULL, + `watcher_uri` varchar(100) NOT NULL, + `watcher_contact` varchar(100) NOT NULL, + `presentity_uri` varchar(100) NOT NULL, `event` int(11) NOT NULL, `expires` datetime NOT NULL, `version` int(11) NOT NULL,

1 0

[kamailio/kamailio] UAC Module Problems when using rtpengine (#819)
by vinzens 17 Oct '16

17 Oct '16

We do have a strange behavior while using UACreg module and rtpengine. So far we used uacreg to register to an external pbx and we are using rtpenginde since we do not know if there is NAT on the far side. With an kamailio 4.4.2 there are no problems doing this. Now we tried to update to 4.4.3 and 5 (latest) we do see an issue with this two modules. Problem we have is on an basic call while DA chellange. By using DA catching from uac module and an updated SDP from rptengine the uac module seems to crash and the DA chellange (unauth) gets forwarded to the calling side instead of answered by the uac Module. it seems the DA chellange is causeing the problem but only if the original invite was modified by RTP engine. in the logs i can see this happening: ``` f94ea564de0806c4a811bce674@xx.xx.120.5:5060 Status: <null> <null> F:user T:123 R:123] Remote asked for authentication Oct 11 16:02:11 gaudino /usr/sbin/kamailio[8342]: ERROR: <core> [msg_translator.c:417]: clen_builder(): no message body found (missing crlf?) Oct 11 16:02:11 gaudino /usr/sbin/kamailio[8342]: ERROR: <core> [msg_translator.c:1963]: build_req_buf_from_sip_req(): Error while adjusting Content-Length Oct 11 16:02:11 gaudino /usr/sbin/kamailio[8342]: ERROR: tm [t_fwd.c:462]: prepare_new_uac(): could not build request Oct 11 16:02:11 gaudino /usr/sbin/kamailio[8342]: ERROR: tm [t_fwd.c:1723]: t_forward_nonack(): ERROR: t_forward_nonack: failure to add branches Oct 11 16:02:11 gaudino /usr/sbin/kamailio[8342]: ERROR: tm [tm.c:1415]: _w_t_relay_to(): ERROR: w_t_relay_to: t_relay_to failed ``` When i disable the rtpengine the problem does not occur as well as the kamailio 4.4.2 did not have this issue. I can provide config, traces and debug logs (via mail) please tell me where to send. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/819

3 11

← Newer
1
...
11
12
13
14
15
16
17
...
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2016