sr-dev October 2016

sr-dev@lists.kamailio.org

28 participants
234 discussions

git:master:775e23b1: modules/ims_usrloc_scscf: new parameter max_subscribes

by Richard Good

Module: kamailio Branch: master Commit: 775e23b12c9788b40c913a2bf4fdd5ce2a2957bb URL: https://github.com/kamailio/kamailio/commit/775e23b12c9788b40c913a2bf4fdd5c… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: 2016-10-17T15:39:20+02:00 modules/ims_usrloc_scscf: new parameter max_subscribes max_subscribes parameter - this limits the number of subscriptions per IMPU, watcher URI and event combination. The oldest subscription will be overwritten if the maximum is reached. --- Modified: modules/ims_usrloc_scscf/subscribe.c Modified: modules/ims_usrloc_scscf/ul_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/775e23b12c9788b40c913a2bf4fdd5c… Patch: https://github.com/kamailio/kamailio/commit/775e23b12c9788b40c913a2bf4fdd5c…

8 years, 1 month

[kamailio/kamailio] Possible bug with track_cseq_updates set in dialog (#789)

by scfcplummy

Hi, When setting "track_cseq_updates" in dialog module, the ReINVITE that should be initiated with uac_auth() is never sent. Without "track_cseq_updates" set to 0, the reINVITE does take place. In the log I can see dialog doing the cseq update: Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: DEBUG: dialog [dlg_cseq.c:129]: dlg_cseq_update(): initiating cseq updates Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: DEBUG: dialog [dlg_hash.c:690]: dlg_lookup(): ref dlg 0x7fc2b265f4f0 with 1 -> 2 Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: DEBUG: dialog [dlg_hash.c:692]: dlg_lookup(): dialog id=4263 found on entry 1771 Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: DEBUG: dialog [dlg_var.c:250]: print_lists(): Internal var-list ((nil)): Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: DEBUG: dialog [dlg_var.c:260]: print_lists(): Dialog var-list (0x7fc2b265f2d8): Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: DEBUG: dialog [dlg_var.c:262]: print_lists(): cseq_diff=1 (flags 1) Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: DEBUG: dialog [dlg_cseq.c:176]: dlg_cseq_update(): adding auth cseq header value: 5136 but quickly followed by these errors: Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: ERROR: <core> [msg_translator.c:417]: clen_builder(): no message body found (missing crlf?) Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: ERROR: <core> [msg_translator.c:1963]: build_req_buf_from_sip_req(): Error while adjusting Content-Length Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: ERROR: tm [t_fwd.c:462]: prepare_new_uac(): could not build request Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: ERROR: tm [t_fwd.c:1723]: t_forward_nonack(): ERROR: t_forward_nonack: failure to add branches Sep 20 07:54:57 sbc /usr/local/sbin/kamailio[35746]: ERROR: tm [tm.c:1415]: _w_t_relay_to(): ERROR: w_t_relay_to: t_relay_to failed Kamailio was built from kamailio-4.4.3 source downloaded from here: https://www.kamailio.org/pub/kamailio/latest/src/ Version information: version: kamailio 4.4.3 (x86_64/linux) 5a2195 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 5a2195 compiled on 08:46:12 Sep 16 2016 with gcc 5.4.0 Many thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/789

8 years, 1 month

[kamailio/kamailio] uac_auth() function broken in 4.4.3 (#797)

by Sebastian Damm

We upgraded a system from 4.4.2 to 4.4.3 last week. After that, the uac_auth() function didn't do what it was supposed to do anymore. This is the failure route in the config file: ``` failure_route[TRUNKAUTH] { if (t_is_canceled()) { exit; } if ($T_reply_code == 401 or $T_reply_code == 407) { xlog("L_NOTICE", "[$pr:$si:$sp] [$cs $rm cid: $ci Status: $rs $rr F:$fU T:$tU R:$rU] Remote asked for authentication"); uac_auth(); t_relay(); exit; } } ``` In Kamailio 4.4.2 this works perfectly. In 4.4.3 when this code triggers, we get the following messages in our log: ``` Sep 23 12:25:41 eustatius /usr/sbin/kamailio[13249]: NOTICE: <script>: [udp:1.2.3.4:5060] [102 INVITE cid: asdasdalsjdalsdaskjdlak Status: <null> <null> F:11111111 T:00491234567890 R:01234567890] Remote asked for authentication Sep 23 12:25:41 eustatius /usr/sbin/kamailio[13249]: ERROR: <core> [msg_translator.c:417]: clen_builder(): no message body found (missing crlf?) Sep 23 12:25:41 eustatius /usr/sbin/kamailio[13249]: ERROR: <core> [msg_translator.c:1963]: build_req_buf_from_sip_req(): Error while adjusting Content-Length Sep 23 12:25:41 eustatius /usr/sbin/kamailio[13249]: ERROR: tm [t_fwd.c:462]: prepare_new_uac(): could not build request Sep 23 12:25:41 eustatius /usr/sbin/kamailio[13249]: ERROR: tm [t_fwd.c:1723]: t_forward_nonack(): ERROR: t_forward_nonack: failure to add branches Sep 23 12:25:41 eustatius /usr/sbin/kamailio[13249]: ERROR: tm [tm.c:1415]: _w_t_relay_to(): ERROR: w_t_relay_to: t_relay_to failed ``` After downgrading to 4.4.2, everything works again. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/797

8 years, 1 month

git:master:dd0b7e40: dialog: propre reparse of msg structure when doing cseq refresh ops

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: dd0b7e403404a977707aa1524783111190cc5f3e URL: https://github.com/kamailio/kamailio/commit/dd0b7e403404a977707aa1524783111… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-10-17T12:27:08+02:00 dialog: propre reparse of msg structure when doing cseq refresh ops - triggering parsing from scratch always resulted in improper propagation of parsing flags and failure to detect end of headers - credits to JÃ¶ran Vinzens for assistance with troubleshooting - GH #819 --- Modified: modules/dialog/dlg_cseq.c --- Diff: https://github.com/kamailio/kamailio/commit/dd0b7e403404a977707aa1524783111… Patch: https://github.com/kamailio/kamailio/commit/dd0b7e403404a977707aa1524783111… --- diff --git a/modules/dialog/dlg_cseq.c b/modules/dialog/dlg_cseq.c index 4d60180..743a61d 100644 --- a/modules/dialog/dlg_cseq.c +++ b/modules/dialog/dlg_cseq.c @@ -53,12 +53,9 @@ static str _dlg_cseq_diff_var_name = str_init("cseq_diff"); /** * */ -int dlg_cseq_prepare_msg(sip_msg_t *msg) +static int dlg_cseq_prepare_msg(sip_msg_t *msg) { - if (parse_msg(msg->buf, msg->len, msg)!=0) { - LM_DBG("outbuf buffer parsing failed!"); - return 1; - } + LM_DBG("prepare msg for cseq update operations\n"); if(msg->first_line.type==SIP_REQUEST) { if(!IS_SIP(msg)) @@ -109,6 +106,19 @@ int dlg_cseq_prepare_msg(sip_msg_t *msg) /** * */ +static int dlg_cseq_prepare_new_msg(sip_msg_t *msg) +{ + LM_DBG("prepare new msg for cseq update operations\n"); + if (parse_msg(msg->buf, msg->len, msg)!=0) { + LM_DBG("outbuf buffer parsing failed!"); + return 1; + } + return dlg_cseq_prepare_msg(msg); +} + +/** + * + */ int dlg_cseq_update(sip_msg_t *msg) { dlg_cell_t *dlg = NULL; @@ -268,7 +278,7 @@ int dlg_cseq_msg_received(void *data) msg.buf = obuf->s; msg.len = obuf->len; - if(dlg_cseq_prepare_msg(&msg)!=0) { + if(dlg_cseq_prepare_new_msg(&msg)!=0) { goto done; } @@ -350,7 +360,7 @@ int dlg_cseq_msg_sent(void *data) msg.buf = obuf->s; msg.len = obuf->len; - if(dlg_cseq_prepare_msg(&msg)!=0) { + if(dlg_cseq_prepare_new_msg(&msg)!=0) { goto done; }

8 years, 1 month

git:master:69b5c014: Merge pull request #824 from kamailio/grumvalski/tmx-msg-copy-fix

by GitHub

Module: kamailio Branch: master Commit: 69b5c01480e5bc0aabf93604abcdb5899953e084 URL: https://github.com/kamailio/kamailio/commit/69b5c01480e5bc0aabf93604abcdb58… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2016-10-17T11:16:14+02:00 Merge pull request #824 from kamailio/grumvalski/tmx-msg-copy-fix tmx: fix condition for private copy of the message --- Modified: modules/tmx/t_var.c --- Diff: https://github.com/kamailio/kamailio/commit/69b5c01480e5bc0aabf93604abcdb58… Patch: https://github.com/kamailio/kamailio/commit/69b5c01480e5bc0aabf93604abcdb58…

8 years, 1 month

git:master:6913d30c: tmx: fix condition for private copy of the message

by Federico Cabiddu

Module: kamailio Branch: master Commit: 6913d30ccf2ea5a818180053453ace4b482b8d30 URL: https://github.com/kamailio/kamailio/commit/6913d30ccf2ea5a818180053453ace4… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2016-10-17T09:50:36+02:00 tmx: fix condition for private copy of the message --- Modified: modules/tmx/t_var.c --- Diff: https://github.com/kamailio/kamailio/commit/6913d30ccf2ea5a818180053453ace4… Patch: https://github.com/kamailio/kamailio/commit/6913d30ccf2ea5a818180053453ace4…

8 years, 1 month

[kamailio/kamailio] tmx: fix condition for private copy of the message (#824)

by Federico Cabiddu

porting of the changes done for ims_auth and ims_registrar_scscf modules. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/824 -- Commit Summary -- * tmx: fix condition for private copy of the message -- File Changes -- M modules/tmx/t_var.c (46) -- Patch Links -- https://github.com/kamailio/kamailio/pull/824.patch https://github.com/kamailio/kamailio/pull/824.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/824

8 years, 1 month

git:master:a63f390d: alias_db: added flags to control alias db lookup and reverse lookup

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a63f390d45d94cbef7cf310bcdaf362a958961f4 URL: https://github.com/kamailio/kamailio/commit/a63f390d45d94cbef7cf310bcdaf362… Author: Kristian Hogh <kfh(a)uni-tel.dk> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-10-17T11:10:13+02:00 alias_db: added flags to control alias db lookup and reverse lookup - with some refactoring of the patch from PR GH #823 --- Modified: modules/alias_db/alias_db.c Modified: modules/alias_db/alias_db.h Modified: modules/alias_db/alookup.c Modified: modules/alias_db/alookup.h Modified: modules/alias_db/api.h Modified: modules/alias_db/doc/alias_db_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a63f390d45d94cbef7cf310bcdaf362… Patch: https://github.com/kamailio/kamailio/commit/a63f390d45d94cbef7cf310bcdaf362…

8 years, 1 month

git:master:0f312342: Makefile.defs: option to disable raw sockets at compile time

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0f3123426d3c9d8e10b8e74557d0791a6df85648 URL: https://github.com/kamailio/kamailio/commit/0f3123426d3c9d8e10b8e74557d0791… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-10-15T18:47:38+02:00 Makefile.defs: option to disable raw sockets at compile time make RAW_SOCKS=no ... --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/0f3123426d3c9d8e10b8e74557d0791… Patch: https://github.com/kamailio/kamailio/commit/0f3123426d3c9d8e10b8e74557d0791… --- diff --git a/Makefile.defs b/Makefile.defs index 715a13a..582fb38 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -89,6 +89,11 @@ endif WITHAS ?= 1 # enable core hooks for SCTP SCTP ?= 1 +# enable raw sockets +RAW_SOCKS ?= yes +ifeq ($(RAW_SOCKS),1) + RAW_SOCKS = yes +endif # what to install INSTALL_FLAVOUR=$(FLAVOUR) @@ -1717,7 +1722,10 @@ ifeq ($(OS), linux) use_futex= yes C_DEFS+=-DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD \ -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H \ - -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DUSE_RAW_SOCKS + -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER + ifneq ($(RAW_SOCKS), yes) + C_DEFS+= -DUSE_RAW_SOCKS + endif ifneq ($(found_lock_method), yes) #C_DEFS+= -DUSE_POSIX_SEM C_DEFS+=-DUSE_PTHREAD_MUTEX @@ -1764,7 +1772,10 @@ ifeq ($(OS), gnu_kfreebsd) use_futex= yes C_DEFS+=-DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD \ -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H \ - -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DUSE_RAW_SOCKS + -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER + ifneq ($(RAW_SOCKS), yes) + C_DEFS+= -DUSE_RAW_SOCKS + endif ifneq ($(found_lock_method), yes) #C_DEFS+= -DUSE_POSIX_SEM C_DEFS+=-DUSE_PTHREAD_MUTEX @@ -1845,7 +1856,10 @@ ifeq ($(OS), freebsd) C_DEFS+=-DHAVE_SOCKADDR_SA_LEN -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN \ -DHAVE_SCHED_YIELD -DHAVE_MSGHDR_MSG_CONTROL \ -DHAVE_CONNECT_ECONNRESET_BUG -DHAVE_TIMEGM \ - -DHAVE_NETINET_IN_SYSTM -DUSE_RAW_SOCKS + -DHAVE_NETINET_IN_SYSTM + ifneq ($(RAW_SOCKS), yes) + C_DEFS+= -DUSE_RAW_SOCKS + endif ifneq ($(found_lock_method), yes) C_DEFS+= -DUSE_PTHREAD_MUTEX # try pthread sems found_lock_method=yes

8 years, 1 month

git:master:99f25469: ctl: take in consideration runtime_dir when creation the ctl socket

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 99f25469c5ce8070210769f9dfe2a16b7333c14d URL: https://github.com/kamailio/kamailio/commit/99f25469c5ce8070210769f9dfe2a16… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-10-15T18:39:05+02:00 ctl: take in consideration runtime_dir when creation the ctl socket --- Modified: modules/ctl/ctl.c --- Diff: https://github.com/kamailio/kamailio/commit/99f25469c5ce8070210769f9dfe2a16… Patch: https://github.com/kamailio/kamailio/commit/99f25469c5ce8070210769f9dfe2a16… --- diff --git a/modules/ctl/ctl.c b/modules/ctl/ctl.c index f630f8a..7e2e11f 100644 --- a/modules/ctl/ctl.c +++ b/modules/ctl/ctl.c @@ -211,11 +211,12 @@ static int fix_group(modparam_t type, void * val) return -1; } - +#define CTL_SOCKET_PATH_SIZE 128 static int mod_init(void) { struct id_list* l; + char ctl_socket_path[CTL_SOCKET_PATH_SIZE]; binrpc_callbacks_init(); @@ -227,7 +228,21 @@ static int mod_init(void) binrpc_struct_max_body_size *= 1024; if (listen_lst==0) { - add_binrpc_socket(PARAM_STRING, DEFAULT_CTL_SOCKET); + if(strcmp(runtime_dir, RUN_DIR)==0) { + add_binrpc_socket(PARAM_STRING, DEFAULT_CTL_SOCKET); + } else { + if(sizeof(DEFAULT_CTL_SOCKET_PROTO) + + sizeof(DEFAULT_CTL_SOCKET_NAME) + + strlen(runtime_dir) + 4 > CTL_SOCKET_PATH_SIZE) { + LM_ERR("ctl socket path is too big\n"); + return -1; + } + strcpy(ctl_socket_path, DEFAULT_CTL_SOCKET_PROTO); + strcat(ctl_socket_path, runtime_dir); + strcat(ctl_socket_path, "/"); + strcat(ctl_socket_path, DEFAULT_CTL_SOCKET_NAME); + add_binrpc_socket(PARAM_STRING, ctl_socket_path); + } } DBG("listening on:\n"); for (l=listen_lst; l; l=l->next){

8 years, 1 month

← Newer
1
...
12
13
14
15
16
17
18
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2016