sr-dev October 2016

sr-dev@lists.kamailio.org

28 participants
234 discussions

git:master:26ed56da: ctl: split the definition of default ctl socket
by Daniel-Constantin Mierla 15 Oct '16

15 Oct '16

Module: kamailio Branch: master Commit: 26ed56da94fde2df51fa0e12e67a790922116d37 URL: https://github.com/kamailio/kamailio/commit/26ed56da94fde2df51fa0e12e67a790… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-10-15T18:31:32+02:00 ctl: split the definition of default ctl socket --- Modified: modules/ctl/ctl_defaults.h --- Diff: https://github.com/kamailio/kamailio/commit/26ed56da94fde2df51fa0e12e67a790… Patch: https://github.com/kamailio/kamailio/commit/26ed56da94fde2df51fa0e12e67a790… --- diff --git a/modules/ctl/ctl_defaults.h b/modules/ctl/ctl_defaults.h index b41aa53..c20fd17 100644 --- a/modules/ctl/ctl_defaults.h +++ b/modules/ctl/ctl_defaults.h @@ -2,13 +2,19 @@ #ifndef __ctl_defaults_h #define __ctl_defaults_h /*listen by default on: */ + +#define DEFAULT_CTL_SOCKET_PROTO "unixs:" + #ifdef SRNAME /* this is used when compiling sercmd tool */ -#define DEFAULT_CTL_SOCKET "unixs:" RUN_DIR "/" SRNAME "_ctl" +#define DEFAULT_CTL_SOCKET_NAME SRNAME "_ctl" #else /* this is used when compiling sip server */ -#define DEFAULT_CTL_SOCKET "unixs:" RUN_DIR "/" NAME "_ctl" +#define DEFAULT_CTL_SOCKET_NAME NAME "_ctl" #endif + +#define DEFAULT_CTL_SOCKET DEFAULT_CTL_SOCKET_PROTO RUN_DIR "/" DEFAULT_CTL_SOCKET_NAME + /* port used by default for tcp/udp if no port is explicitely specified */ #define DEFAULT_CTL_PORT 2049

1 0

git:master:9834ed6e: core: new command line option '-Y dir'
by Daniel-Constantin Mierla 15 Oct '16

15 Oct '16

Module: kamailio Branch: master Commit: 9834ed6ea815bfdb96e9889024c54a9b4b7b3b62 URL: https://github.com/kamailio/kamailio/commit/9834ed6ea815bfdb96e9889024c54a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-10-15T18:23:57+02:00 core: new command line option '-Y dir' - set the runtime directory (used to create fifo, ctl socket, etc...) --- Modified: main.c --- Diff: https://github.com/kamailio/kamailio/commit/9834ed6ea815bfdb96e9889024c54a9… Patch: https://github.com/kamailio/kamailio/commit/9834ed6ea815bfdb96e9889024c54a9… --- diff --git a/main.c b/main.c index 25d283c..cc976e0 100644 --- a/main.c +++ b/main.c @@ -188,8 +188,9 @@ Options:\n\ " -S disable sctp\n\ -Q Number of sctp child processes (default: equal to `-n')\n" #endif /* USE_SCTP */ -" -V Version number\n\ +" -v (-V) Version number\n\ -h This help message\n\ + -I Print more internal compile flags and options\n\ -b nr Maximum receive buffer size which will not be exceeded by\n\ auto-probing procedure even if OS allows\n\ -m nr Size of shared memory allocated in Megabytes\n\ @@ -200,6 +201,7 @@ Options:\n\ -g gid Change gid \n\ -P file Create a pid file\n\ -G file Create a pgid file\n\ + -Y dir Runtime dir\n\ -O nr Script optimization level (debugging option)\n\ -a mode Auto aliases mode: enable with yes or on,\n\ disable with no or off\n\ @@ -1858,7 +1860,7 @@ int main(int argc, char** argv) dprint_init_colors(); /* command line options */ - options= ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:" + options= ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" #ifdef STATS "s:" #endif @@ -2051,6 +2053,7 @@ int main(int argc, char** argv) case 'Q': case 'a': case 's': + case 'Y': break; case '?': if (isprint(optopt)) { @@ -2270,6 +2273,9 @@ int main(int argc, char** argv) case 'w': working_dir=optarg; break; + case 'Y': + runtime_dir=optarg; + break; case 't': chroot_dir=optarg; break;

1 0

Thread safety of global variables used in app_perl
by Alex Balashov 14 Oct '16

14 Oct '16

Hi, Given the presence of a global (e.g. "our") package variable in an embedded Perl script used through app_perl, is there any implicit thread safety? That is to say, can a Perl function invoked by one SIP worker reset the value of a global while another instance of the function invoked by a different SIP worker is accessing it? And if so, is it safe to use generic perlthr locking to avoid this? Thanks! -- Alex -- Alex Balashov | Principal | Evariste Systems LLC Tel: +1-706-510-6800 (direct) / +1-800-250-5920 (toll-free) Web: http://www.evaristesys.com/, http://www.csrpswitch.com/

3 7

git:master:69a89021: core: msg parser - more log message for get body function
by Daniel-Constantin Mierla 14 Oct '16

14 Oct '16

Module: kamailio Branch: master Commit: 69a89021f95b19c803cff3919bf38be2cb1dbbd2 URL: https://github.com/kamailio/kamailio/commit/69a89021f95b19c803cff3919bf38be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-10-14T15:20:53+02:00 core: msg parser - more log message for get body function --- Modified: parser/msg_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/69a89021f95b19c803cff3919bf38be… Patch: https://github.com/kamailio/kamailio/commit/69a89021f95b19c803cff3919bf38be… --- diff --git a/parser/msg_parser.c b/parser/msg_parser.c index 74866a2..54b2f12 100644 --- a/parser/msg_parser.c +++ b/parser/msg_parser.c @@ -1107,12 +1107,15 @@ char* get_body(sip_msg_t* const msg) int offset; unsigned int len; - if ( parse_headers(msg, HDR_EOH_F, 0)==-1 ) + if ( parse_headers(msg, HDR_EOH_F, 0)==-1 ) { + LM_ERR("failed to parse to end of headers\n"); return 0; + } if (msg->unparsed) { len=(unsigned int)(msg->unparsed-msg->buf); } else { + LM_ERR("unparsed hook for end of headers is not set\n"); return 0; } @@ -1122,6 +1125,8 @@ char* get_body(sip_msg_t* const msg) (*(msg->unparsed)=='\n' || *(msg->unparsed)=='\r' ) ) { offset = 1; } else { + LM_ERR("failed to locate end of headers (%p %p - %d %d [%s])\n", + msg->buf, msg->unparsed, msg->len, len, msg->unparsed); return 0; } @@ -1129,7 +1134,7 @@ char* get_body(sip_msg_t* const msg) } /*! \brief make sure all HFs needed for transaction identification have been - parsed; return 0 if those HFs can't be found + * parsed; return 0 if those HFs can't be found */ int check_transaction_quadruple(sip_msg_t* const msg) {

1 0

git:master:a830e527: core: msg parser - relocated static inline functions from header file
by Daniel-Constantin Mierla 14 Oct '16

14 Oct '16

Module: kamailio Branch: master Commit: a830e5271c4567073cef4fee0cde65f7c0979176 URL: https://github.com/kamailio/kamailio/commit/a830e5271c4567073cef4fee0cde65f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-10-14T15:12:29+02:00 core: msg parser - relocated static inline functions from header file - copes beter with latest compiler versions - coherent whitespacing and indentation --- Modified: parser/msg_parser.c Modified: parser/msg_parser.h --- Diff: https://github.com/kamailio/kamailio/commit/a830e5271c4567073cef4fee0cde65f… Patch: https://github.com/kamailio/kamailio/commit/a830e5271c4567073cef4fee0cde65f…

1 0

[kamailio/kamailio] modules/ims_auth, modules/ims_registrar_scscf: fix condition for priv… (#818)
by Federico Cabiddu 14 Oct '16

14 Oct '16

…ate copy of the msg I've been facing recently some inconsistent replies generated from the two modules. Those replies didn't belong to the current request, but to some old transaction. The issue is due to the check made to decide if the current private copy of the message is consistent with the current transaction: due to memory reallocation there are chances that the check gives a false negative, bringing an old message to be used as a base for the reply. Using transaction's index and label is safer IMO. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/818 -- Commit Summary -- * modules/ims_auth, modules/ims_registrar_scscf: fix condition for private copy of the msg -- File Changes -- M modules/ims_auth/pvt_message.c (13) M modules/ims_auth/pvt_message.h (5) M modules/ims_registrar_scscf/pvt_message.c (15) M modules/ims_registrar_scscf/pvt_message.h (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/818.patch https://github.com/kamailio/kamailio/pull/818.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/818

2 5

git:master:4a729bd2: Merge pull request #818 from athonet-open/ims-fix-msg-copy
by GitHub 14 Oct '16

14 Oct '16

Module: kamailio Branch: master Commit: 4a729bd2ef8e5f9d09d7f8e525685fdb52f6e0ae URL: https://github.com/kamailio/kamailio/commit/4a729bd2ef8e5f9d09d7f8e525685fd… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2016-10-14T12:27:57+02:00 Merge pull request #818 from athonet-open/ims-fix-msg-copy modules/ims_auth, modules/ims_registrar_scscf: fix condition for privâ¦ --- Modified: modules/ims_auth/pvt_message.c Modified: modules/ims_auth/pvt_message.h Modified: modules/ims_registrar_scscf/pvt_message.c Modified: modules/ims_registrar_scscf/pvt_message.h --- Diff: https://github.com/kamailio/kamailio/commit/4a729bd2ef8e5f9d09d7f8e525685fd… Patch: https://github.com/kamailio/kamailio/commit/4a729bd2ef8e5f9d09d7f8e525685fd…

1 0

git:master:905961bd: modules/ims_auth, modules/ims_registrar_scscf: fix condition for private copy of the msg
by Federico Cabiddu 14 Oct '16

14 Oct '16

Module: kamailio Branch: master Commit: 905961bd4aaa69139ea5da22466d97e44b3b18b2 URL: https://github.com/kamailio/kamailio/commit/905961bd4aaa69139ea5da22466d97e… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2016-10-10T07:30:29+02:00 modules/ims_auth, modules/ims_registrar_scscf: fix condition for private copy of the msg --- Modified: modules/ims_auth/pvt_message.c Modified: modules/ims_auth/pvt_message.h Modified: modules/ims_registrar_scscf/pvt_message.c Modified: modules/ims_registrar_scscf/pvt_message.h --- Diff: https://github.com/kamailio/kamailio/commit/905961bd4aaa69139ea5da22466d97e… Patch: https://github.com/kamailio/kamailio/commit/905961bd4aaa69139ea5da22466d97e…

1 0

git:master:8846b758: Merge pull request #804 from athonet-open/add-p-associated-uri-on-isc
by GitHub 14 Oct '16

14 Oct '16

Module: kamailio Branch: master Commit: 8846b7582263ac0362c4695638723177f7fa1a88 URL: https://github.com/kamailio/kamailio/commit/8846b7582263ac0362c469563872317… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2016-10-14T12:19:56+02:00 Merge pull request #804 from athonet-open/add-p-associated-uri-on-isc ims_isc: Add tel: associated URI on 3rd party REG --- Modified: modules/ims_isc/mark.c Modified: modules/ims_isc/mod.c Modified: modules/ims_isc/third_party_reg.c Modified: modules/ims_isc/third_party_reg.h --- Diff: https://github.com/kamailio/kamailio/commit/8846b7582263ac0362c469563872317… Patch: https://github.com/kamailio/kamailio/commit/8846b7582263ac0362c469563872317…

1 0

git:master:9e39a2e5: ims_isc: Add tel: associated URI on 3rd party REG
by Federico Favaro 14 Oct '16

14 Oct '16

Module: kamailio Branch: master Commit: 9e39a2e5666c8ea03dd569f3d2c769f6770b0f33 URL: https://github.com/kamailio/kamailio/commit/9e39a2e5666c8ea03dd569f3d2c769f… Author: Federico Favaro <federico.favaro(a)athonet.com> Committer: Federico Favaro <federico.favaro(a)athonet.com> Date: 2016-09-29T10:50:04+02:00 ims_isc: Add tel: associated URI on 3rd party REG Add also tel: as header in 3rd party REG towards TAS --- Modified: modules/ims_isc/mark.c Modified: modules/ims_isc/mod.c Modified: modules/ims_isc/third_party_reg.c Modified: modules/ims_isc/third_party_reg.h --- Diff: https://github.com/kamailio/kamailio/commit/9e39a2e5666c8ea03dd569f3d2c769f… Patch: https://github.com/kamailio/kamailio/commit/9e39a2e5666c8ea03dd569f3d2c769f…

1 0

← Newer
1
...
13
14
15
16
17
18
19
...
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2016